* [linux-next:master 11713/12912] drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: sparse: incorrect type in initializer (different address spaces)
@ 2020-05-28 12:53 kbuild test robot
2020-05-28 13:17 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2020-05-28 12:53 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4345 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8
commit: 2941a4731fd24d5e43ef437cca90818f87fd4851 [11713/12912] m68k: Add missing __user annotation in get_user()
config: m68k-randconfig-s032-20200528 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-240-gf0fe1cd9-dirty
git checkout 2941a4731fd24d5e43ef437cca90818f87fd4851
# save the attached .config to linux build tree
make W=1 C=1 ARCH=m68k CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] <asn:1> * @@ got char *buf @@
drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: expected void const volatile [noderef] <asn:1> *
drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: got char *buf
drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] <asn:1> *__pu_ptr @@ got char *buf @@
drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: expected void const [noderef] <asn:1> *__pu_ptr
drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: got char *buf
drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] <asn:1> * @@ got char const *buf @@
drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: expected void const volatile [noderef] <asn:1> *
drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: got char const *buf
>> drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] <asn:1> *__gu_ptr @@ got char const *buf @@
>> drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: expected void const [noderef] <asn:1> *__gu_ptr
drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: got char const *buf
vim +356 drivers/w1/slaves/w1_ds28e04.c
fbf7f7b4e2ae40 Markus Franke 2012-05-26 347
fa33a65a9cf7e2 Greg Kroah-Hartman 2013-08-21 348 static ssize_t crccheck_store(struct device *dev, struct device_attribute *attr,
fbf7f7b4e2ae40 Markus Franke 2012-05-26 349 const char *buf, size_t count)
fbf7f7b4e2ae40 Markus Franke 2012-05-26 350 {
fbf7f7b4e2ae40 Markus Franke 2012-05-26 351 char val;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 352
fbf7f7b4e2ae40 Markus Franke 2012-05-26 353 if (count != 1 || !buf)
fbf7f7b4e2ae40 Markus Franke 2012-05-26 354 return -EINVAL;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 355
fbf7f7b4e2ae40 Markus Franke 2012-05-26 @356 if (get_user(val, buf))
fbf7f7b4e2ae40 Markus Franke 2012-05-26 357 return -EFAULT;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 358
fbf7f7b4e2ae40 Markus Franke 2012-05-26 359 /* convert to decimal */
fbf7f7b4e2ae40 Markus Franke 2012-05-26 360 val = val - 0x30;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 361 if (val != 0 && val != 1)
fbf7f7b4e2ae40 Markus Franke 2012-05-26 362 return -EINVAL;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 363
fbf7f7b4e2ae40 Markus Franke 2012-05-26 364 /* set the new value */
fbf7f7b4e2ae40 Markus Franke 2012-05-26 365 w1_enable_crccheck = val;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 366
fbf7f7b4e2ae40 Markus Franke 2012-05-26 367 return sizeof(w1_enable_crccheck);
fbf7f7b4e2ae40 Markus Franke 2012-05-26 368 }
fbf7f7b4e2ae40 Markus Franke 2012-05-26 369
:::::: The code at line 356 was first introduced by commit
:::::: fbf7f7b4e2ae40f790828c86d31beff2d49e9ac8 w1: Add 1-wire slave device driver for DS28E04-100
:::::: TO: Markus Franke <franm@hrz.tu-chemnitz.de>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32002 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [linux-next:master 11713/12912] drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: sparse: incorrect type in initializer (different address spaces)
2020-05-28 12:53 [linux-next:master 11713/12912] drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: sparse: incorrect type in initializer (different address spaces) kbuild test robot
@ 2020-05-28 13:17 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2020-05-28 13:17 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4696 bytes --]
On Thu, May 28, 2020 at 2:54 PM kbuild test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8
> commit: 2941a4731fd24d5e43ef437cca90818f87fd4851 [11713/12912] m68k: Add missing __user annotation in get_user()
> config: m68k-randconfig-s032-20200528 (attached as .config)
> compiler: m68k-linux-gcc (GCC) 9.3.0
> reproduce:
> # apt-get install sparse
> # sparse version: v0.6.1-240-gf0fe1cd9-dirty
> git checkout 2941a4731fd24d5e43ef437cca90818f87fd4851
> # save the attached .config to linux build tree
> make W=1 C=1 ARCH=m68k CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
>
>
> sparse warnings: (new ones prefixed by >>)
>
> drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] <asn:1> * @@ got char *buf @@
> drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: expected void const volatile [noderef] <asn:1> *
> drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: got char *buf
> drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] <asn:1> *__pu_ptr @@ got char *buf @@
> drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: expected void const [noderef] <asn:1> *__pu_ptr
> drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: got char *buf
> drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] <asn:1> * @@ got char const *buf @@
> drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: expected void const volatile [noderef] <asn:1> *
> drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: got char const *buf
> >> drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] <asn:1> *__gu_ptr @@ got char const *buf @@
> >> drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: expected void const [noderef] <asn:1> *__gu_ptr
> drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: got char const *buf
>
> vim +356 drivers/w1/slaves/w1_ds28e04.c
>
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 347
> fa33a65a9cf7e2 Greg Kroah-Hartman 2013-08-21 348 static ssize_t crccheck_store(struct device *dev, struct device_attribute *attr,
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 349 const char *buf, size_t count)
"buf" is not a __user pointer (and it shouldn't be).
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 350 {
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 351 char val;
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 352
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 353 if (count != 1 || !buf)
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 354 return -EINVAL;
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 355
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 @356 if (get_user(val, buf))
Hence this causes a warning rightfully.
This should just use "val = *buf;".
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 357 return -EFAULT;
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 358
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 359 /* convert to decimal */
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 360 val = val - 0x30;
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 361 if (val != 0 && val != 1)
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 362 return -EINVAL;
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 363
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 364 /* set the new value */
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 365 w1_enable_crccheck = val;
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 366
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 367 return sizeof(w1_enable_crccheck);
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 368 }
> fbf7f7b4e2ae40 Markus Franke 2012-05-26 369
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-28 13:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 12:53 [linux-next:master 11713/12912] drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: sparse: incorrect type in initializer (different address spaces) kbuild test robot
2020-05-28 13:17 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.