From: Roman Kagan <rvkagan@yandex-team.ru> To: qemu-devel@nongnu.org Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <fam@euphon.net>, "Stefano Stabellini" <sstabellini@kernel.org>, "Daniel P. Berrangé" <berrange@redhat.com>, "Eduardo Habkost" <ehabkost@redhat.com>, qemu-block@nongnu.org, "Paul Durrant" <paul@xen.org>, "Michael S. Tsirkin" <mst@redhat.com>, "Laurent Vivier" <laurent@vivier.eu>, "Max Reitz" <mreitz@redhat.com>, "Anthony Perard" <anthony.perard@citrix.com>, "Gerd Hoffmann" <kraxel@redhat.com>, "Stefan Hajnoczi" <stefanha@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Keith Busch" <kbusch@kernel.org>, xen-devel@lists.xenproject.org, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "John Snow" <jsnow@redhat.com> Subject: [PATCH v7 0/8] block: enhance handling of size-related BlockConf properties Date: Fri, 29 May 2020 00:39:38 +0300 [thread overview] Message-ID: <20200528213946.1636444-1-rvkagan@yandex-team.ru> (raw) BlockConf includes several properties counted in bytes. Enhance their handling in some aspects, specifically - accept common size suffixes (k, m) - perform consistency checks on the values - lift the upper limit on physical_block_size and logical_block_size Also fix the accessor for opt_io_size in virtio-blk to make it consistent with the size of the field. History: v6 -> v7: - avoid overflow in min_io_size check [Eric] - try again to perform the art form in patch splitting [Eric] v5 -> v6: - fix forgotten xen-block and swim - add prop_size32 instead of going with 64bit v4 -> v5: - re-split the patches [Philippe] - fix/reword error messages [Philippe, Kevin] - do early return on failed consistency check [Philippe] - use QEMU_IS_ALIGNED instead of open coding [Philippe] - make all BlockConf size props support suffixes - expand the log for virtio-blk opt_io_size [Michael] v3 -> v4: - add patch to fix opt_io_size width in virtio-blk - add patch to perform consistency checks [Kevin] - check min_io_size against truncation [Kevin] v2 -> v3: - mention qcow2 cluster size limit in the log and comment [Eric] v1 -> v2: - cap the property at 2 MiB [Eric] - accept size suffixes Roman Kagan (8): virtio-blk: store opt_io_size with correct size block: consolidate blocksize properties consistency checks qdev-properties: blocksize: use same limits in code and description qdev-properties: add size32 property type qdev-properties: make blocksize accept size suffixes block: make BlockConf size props 32bit and accept size suffixes qdev-properties: add getter for size32 and blocksize block: lift blocksize property limit to 2 MiB include/hw/block/block.h | 14 +- include/hw/qdev-properties.h | 5 +- hw/block/block.c | 41 ++- hw/block/fdc.c | 5 +- hw/block/nvme.c | 5 +- hw/block/swim.c | 5 +- hw/block/virtio-blk.c | 9 +- hw/block/xen-block.c | 6 +- hw/core/qdev-properties.c | 85 +++++- hw/ide/qdev.c | 5 +- hw/scsi/scsi-disk.c | 12 +- hw/usb/dev-storage.c | 5 +- tests/qemu-iotests/172.out | 532 +++++++++++++++++------------------ 13 files changed, 420 insertions(+), 309 deletions(-) -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Roman Kagan <rvkagan@yandex-team.ru> To: qemu-devel@nongnu.org Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <fam@euphon.net>, "Stefano Stabellini" <sstabellini@kernel.org>, "Daniel P. Berrangé" <berrange@redhat.com>, "Eduardo Habkost" <ehabkost@redhat.com>, qemu-block@nongnu.org, "Paul Durrant" <paul@xen.org>, "Eric Blake" <eblake@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Laurent Vivier" <laurent@vivier.eu>, "Max Reitz" <mreitz@redhat.com>, "Anthony Perard" <anthony.perard@citrix.com>, "Gerd Hoffmann" <kraxel@redhat.com>, "Stefan Hajnoczi" <stefanha@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Keith Busch" <kbusch@kernel.org>, xen-devel@lists.xenproject.org, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "John Snow" <jsnow@redhat.com> Subject: [PATCH v7 0/8] block: enhance handling of size-related BlockConf properties Date: Fri, 29 May 2020 00:39:38 +0300 [thread overview] Message-ID: <20200528213946.1636444-1-rvkagan@yandex-team.ru> (raw) BlockConf includes several properties counted in bytes. Enhance their handling in some aspects, specifically - accept common size suffixes (k, m) - perform consistency checks on the values - lift the upper limit on physical_block_size and logical_block_size Also fix the accessor for opt_io_size in virtio-blk to make it consistent with the size of the field. History: v6 -> v7: - avoid overflow in min_io_size check [Eric] - try again to perform the art form in patch splitting [Eric] v5 -> v6: - fix forgotten xen-block and swim - add prop_size32 instead of going with 64bit v4 -> v5: - re-split the patches [Philippe] - fix/reword error messages [Philippe, Kevin] - do early return on failed consistency check [Philippe] - use QEMU_IS_ALIGNED instead of open coding [Philippe] - make all BlockConf size props support suffixes - expand the log for virtio-blk opt_io_size [Michael] v3 -> v4: - add patch to fix opt_io_size width in virtio-blk - add patch to perform consistency checks [Kevin] - check min_io_size against truncation [Kevin] v2 -> v3: - mention qcow2 cluster size limit in the log and comment [Eric] v1 -> v2: - cap the property at 2 MiB [Eric] - accept size suffixes Roman Kagan (8): virtio-blk: store opt_io_size with correct size block: consolidate blocksize properties consistency checks qdev-properties: blocksize: use same limits in code and description qdev-properties: add size32 property type qdev-properties: make blocksize accept size suffixes block: make BlockConf size props 32bit and accept size suffixes qdev-properties: add getter for size32 and blocksize block: lift blocksize property limit to 2 MiB include/hw/block/block.h | 14 +- include/hw/qdev-properties.h | 5 +- hw/block/block.c | 41 ++- hw/block/fdc.c | 5 +- hw/block/nvme.c | 5 +- hw/block/swim.c | 5 +- hw/block/virtio-blk.c | 9 +- hw/block/xen-block.c | 6 +- hw/core/qdev-properties.c | 85 +++++- hw/ide/qdev.c | 5 +- hw/scsi/scsi-disk.c | 12 +- hw/usb/dev-storage.c | 5 +- tests/qemu-iotests/172.out | 532 +++++++++++++++++------------------ 13 files changed, 420 insertions(+), 309 deletions(-) -- 2.26.2
next reply other threads:[~2020-05-28 21:42 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-28 21:39 Roman Kagan [this message] 2020-05-28 21:39 ` [PATCH v7 0/8] block: enhance handling of size-related BlockConf properties Roman Kagan 2020-05-28 21:39 ` [PATCH v7 1/8] virtio-blk: store opt_io_size with correct size Roman Kagan 2020-05-28 21:39 ` Roman Kagan 2020-05-28 21:39 ` [PATCH v7 2/8] block: consolidate blocksize properties consistency checks Roman Kagan 2020-05-28 21:39 ` Roman Kagan 2020-05-28 21:39 ` [PATCH v7 3/8] qdev-properties: blocksize: use same limits in code and description Roman Kagan 2020-05-28 21:39 ` Roman Kagan 2020-05-28 21:39 ` [PATCH v7 4/8] qdev-properties: add size32 property type Roman Kagan 2020-05-28 21:39 ` Roman Kagan 2020-05-28 21:45 ` Eric Blake 2020-05-28 22:35 ` Roman Kagan 2020-05-28 21:39 ` [PATCH v7 5/8] qdev-properties: make blocksize accept size suffixes Roman Kagan 2020-05-28 21:39 ` Roman Kagan 2020-05-28 21:46 ` Eric Blake 2020-05-28 21:39 ` [PATCH v7 6/8] block: make BlockConf size props 32bit and " Roman Kagan 2020-05-28 21:39 ` Roman Kagan 2020-05-28 21:53 ` Eric Blake 2020-05-28 21:39 ` [PATCH v7 7/8] qdev-properties: add getter for size32 and blocksize Roman Kagan 2020-05-28 21:39 ` Roman Kagan 2020-05-28 21:57 ` Eric Blake 2020-05-28 21:39 ` [PATCH v7 8/8] block: lift blocksize property limit to 2 MiB Roman Kagan 2020-05-28 21:39 ` Roman Kagan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200528213946.1636444-1-rvkagan@yandex-team.ru \ --to=rvkagan@yandex-team.ru \ --cc=anthony.perard@citrix.com \ --cc=berrange@redhat.com \ --cc=ehabkost@redhat.com \ --cc=fam@euphon.net \ --cc=jsnow@redhat.com \ --cc=kbusch@kernel.org \ --cc=kraxel@redhat.com \ --cc=kwolf@redhat.com \ --cc=laurent@vivier.eu \ --cc=mreitz@redhat.com \ --cc=mst@redhat.com \ --cc=paul@xen.org \ --cc=pbonzini@redhat.com \ --cc=philmd@redhat.com \ --cc=qemu-block@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=sstabellini@kernel.org \ --cc=stefanha@redhat.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.