All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm-toolchain: merge binary toolchain recipes
@ 2020-05-28 23:32 Jon Mason
  2020-06-01  9:22 ` Diego Sueiro
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Jon Mason @ 2020-05-28 23:32 UTC (permalink / raw)
  To: meta-arm

Merge the majority of the binary toolchain recipes for building on an
x86 host into a common include file.

Signed-off-by: Jon Mason <jdmason@kudzu.us>
---
 .../gcc-aarch64-none-elf_9.2-2019.12.bb       | 25 ------------------
 .../gcc-arm-none-eabi_9-2019-q4-major.bb      | 25 ------------------
 .../external-arm-toolchain/gcc-x86host.inc    | 26 +++++++++++++++++++
 3 files changed, 26 insertions(+), 50 deletions(-)
 create mode 100644 meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc

diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
index 2ec0f9c..1c61755 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
@@ -11,28 +11,3 @@ PROVIDES = "virtual/aarch64-none-elf-gcc"
 SRC_URI = "https://developer.arm.com/-/media/Files/downloads/gnu-a/9.2-2019.12/binrel/gcc-arm-${PV}-x86_64-aarch64-none-elf.tar.xz"
 
 SRC_URI[sha256sum] = "36d2cbe7c2984f2c20f562ac2f3ba524c59151adfa8ee10f1326c88de337b6d1"
-
-S = "${WORKDIR}/gcc-arm-${PV}-x86_64-aarch64-none-elf"
-
-COMPATIBLE_HOST = "x86_64.*-linux"
-
-do_install() {
-    install -d ${D}${datadir}/aarch64-none-elf/
-    cp -r ${S}/. ${D}${datadir}/aarch64-none-elf/
-
-    install -d ${D}${bindir}
-    # Symlink all executables into bindir
-    for f in ${D}${datadir}/aarch64-none-elf/bin/aarch64-none-elf-*; do
-        lnr $f ${D}${bindir}/$(basename $f)
-    done
-}
-
-FILES_${PN} = "${datadir} ${bindir}"
-
-INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps"
-
-INHIBIT_SYSROOT_STRIP = "1"
-INHIBIT_PACKAGE_STRIP = "1"
-INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
-
-BBCLASSEXTEND = "native nativesdk"
diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
index 84f6dba..e0c220b 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
@@ -12,28 +12,3 @@ SRC_URI = "https://developer.arm.com/-/media/Files/downloads/gnu-rm/9-2019q4/${B
 
 SRC_URI[md5sum] = "fe0029de4f4ec43cf7008944e34ff8cc"
 SRC_URI[sha256sum] = "bcd840f839d5bf49279638e9f67890b2ef3a7c9c7a9b25271e83ec4ff41d177a"
-
-S = "${WORKDIR}/${BPN}-${PV}"
-
-COMPATIBLE_HOST = "x86_64.*-linux"
-
-do_install() {
-    install -d ${D}${datadir}/arm-none-eabi/
-    cp -r ${S}/. ${D}${datadir}/arm-none-eabi/
-
-    install -d ${D}${bindir}
-    # Symlink all executables into bindir
-    for f in ${D}${datadir}/arm-none-eabi/bin/arm-none-eabi-*; do
-        lnr $f ${D}${bindir}/$(basename $f)
-    done
-}
-
-FILES_${PN} = "${datadir} ${bindir}"
-
-INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps"
-
-INHIBIT_SYSROOT_STRIP = "1"
-INHIBIT_PACKAGE_STRIP = "1"
-INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
-
-BBCLASSEXTEND = "native nativesdk"
diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc
new file mode 100644
index 0000000..7cfe5a3
--- /dev/null
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc
@@ -0,0 +1,26 @@
+S = "${WORKDIR}/${BPN}-${PV}"
+
+COMPATIBLE_HOST = "x86_64.*-linux"
+
+FILES_${PN} = "${datadir} ${bindir}"
+
+NAME = "${BPN}".strip("gcc-")
+
+do_install() {
+    install -d ${D}${datadir}/${NAME}/
+    cp -r ${S}/. ${D}${datadir}/${NAME}/
+
+    install -d ${D}${bindir}
+    # Symlink all executables into bindir
+    for f in ${D}${datadir}/${NAME}/bin/${NAME}-*; do
+        lnr $f ${D}${bindir}/$(basename $f)
+    done
+}
+
+INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps"
+
+INHIBIT_SYSROOT_STRIP = "1"
+INHIBIT_PACKAGE_STRIP = "1"
+INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
+
+BBCLASSEXTEND = "native nativesdk"
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm-toolchain: merge binary toolchain recipes
  2020-05-28 23:32 [PATCH] arm-toolchain: merge binary toolchain recipes Jon Mason
@ 2020-06-01  9:22 ` Diego Sueiro
  2020-06-01  9:30 ` Diego Sueiro
  2020-06-01 16:12 ` [meta-arm] " Ross Burton
  2 siblings, 0 replies; 6+ messages in thread
From: Diego Sueiro @ 2020-06-01  9:22 UTC (permalink / raw)
  To: meta-arm

On Fri, May 29, 2020 at 12:32 AM, Jon Mason wrote:

>
> Merge the majority of the binary toolchain recipes for building on an
> x86 host into a common include file.
> 
> Signed-off-by: Jon Mason <jdmason@kudzu.us>

Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

> ---
>  .../gcc-aarch64-none-elf_9.2-2019.12.bb       | 25 ------------------
>  .../gcc-arm-none-eabi_9-2019-q4-major.bb      | 25 ------------------
>  .../external-arm-toolchain/gcc-x86host.inc    | 26 +++++++++++++++++++
>  3 files changed, 26 insertions(+), 50 deletions(-)
>  create mode 100644
> meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc
> 
> diff --git
> b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> index 2ec0f9c..1c61755 100644
> ---
> a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> +++
> b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> @@ -11,28 +11,3 @@ PROVIDES = "virtual/aarch64-none-elf-gcc"
>  SRC_URI =
> "https://developer.arm.com/-/media/Files/downloads/gnu-a/9.2-2019.12/binrel/gcc-arm-${PV}-x86_64-aarch64-none-elf.tar.xz"
>
>  SRC_URI[sha256sum] =
> "36d2cbe7c2984f2c20f562ac2f3ba524c59151adfa8ee10f1326c88de337b6d1"
> -
> -S = "${WORKDIR}/gcc-arm-${PV}-x86_64-aarch64-none-elf"
> -
> -COMPATIBLE_HOST = "x86_64.*-linux"
> -
> -do_install() {
> -    install -d ${D}${datadir}/aarch64-none-elf/
> -    cp -r ${S}/. ${D}${datadir}/aarch64-none-elf/
> -
> -    install -d ${D}${bindir}
> -    # Symlink all executables into bindir
> -    for f in ${D}${datadir}/aarch64-none-elf/bin/aarch64-none-elf-*; do
> -        lnr $f ${D}${bindir}/$(basename $f)
> -    done
> -}
> -
> -FILES_${PN} = "${datadir} ${bindir}"
> -
> -INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps"
> -
> -INHIBIT_SYSROOT_STRIP = "1"
> -INHIBIT_PACKAGE_STRIP = "1"
> -INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> -
> -BBCLASSEXTEND = "native nativesdk"
> diff --git
> b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> index 84f6dba..e0c220b 100644
> ---
> a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> +++
> b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> @@ -12,28 +12,3 @@ SRC_URI =
> "https://developer.arm.com/-/media/Files/downloads/gnu-rm/9-2019q4/${B
>
>  SRC_URI[md5sum] = "fe0029de4f4ec43cf7008944e34ff8cc"
>  SRC_URI[sha256sum] =
> "bcd840f839d5bf49279638e9f67890b2ef3a7c9c7a9b25271e83ec4ff41d177a"
> -
> -S = "${WORKDIR}/${BPN}-${PV}"
> -
> -COMPATIBLE_HOST = "x86_64.*-linux"
> -
> -do_install() {
> -    install -d ${D}${datadir}/arm-none-eabi/
> -    cp -r ${S}/. ${D}${datadir}/arm-none-eabi/
> -
> -    install -d ${D}${bindir}
> -    # Symlink all executables into bindir
> -    for f in ${D}${datadir}/arm-none-eabi/bin/arm-none-eabi-*; do
> -        lnr $f ${D}${bindir}/$(basename $f)
> -    done
> -}
> -
> -FILES_${PN} = "${datadir} ${bindir}"
> -
> -INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps"
> -
> -INHIBIT_SYSROOT_STRIP = "1"
> -INHIBIT_PACKAGE_STRIP = "1"
> -INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> -
> -BBCLASSEXTEND = "native nativesdk"
> diff --git
> a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc
> b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc
> new file mode 100644
> index 0000000..7cfe5a3
> --- /dev/null
> +++
> b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc
> @@ -0,0 +1,26 @@
> +S = "${WORKDIR}/${BPN}-${PV}"
> +
> +COMPATIBLE_HOST = "x86_64.*-linux"
> +
> +FILES_${PN} = "${datadir} ${bindir}"
> +
> +NAME = "${BPN}".strip("gcc-")
> +
> +do_install() {
> +    install -d ${D}${datadir}/${NAME}/
> +    cp -r ${S}/. ${D}${datadir}/${NAME}/
> +
> +    install -d ${D}${bindir}
> +    # Symlink all executables into bindir
> +    for f in ${D}${datadir}/${NAME}/bin/${NAME}-*; do
> +        lnr $f ${D}${bindir}/$(basename $f)
> +    done
> +}
> +
> +INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps"
> +
> +INHIBIT_SYSROOT_STRIP = "1"
> +INHIBIT_PACKAGE_STRIP = "1"
> +INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> +
> +BBCLASSEXTEND = "native nativesdk"
> -- 
> 2.20.1
> 
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm-toolchain: merge binary toolchain recipes
  2020-05-28 23:32 [PATCH] arm-toolchain: merge binary toolchain recipes Jon Mason
  2020-06-01  9:22 ` Diego Sueiro
@ 2020-06-01  9:30 ` Diego Sueiro
  2020-06-01 16:12 ` [meta-arm] " Ross Burton
  2 siblings, 0 replies; 6+ messages in thread
From: Diego Sueiro @ 2020-06-01  9:30 UTC (permalink / raw)
  To: meta-arm

On Fri, May 29, 2020 at 12:32 AM, Jon Mason wrote:

>
> Merge the majority of the binary toolchain recipes for building on an
> x86 host into a common include file.
> 
> Signed-off-by: Jon Mason <jdmason@kudzu.us>
> ---
>  .../gcc-aarch64-none-elf_9.2-2019.12.bb       | 25 ------------------
>  .../gcc-arm-none-eabi_9-2019-q4-major.bb      | 25 ------------------
>  .../external-arm-toolchain/gcc-x86host.inc    | 26 +++++++++++++++++++
>  3 files changed, 26 insertions(+), 50 deletions(-)
>  create mode 100644
> meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc
> 
> diff --git
> b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> index 2ec0f9c..1c61755 100644
> ---
> a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> +++
> b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> @@ -11,28 +11,3 @@ PROVIDES = "virtual/aarch64-none-elf-gcc"
>  SRC_URI =
> "https://developer.arm.com/-/media/Files/downloads/gnu-a/9.2-2019.12/binrel/gcc-arm-${PV}-x86_64-aarch64-none-elf.tar.xz"
>
>  SRC_URI[sha256sum] =
> "36d2cbe7c2984f2c20f562ac2f3ba524c59151adfa8ee10f1326c88de337b6d1"
> -
> -S = "${WORKDIR}/gcc-arm-${PV}-x86_64-aarch64-none-elf"
> -
> -COMPATIBLE_HOST = "x86_64.*-linux"
> -
> -do_install() {
> -    install -d ${D}${datadir}/aarch64-none-elf/
> -    cp -r ${S}/. ${D}${datadir}/aarch64-none-elf/
> -
> -    install -d ${D}${bindir}
> -    # Symlink all executables into bindir
> -    for f in ${D}${datadir}/aarch64-none-elf/bin/aarch64-none-elf-*; do
> -        lnr $f ${D}${bindir}/$(basename $f)
> -    done
> -}
> -
> -FILES_${PN} = "${datadir} ${bindir}"
> -
> -INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps"
> -
> -INHIBIT_SYSROOT_STRIP = "1"
> -INHIBIT_PACKAGE_STRIP = "1"
> -INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> -
> -BBCLASSEXTEND = "native nativesdk"
> diff --git
> b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> index 84f6dba..e0c220b 100644
> ---
> a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> +++
> b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> @@ -12,28 +12,3 @@ SRC_URI =
> "https://developer.arm.com/-/media/Files/downloads/gnu-rm/9-2019q4/${B
>
>  SRC_URI[md5sum] = "fe0029de4f4ec43cf7008944e34ff8cc"
>  SRC_URI[sha256sum] =
> "bcd840f839d5bf49279638e9f67890b2ef3a7c9c7a9b25271e83ec4ff41d177a"
> -
> -S = "${WORKDIR}/${BPN}-${PV}"
> -
> -COMPATIBLE_HOST = "x86_64.*-linux"
> -
> -do_install() {
> -    install -d ${D}${datadir}/arm-none-eabi/
> -    cp -r ${S}/. ${D}${datadir}/arm-none-eabi/
> -
> -    install -d ${D}${bindir}
> -    # Symlink all executables into bindir
> -    for f in ${D}${datadir}/arm-none-eabi/bin/arm-none-eabi-*; do
> -        lnr $f ${D}${bindir}/$(basename $f)
> -    done
> -}
> -
> -FILES_${PN} = "${datadir} ${bindir}"
> -
> -INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps"
> -
> -INHIBIT_SYSROOT_STRIP = "1"
> -INHIBIT_PACKAGE_STRIP = "1"
> -INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> -
> -BBCLASSEXTEND = "native nativesdk"
> diff --git
> a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc
> b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc
> new file mode 100644
> index 0000000..7cfe5a3
> --- /dev/null
> +++
> b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc

Aren't you missing `require gcc-x86host.inc` in the other gcc recipes?

> @@ -0,0 +1,26 @@
> +S = "${WORKDIR}/${BPN}-${PV}"
> +
> +COMPATIBLE_HOST = "x86_64.*-linux"
> +
> +FILES_${PN} = "${datadir} ${bindir}"
> +
> +NAME = "${BPN}".strip("gcc-")
> +
> +do_install() {
> +    install -d ${D}${datadir}/${NAME}/
> +    cp -r ${S}/. ${D}${datadir}/${NAME}/
> +
> +    install -d ${D}${bindir}
> +    # Symlink all executables into bindir
> +    for f in ${D}${datadir}/${NAME}/bin/${NAME}-*; do
> +        lnr $f ${D}${bindir}/$(basename $f)
> +    done
> +}
> +
> +INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps"
> +
> +INHIBIT_SYSROOT_STRIP = "1"
> +INHIBIT_PACKAGE_STRIP = "1"
> +INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> +
> +BBCLASSEXTEND = "native nativesdk"
> -- 
> 2.20.1
> 
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-arm] [PATCH] arm-toolchain: merge binary toolchain recipes
  2020-05-28 23:32 [PATCH] arm-toolchain: merge binary toolchain recipes Jon Mason
  2020-06-01  9:22 ` Diego Sueiro
  2020-06-01  9:30 ` Diego Sueiro
@ 2020-06-01 16:12 ` Ross Burton
  2020-06-01 23:35   ` Jon Mason
  2020-06-05 22:59   ` Denys Dmytriyenko
  2 siblings, 2 replies; 6+ messages in thread
From: Ross Burton @ 2020-06-01 16:12 UTC (permalink / raw)
  To: Jon Mason; +Cc: meta-arm

On Fri, 29 May 2020 at 00:32, Jon Mason <jdmason@kudzu.us> wrote:
> -
> -S = "${WORKDIR}/gcc-arm-${PV}-x86_64-aarch64-none-elf"
> -
> -COMPATIBLE_HOST = "x86_64.*-linux"
> -
> -do_install() {
> -    install -d ${D}${datadir}/aarch64-none-elf/
> -    cp -r ${S}/. ${D}${datadir}/aarch64-none-elf/
> -
> -    install -d ${D}${bindir}
> -    # Symlink all executables into bindir
> -    for f in ${D}${datadir}/aarch64-none-elf/bin/aarch64-none-elf-*; do
> -        lnr $f ${D}${bindir}/$(basename $f)
> -    done
> -}
> -
> -FILES_${PN} = "${datadir} ${bindir}"
> -
> -INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps"
> -
> -INHIBIT_SYSROOT_STRIP = "1"
> -INHIBIT_PACKAGE_STRIP = "1"
> -INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> -
> -BBCLASSEXTEND = "native nativesdk"

Forgot to include the include file.

> +S = "${WORKDIR}/${BPN}-${PV}"

That's the default value.

> +NAME = "${BPN}".strip("gcc-")

That is a syntax error.  Looking at the repetition below, maybe this
would be better (untested):

BINPATH="${datadir}${@d.getVar("BPN").strip("gcc-")}"

Ross

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-arm] [PATCH] arm-toolchain: merge binary toolchain recipes
  2020-06-01 16:12 ` [meta-arm] " Ross Burton
@ 2020-06-01 23:35   ` Jon Mason
  2020-06-05 22:59   ` Denys Dmytriyenko
  1 sibling, 0 replies; 6+ messages in thread
From: Jon Mason @ 2020-06-01 23:35 UTC (permalink / raw)
  To: Ross Burton; +Cc: meta-arm

On Mon, Jun 01, 2020 at 05:12:57PM +0100, Ross Burton wrote:
> On Fri, 29 May 2020 at 00:32, Jon Mason <jdmason@kudzu.us> wrote:
> > -
> > -S = "${WORKDIR}/gcc-arm-${PV}-x86_64-aarch64-none-elf"
> > -
> > -COMPATIBLE_HOST = "x86_64.*-linux"
> > -
> > -do_install() {
> > -    install -d ${D}${datadir}/aarch64-none-elf/
> > -    cp -r ${S}/. ${D}${datadir}/aarch64-none-elf/
> > -
> > -    install -d ${D}${bindir}
> > -    # Symlink all executables into bindir
> > -    for f in ${D}${datadir}/aarch64-none-elf/bin/aarch64-none-elf-*; do
> > -        lnr $f ${D}${bindir}/$(basename $f)
> > -    done
> > -}
> > -
> > -FILES_${PN} = "${datadir} ${bindir}"
> > -
> > -INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps"
> > -
> > -INHIBIT_SYSROOT_STRIP = "1"
> > -INHIBIT_PACKAGE_STRIP = "1"
> > -INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> > -
> > -BBCLASSEXTEND = "native nativesdk"
> 
> Forgot to include the include file.
> 
> > +S = "${WORKDIR}/${BPN}-${PV}"
> 
> That's the default value.
> 
> > +NAME = "${BPN}".strip("gcc-")
> 
> That is a syntax error.  Looking at the repetition below, maybe this
> would be better (untested):

Wait, you are not testing this?  SHAME!  Disregard my lack of testing,
as rules do not apply to me.

> BINPATH="${datadir}${@d.getVar("BPN").strip("gcc-")}"

So, this doesn't work, as it outputs 
gcc-arm-none-eabi/usr/share/usr/share/arm-none-eabi/arm-none-eabi/
instead of 
gcc-arm-none-eabi/usr/share/arm-none-eabi/

This is due to the multiple ways this is being used.  I think the
better solution is 
BINNAME = "${@d.getVar("BPN").strip("gcc-")}"

I'll send out v2 shortly.  Thanks for the eyes.

Thanks,
Jon

> 
> Ross

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-arm] [PATCH] arm-toolchain: merge binary toolchain recipes
  2020-06-01 16:12 ` [meta-arm] " Ross Burton
  2020-06-01 23:35   ` Jon Mason
@ 2020-06-05 22:59   ` Denys Dmytriyenko
  1 sibling, 0 replies; 6+ messages in thread
From: Denys Dmytriyenko @ 2020-06-05 22:59 UTC (permalink / raw)
  To: Ross Burton; +Cc: Jon Mason, meta-arm

On Mon, Jun 01, 2020 at 05:12:57PM +0100, Ross Burton wrote:
> On Fri, 29 May 2020 at 00:32, Jon Mason <jdmason@kudzu.us> wrote:
> > -
> > -S = "${WORKDIR}/gcc-arm-${PV}-x86_64-aarch64-none-elf"
> 
> > +S = "${WORKDIR}/${BPN}-${PV}"
> 
> That's the default value.

Yeah, that's the default for one recipe, not the other...

-- 
Denys

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-06-05 22:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 23:32 [PATCH] arm-toolchain: merge binary toolchain recipes Jon Mason
2020-06-01  9:22 ` Diego Sueiro
2020-06-01  9:30 ` Diego Sueiro
2020-06-01 16:12 ` [meta-arm] " Ross Burton
2020-06-01 23:35   ` Jon Mason
2020-06-05 22:59   ` Denys Dmytriyenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.