All of lore.kernel.org
 help / color / mirror / Atom feed
* [linux-next:master 9370/13554] drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no previous prototype for 'rtw_pci_shutdown'
@ 2020-05-29  1:45 kbuild test robot
  2020-05-29  2:54 ` Tony Chuang
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2020-05-29  1:45 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3183 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   ff387fc20c697cdc887b2abf7ef494e853795a2f
commit: ba0fbe236fb8a7b992e82d6eafb03a600f5eba43 [9370/13554] rtw88: extract: make 8822c an individual kernel module
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout ba0fbe236fb8a7b992e82d6eafb03a600f5eba43
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe' [-Wmissing-prototypes]
1477 | int rtw_pci_probe(struct pci_dev *pdev,
|     ^~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no previous prototype for 'rtw_pci_remove' [-Wmissing-prototypes]
1557 | void rtw_pci_remove(struct pci_dev *pdev)
|      ^~~~~~~~~~~~~~
>> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no previous prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes]
1579 | void rtw_pci_shutdown(struct pci_dev *pdev)
|      ^~~~~~~~~~~~~~~~

vim +/rtw_pci_shutdown +1579 drivers/net/wireless/realtek/rtw88/pci.c

e3037485c68ec1 Yan-Hsuan Chuang 2019-04-26  1578  
72f256c2b94862 Zong-Zhe Yang    2020-05-15 @1579  void rtw_pci_shutdown(struct pci_dev *pdev)
05202746ed70ea Ping-Ke Shih     2020-05-12  1580  {
05202746ed70ea Ping-Ke Shih     2020-05-12  1581  	struct ieee80211_hw *hw = pci_get_drvdata(pdev);
05202746ed70ea Ping-Ke Shih     2020-05-12  1582  	struct rtw_dev *rtwdev;
05202746ed70ea Ping-Ke Shih     2020-05-12  1583  	struct rtw_chip_info *chip;
05202746ed70ea Ping-Ke Shih     2020-05-12  1584  
05202746ed70ea Ping-Ke Shih     2020-05-12  1585  	if (!hw)
05202746ed70ea Ping-Ke Shih     2020-05-12  1586  		return;
05202746ed70ea Ping-Ke Shih     2020-05-12  1587  
05202746ed70ea Ping-Ke Shih     2020-05-12  1588  	rtwdev = hw->priv;
05202746ed70ea Ping-Ke Shih     2020-05-12  1589  	chip = rtwdev->chip;
05202746ed70ea Ping-Ke Shih     2020-05-12  1590  
05202746ed70ea Ping-Ke Shih     2020-05-12  1591  	if (chip->ops->shutdown)
05202746ed70ea Ping-Ke Shih     2020-05-12  1592  		chip->ops->shutdown(rtwdev);
05202746ed70ea Ping-Ke Shih     2020-05-12  1593  }
72f256c2b94862 Zong-Zhe Yang    2020-05-15  1594  EXPORT_SYMBOL(rtw_pci_shutdown);
05202746ed70ea Ping-Ke Shih     2020-05-12  1595  

:::::: The code at line 1579 was first introduced by commit
:::::: 72f256c2b948622cc45ff8bc0456dd6039d8fe36 rtw88: extract: export symbols about pci interface

:::::: TO: Zong-Zhe Yang <kevin_yang@realtek.com>
:::::: CC: Kalle Valo <kvalo@codeaurora.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 57881 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [linux-next:master 9370/13554] drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no previous prototype for 'rtw_pci_shutdown'
  2020-05-29  1:45 [linux-next:master 9370/13554] drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no previous prototype for 'rtw_pci_shutdown' kbuild test robot
@ 2020-05-29  2:54 ` Tony Chuang
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Chuang @ 2020-05-29  2:54 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2009 bytes --]

> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no previous
> prototype for 'rtw_pci_shutdown'
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> master
> head:   ff387fc20c697cdc887b2abf7ef494e853795a2f
> commit: ba0fbe236fb8a7b992e82d6eafb03a600f5eba43 [9370/13554] rtw88:
> extract: make 8822c an individual kernel module
> config: ia64-allmodconfig (attached as .config)
> compiler: ia64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
> ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout ba0fbe236fb8a7b992e82d6eafb03a600f5eba43
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0
> make.cross ARCH=ia64
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>, old ones prefixed by <<):
> 
> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous
> prototype for 'rtw_pci_probe' [-Wmissing-prototypes]
> 1477 | int rtw_pci_probe(struct pci_dev *pdev,
> |     ^~~~~~~~~~~~~
> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no previous
> prototype for 'rtw_pci_remove' [-Wmissing-prototypes]
> 1557 | void rtw_pci_remove(struct pci_dev *pdev)
> |      ^~~~~~~~~~~~~~
> >> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no previous
> >> prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes]
> 1579 | void rtw_pci_shutdown(struct pci_dev *pdev)
> |      ^~~~~~~~~~~~~~~~

The symbol was extracted for the follow-up patches, so it's already fixed.

f56f08636dda ("rtw88: extract: make 8723d an individual kernel module")
416e87fcc780 ("rtw88: extract: make 8822b an individual kernel module")
ba0fbe236fb8 ("rtw88: extract: make 8822c an individual kernel module")

Thanks.
Yan-Hsuan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-29  2:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-29  1:45 [linux-next:master 9370/13554] drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no previous prototype for 'rtw_pci_shutdown' kbuild test robot
2020-05-29  2:54 ` Tony Chuang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.