* [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property @ 2020-05-20 7:33 ` Johan Jonker 0 siblings, 0 replies; 16+ messages in thread From: Johan Jonker @ 2020-05-20 7:33 UTC (permalink / raw) To: heiko Cc: robh+dt, dmitry.torokhov, linux-input, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel A test with the command below gives this error: arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: touchscreen@3e: reg:0:0: 56 was expected The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models was shipped with different addresses then the binding currently allows. Change the reg property that any address will pass. make ARCH=arm dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ edt-ft5x06.yaml Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml index 383d64a91..baa8e8f7e 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml @@ -42,7 +42,7 @@ properties: - focaltech,ft6236 reg: - const: 0x38 + maxItems: 1 interrupts: maxItems: 1 -- 2.11.0 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property @ 2020-05-20 7:33 ` Johan Jonker 0 siblings, 0 replies; 16+ messages in thread From: Johan Jonker @ 2020-05-20 7:33 UTC (permalink / raw) To: heiko Cc: devicetree, dmitry.torokhov, linux-kernel, linux-rockchip, robh+dt, linux-input, linux-arm-kernel A test with the command below gives this error: arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: touchscreen@3e: reg:0:0: 56 was expected The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models was shipped with different addresses then the binding currently allows. Change the reg property that any address will pass. make ARCH=arm dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ edt-ft5x06.yaml Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml index 383d64a91..baa8e8f7e 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml @@ -42,7 +42,7 @@ properties: - focaltech,ft6236 reg: - const: 0x38 + maxItems: 1 interrupts: maxItems: 1 -- 2.11.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property @ 2020-05-20 7:33 ` Johan Jonker 0 siblings, 0 replies; 16+ messages in thread From: Johan Jonker @ 2020-05-20 7:33 UTC (permalink / raw) To: heiko-4mtYJXux2i+zQB+pC5nmwQ Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w, linux-input-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA A test with the command below gives this error: arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: touchscreen@3e: reg:0:0: 56 was expected The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models was shipped with different addresses then the binding currently allows. Change the reg property that any address will pass. make ARCH=arm dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ edt-ft5x06.yaml Signed-off-by: Johan Jonker <jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml index 383d64a91..baa8e8f7e 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml @@ -42,7 +42,7 @@ properties: - focaltech,ft6236 reg: - const: 0x38 + maxItems: 1 interrupts: maxItems: 1 -- 2.11.0 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property 2020-05-20 7:33 ` Johan Jonker @ 2020-05-20 17:13 ` Dmitry Torokhov -1 siblings, 0 replies; 16+ messages in thread From: Dmitry Torokhov @ 2020-05-20 17:13 UTC (permalink / raw) To: Johan Jonker Cc: heiko, robh+dt, linux-input, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel Hi Johan, On Wed, May 20, 2020 at 09:33:27AM +0200, Johan Jonker wrote: > A test with the command below gives this error: > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: > touchscreen@3e: reg:0:0: 56 was expected > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models > was shipped with different addresses then the binding currently allows. > Change the reg property that any address will pass. > > make ARCH=arm dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ > edt-ft5x06.yaml > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > index 383d64a91..baa8e8f7e 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > @@ -42,7 +42,7 @@ properties: > - focaltech,ft6236 > > reg: > - const: 0x38 > + maxItems: 1 Should we have a list of valid addresses instead of allowing any address? Controllers usually have only a couple of addresses that they support. Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property @ 2020-05-20 17:13 ` Dmitry Torokhov 0 siblings, 0 replies; 16+ messages in thread From: Dmitry Torokhov @ 2020-05-20 17:13 UTC (permalink / raw) To: Johan Jonker Cc: devicetree, heiko, linux-kernel, linux-rockchip, robh+dt, linux-input, linux-arm-kernel Hi Johan, On Wed, May 20, 2020 at 09:33:27AM +0200, Johan Jonker wrote: > A test with the command below gives this error: > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: > touchscreen@3e: reg:0:0: 56 was expected > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models > was shipped with different addresses then the binding currently allows. > Change the reg property that any address will pass. > > make ARCH=arm dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ > edt-ft5x06.yaml > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > index 383d64a91..baa8e8f7e 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > @@ -42,7 +42,7 @@ properties: > - focaltech,ft6236 > > reg: > - const: 0x38 > + maxItems: 1 Should we have a list of valid addresses instead of allowing any address? Controllers usually have only a couple of addresses that they support. Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property 2020-05-20 17:13 ` Dmitry Torokhov (?) @ 2020-05-20 18:41 ` Heiko Stübner -1 siblings, 0 replies; 16+ messages in thread From: Heiko Stübner @ 2020-05-20 18:41 UTC (permalink / raw) To: Dmitry Torokhov Cc: Johan Jonker, robh+dt, linux-input, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel Hi Dmitry, Am Mittwoch, 20. Mai 2020, 19:13:24 CEST schrieb Dmitry Torokhov: > Hi Johan, > > On Wed, May 20, 2020 at 09:33:27AM +0200, Johan Jonker wrote: > > A test with the command below gives this error: > > > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: > > touchscreen@3e: reg:0:0: 56 was expected > > > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models > > was shipped with different addresses then the binding currently allows. > > Change the reg property that any address will pass. > > > > make ARCH=arm dtbs_check > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ > > edt-ft5x06.yaml > > > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > > --- > > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > index 383d64a91..baa8e8f7e 100644 > > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > @@ -42,7 +42,7 @@ properties: > > - focaltech,ft6236 > > > > reg: > > - const: 0x38 > > + maxItems: 1 > > Should we have a list of valid addresses instead of allowing any > address? Controllers usually have only a couple of addresses that they > support. from what I've read, the fdt touchscreen controllers are just a generic cpu with device-specific (or better panel-specific) firmware, which seems to include the address as well - so it looks to be variable. But of course that is only 2nd hand knowledge for me ;-) But also, the i2c address is something you cannot really mess up, either it is correct and your touchscreen works, or it isn't and and adding entries to this list every time a new address variant pops up feels clumsy. Heiko ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property @ 2020-05-20 18:41 ` Heiko Stübner 0 siblings, 0 replies; 16+ messages in thread From: Heiko Stübner @ 2020-05-20 18:41 UTC (permalink / raw) To: Dmitry Torokhov Cc: devicetree, linux-kernel, linux-rockchip, robh+dt, linux-input, Johan Jonker, linux-arm-kernel Hi Dmitry, Am Mittwoch, 20. Mai 2020, 19:13:24 CEST schrieb Dmitry Torokhov: > Hi Johan, > > On Wed, May 20, 2020 at 09:33:27AM +0200, Johan Jonker wrote: > > A test with the command below gives this error: > > > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: > > touchscreen@3e: reg:0:0: 56 was expected > > > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models > > was shipped with different addresses then the binding currently allows. > > Change the reg property that any address will pass. > > > > make ARCH=arm dtbs_check > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ > > edt-ft5x06.yaml > > > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > > --- > > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > index 383d64a91..baa8e8f7e 100644 > > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > @@ -42,7 +42,7 @@ properties: > > - focaltech,ft6236 > > > > reg: > > - const: 0x38 > > + maxItems: 1 > > Should we have a list of valid addresses instead of allowing any > address? Controllers usually have only a couple of addresses that they > support. from what I've read, the fdt touchscreen controllers are just a generic cpu with device-specific (or better panel-specific) firmware, which seems to include the address as well - so it looks to be variable. But of course that is only 2nd hand knowledge for me ;-) But also, the i2c address is something you cannot really mess up, either it is correct and your touchscreen works, or it isn't and and adding entries to this list every time a new address variant pops up feels clumsy. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property @ 2020-05-20 18:41 ` Heiko Stübner 0 siblings, 0 replies; 16+ messages in thread From: Heiko Stübner @ 2020-05-20 18:41 UTC (permalink / raw) To: Dmitry Torokhov Cc: Johan Jonker, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, linux-input-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA Hi Dmitry, Am Mittwoch, 20. Mai 2020, 19:13:24 CEST schrieb Dmitry Torokhov: > Hi Johan, > > On Wed, May 20, 2020 at 09:33:27AM +0200, Johan Jonker wrote: > > A test with the command below gives this error: > > > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: > > touchscreen@3e: reg:0:0: 56 was expected > > > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models > > was shipped with different addresses then the binding currently allows. > > Change the reg property that any address will pass. > > > > make ARCH=arm dtbs_check > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ > > edt-ft5x06.yaml > > > > Signed-off-by: Johan Jonker <jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > --- > > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > index 383d64a91..baa8e8f7e 100644 > > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > @@ -42,7 +42,7 @@ properties: > > - focaltech,ft6236 > > > > reg: > > - const: 0x38 > > + maxItems: 1 > > Should we have a list of valid addresses instead of allowing any > address? Controllers usually have only a couple of addresses that they > support. from what I've read, the fdt touchscreen controllers are just a generic cpu with device-specific (or better panel-specific) firmware, which seems to include the address as well - so it looks to be variable. But of course that is only 2nd hand knowledge for me ;-) But also, the i2c address is something you cannot really mess up, either it is correct and your touchscreen works, or it isn't and and adding entries to this list every time a new address variant pops up feels clumsy. Heiko ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property 2020-05-20 18:41 ` Heiko Stübner (?) @ 2020-05-28 22:01 ` Rob Herring -1 siblings, 0 replies; 16+ messages in thread From: Rob Herring @ 2020-05-28 22:01 UTC (permalink / raw) To: Heiko Stübner Cc: Dmitry Torokhov, Johan Jonker, linux-input, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel On Wed, May 20, 2020 at 08:41:59PM +0200, Heiko Stübner wrote: > Hi Dmitry, > > Am Mittwoch, 20. Mai 2020, 19:13:24 CEST schrieb Dmitry Torokhov: > > Hi Johan, > > > > On Wed, May 20, 2020 at 09:33:27AM +0200, Johan Jonker wrote: > > > A test with the command below gives this error: > > > > > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: > > > touchscreen@3e: reg:0:0: 56 was expected > > > > > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models > > > was shipped with different addresses then the binding currently allows. > > > Change the reg property that any address will pass. > > > > > > make ARCH=arm dtbs_check > > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ > > > edt-ft5x06.yaml > > > > > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > > > --- > > > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > index 383d64a91..baa8e8f7e 100644 > > > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > @@ -42,7 +42,7 @@ properties: > > > - focaltech,ft6236 > > > > > > reg: > > > - const: 0x38 > > > + maxItems: 1 > > > > Should we have a list of valid addresses instead of allowing any > > address? Controllers usually have only a couple of addresses that they > > support. > > from what I've read, the fdt touchscreen controllers are just a generic > cpu with device-specific (or better panel-specific) firmware, which seems > to include the address as well - so it looks to be variable. > > But of course that is only 2nd hand knowledge for me ;-) > > > But also, the i2c address is something you cannot really mess up, > either it is correct and your touchscreen works, or it isn't and and > adding entries to this list every time a new address variant pops up > feels clumsy. Is that an Ack? I'm fine either way. It's really only useful if there's a single address because with a list it could still be wrong just as any other data like an interrupt number could be wrong. Rob ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property @ 2020-05-28 22:01 ` Rob Herring 0 siblings, 0 replies; 16+ messages in thread From: Rob Herring @ 2020-05-28 22:01 UTC (permalink / raw) To: Heiko Stübner Cc: devicetree, Dmitry Torokhov, linux-kernel, linux-rockchip, linux-input, Johan Jonker, linux-arm-kernel On Wed, May 20, 2020 at 08:41:59PM +0200, Heiko Stübner wrote: > Hi Dmitry, > > Am Mittwoch, 20. Mai 2020, 19:13:24 CEST schrieb Dmitry Torokhov: > > Hi Johan, > > > > On Wed, May 20, 2020 at 09:33:27AM +0200, Johan Jonker wrote: > > > A test with the command below gives this error: > > > > > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: > > > touchscreen@3e: reg:0:0: 56 was expected > > > > > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models > > > was shipped with different addresses then the binding currently allows. > > > Change the reg property that any address will pass. > > > > > > make ARCH=arm dtbs_check > > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ > > > edt-ft5x06.yaml > > > > > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > > > --- > > > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > index 383d64a91..baa8e8f7e 100644 > > > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > @@ -42,7 +42,7 @@ properties: > > > - focaltech,ft6236 > > > > > > reg: > > > - const: 0x38 > > > + maxItems: 1 > > > > Should we have a list of valid addresses instead of allowing any > > address? Controllers usually have only a couple of addresses that they > > support. > > from what I've read, the fdt touchscreen controllers are just a generic > cpu with device-specific (or better panel-specific) firmware, which seems > to include the address as well - so it looks to be variable. > > But of course that is only 2nd hand knowledge for me ;-) > > > But also, the i2c address is something you cannot really mess up, > either it is correct and your touchscreen works, or it isn't and and > adding entries to this list every time a new address variant pops up > feels clumsy. Is that an Ack? I'm fine either way. It's really only useful if there's a single address because with a list it could still be wrong just as any other data like an interrupt number could be wrong. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property @ 2020-05-28 22:01 ` Rob Herring 0 siblings, 0 replies; 16+ messages in thread From: Rob Herring @ 2020-05-28 22:01 UTC (permalink / raw) To: Heiko Stübner Cc: devicetree, Dmitry Torokhov, linux-kernel, linux-rockchip, linux-input, Johan Jonker, linux-arm-kernel On Wed, May 20, 2020 at 08:41:59PM +0200, Heiko Stübner wrote: > Hi Dmitry, > > Am Mittwoch, 20. Mai 2020, 19:13:24 CEST schrieb Dmitry Torokhov: > > Hi Johan, > > > > On Wed, May 20, 2020 at 09:33:27AM +0200, Johan Jonker wrote: > > > A test with the command below gives this error: > > > > > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: > > > touchscreen@3e: reg:0:0: 56 was expected > > > > > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models > > > was shipped with different addresses then the binding currently allows. > > > Change the reg property that any address will pass. > > > > > > make ARCH=arm dtbs_check > > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ > > > edt-ft5x06.yaml > > > > > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > > > --- > > > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > index 383d64a91..baa8e8f7e 100644 > > > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > @@ -42,7 +42,7 @@ properties: > > > - focaltech,ft6236 > > > > > > reg: > > > - const: 0x38 > > > + maxItems: 1 > > > > Should we have a list of valid addresses instead of allowing any > > address? Controllers usually have only a couple of addresses that they > > support. > > from what I've read, the fdt touchscreen controllers are just a generic > cpu with device-specific (or better panel-specific) firmware, which seems > to include the address as well - so it looks to be variable. > > But of course that is only 2nd hand knowledge for me ;-) > > > But also, the i2c address is something you cannot really mess up, > either it is correct and your touchscreen works, or it isn't and and > adding entries to this list every time a new address variant pops up > feels clumsy. Is that an Ack? I'm fine either way. It's really only useful if there's a single address because with a list it could still be wrong just as any other data like an interrupt number could be wrong. Rob ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property 2020-05-28 22:01 ` Rob Herring (?) @ 2020-05-28 22:02 ` Heiko Stübner -1 siblings, 0 replies; 16+ messages in thread From: Heiko Stübner @ 2020-05-28 22:02 UTC (permalink / raw) To: Rob Herring Cc: Dmitry Torokhov, Johan Jonker, linux-input, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel Am Freitag, 29. Mai 2020, 00:01:36 CEST schrieb Rob Herring: > On Wed, May 20, 2020 at 08:41:59PM +0200, Heiko Stübner wrote: > > Hi Dmitry, > > > > Am Mittwoch, 20. Mai 2020, 19:13:24 CEST schrieb Dmitry Torokhov: > > > Hi Johan, > > > > > > On Wed, May 20, 2020 at 09:33:27AM +0200, Johan Jonker wrote: > > > > A test with the command below gives this error: > > > > > > > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: > > > > touchscreen@3e: reg:0:0: 56 was expected > > > > > > > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models > > > > was shipped with different addresses then the binding currently allows. > > > > Change the reg property that any address will pass. > > > > > > > > make ARCH=arm dtbs_check > > > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ > > > > edt-ft5x06.yaml > > > > > > > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > > > > --- > > > > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > > index 383d64a91..baa8e8f7e 100644 > > > > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > > @@ -42,7 +42,7 @@ properties: > > > > - focaltech,ft6236 > > > > > > > > reg: > > > > - const: 0x38 > > > > + maxItems: 1 > > > > > > Should we have a list of valid addresses instead of allowing any > > > address? Controllers usually have only a couple of addresses that they > > > support. > > > > from what I've read, the fdt touchscreen controllers are just a generic > > cpu with device-specific (or better panel-specific) firmware, which seems > > to include the address as well - so it looks to be variable. > > > > But of course that is only 2nd hand knowledge for me ;-) > > > > > > But also, the i2c address is something you cannot really mess up, > > either it is correct and your touchscreen works, or it isn't and and > > adding entries to this list every time a new address variant pops up > > feels clumsy. > > Is that an Ack? for the patch itself: Acked-by: Heiko Stuebner <heiko@sntech.de> > I'm fine either way. It's really only useful if there's a single > address because with a list it could still be wrong just as any other > data like an interrupt number could be wrong. > > Rob > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property @ 2020-05-28 22:02 ` Heiko Stübner 0 siblings, 0 replies; 16+ messages in thread From: Heiko Stübner @ 2020-05-28 22:02 UTC (permalink / raw) To: Rob Herring Cc: devicetree, Dmitry Torokhov, linux-kernel, linux-rockchip, linux-input, Johan Jonker, linux-arm-kernel Am Freitag, 29. Mai 2020, 00:01:36 CEST schrieb Rob Herring: > On Wed, May 20, 2020 at 08:41:59PM +0200, Heiko Stübner wrote: > > Hi Dmitry, > > > > Am Mittwoch, 20. Mai 2020, 19:13:24 CEST schrieb Dmitry Torokhov: > > > Hi Johan, > > > > > > On Wed, May 20, 2020 at 09:33:27AM +0200, Johan Jonker wrote: > > > > A test with the command below gives this error: > > > > > > > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: > > > > touchscreen@3e: reg:0:0: 56 was expected > > > > > > > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models > > > > was shipped with different addresses then the binding currently allows. > > > > Change the reg property that any address will pass. > > > > > > > > make ARCH=arm dtbs_check > > > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ > > > > edt-ft5x06.yaml > > > > > > > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > > > > --- > > > > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > > index 383d64a91..baa8e8f7e 100644 > > > > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > > @@ -42,7 +42,7 @@ properties: > > > > - focaltech,ft6236 > > > > > > > > reg: > > > > - const: 0x38 > > > > + maxItems: 1 > > > > > > Should we have a list of valid addresses instead of allowing any > > > address? Controllers usually have only a couple of addresses that they > > > support. > > > > from what I've read, the fdt touchscreen controllers are just a generic > > cpu with device-specific (or better panel-specific) firmware, which seems > > to include the address as well - so it looks to be variable. > > > > But of course that is only 2nd hand knowledge for me ;-) > > > > > > But also, the i2c address is something you cannot really mess up, > > either it is correct and your touchscreen works, or it isn't and and > > adding entries to this list every time a new address variant pops up > > feels clumsy. > > Is that an Ack? for the patch itself: Acked-by: Heiko Stuebner <heiko@sntech.de> > I'm fine either way. It's really only useful if there's a single > address because with a list it could still be wrong just as any other > data like an interrupt number could be wrong. > > Rob > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property @ 2020-05-28 22:02 ` Heiko Stübner 0 siblings, 0 replies; 16+ messages in thread From: Heiko Stübner @ 2020-05-28 22:02 UTC (permalink / raw) To: Rob Herring Cc: devicetree, Dmitry Torokhov, linux-kernel, linux-rockchip, linux-input, Johan Jonker, linux-arm-kernel Am Freitag, 29. Mai 2020, 00:01:36 CEST schrieb Rob Herring: > On Wed, May 20, 2020 at 08:41:59PM +0200, Heiko Stübner wrote: > > Hi Dmitry, > > > > Am Mittwoch, 20. Mai 2020, 19:13:24 CEST schrieb Dmitry Torokhov: > > > Hi Johan, > > > > > > On Wed, May 20, 2020 at 09:33:27AM +0200, Johan Jonker wrote: > > > > A test with the command below gives this error: > > > > > > > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: > > > > touchscreen@3e: reg:0:0: 56 was expected > > > > > > > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models > > > > was shipped with different addresses then the binding currently allows. > > > > Change the reg property that any address will pass. > > > > > > > > make ARCH=arm dtbs_check > > > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ > > > > edt-ft5x06.yaml > > > > > > > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > > > > --- > > > > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > > index 383d64a91..baa8e8f7e 100644 > > > > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > > > @@ -42,7 +42,7 @@ properties: > > > > - focaltech,ft6236 > > > > > > > > reg: > > > > - const: 0x38 > > > > + maxItems: 1 > > > > > > Should we have a list of valid addresses instead of allowing any > > > address? Controllers usually have only a couple of addresses that they > > > support. > > > > from what I've read, the fdt touchscreen controllers are just a generic > > cpu with device-specific (or better panel-specific) firmware, which seems > > to include the address as well - so it looks to be variable. > > > > But of course that is only 2nd hand knowledge for me ;-) > > > > > > But also, the i2c address is something you cannot really mess up, > > either it is correct and your touchscreen works, or it isn't and and > > adding entries to this list every time a new address variant pops up > > feels clumsy. > > Is that an Ack? for the patch itself: Acked-by: Heiko Stuebner <heiko@sntech.de> > I'm fine either way. It's really only useful if there's a single > address because with a list it could still be wrong just as any other > data like an interrupt number could be wrong. > > Rob > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property 2020-05-20 7:33 ` Johan Jonker @ 2020-05-29 17:07 ` Rob Herring -1 siblings, 0 replies; 16+ messages in thread From: Rob Herring @ 2020-05-29 17:07 UTC (permalink / raw) To: Johan Jonker Cc: linux-rockchip, devicetree, linux-arm-kernel, linux-kernel, heiko, linux-input, dmitry.torokhov, robh+dt On Wed, 20 May 2020 09:33:27 +0200, Johan Jonker wrote: > A test with the command below gives this error: > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: > touchscreen@3e: reg:0:0: 56 was expected > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models > was shipped with different addresses then the binding currently allows. > Change the reg property that any address will pass. > > make ARCH=arm dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ > edt-ft5x06.yaml > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks! ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property @ 2020-05-29 17:07 ` Rob Herring 0 siblings, 0 replies; 16+ messages in thread From: Rob Herring @ 2020-05-29 17:07 UTC (permalink / raw) To: Johan Jonker Cc: devicetree, heiko, dmitry.torokhov, linux-kernel, linux-rockchip, robh+dt, linux-input, linux-arm-kernel On Wed, 20 May 2020 09:33:27 +0200, Johan Jonker wrote: > A test with the command below gives this error: > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: > touchscreen@3e: reg:0:0: 56 was expected > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models > was shipped with different addresses then the binding currently allows. > Change the reg property that any address will pass. > > make ARCH=arm dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ > edt-ft5x06.yaml > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2020-05-29 17:07 UTC | newest] Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-05-20 7:33 [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property Johan Jonker 2020-05-20 7:33 ` Johan Jonker 2020-05-20 7:33 ` Johan Jonker 2020-05-20 17:13 ` Dmitry Torokhov 2020-05-20 17:13 ` Dmitry Torokhov 2020-05-20 18:41 ` Heiko Stübner 2020-05-20 18:41 ` Heiko Stübner 2020-05-20 18:41 ` Heiko Stübner 2020-05-28 22:01 ` Rob Herring 2020-05-28 22:01 ` Rob Herring 2020-05-28 22:01 ` Rob Herring 2020-05-28 22:02 ` Heiko Stübner 2020-05-28 22:02 ` Heiko Stübner 2020-05-28 22:02 ` Heiko Stübner 2020-05-29 17:07 ` Rob Herring 2020-05-29 17:07 ` Rob Herring
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.