Adding usb-ctrl from intel-bmc into phosphor-misc

Adding usb-ctrl from intel-bmc into phosphor-misc

[郁雷]

There is a script [usb-ctrl][1] hosted in intel-bmc.
It supports the VirtualMedia feature by insert/eject files to the host
as a USB mass-storage device.
Comparing to the existing [state_hook][2] in jsnbd, it supports
multiple UDCs, so it supports mount multiple files.

In addition, I have some updates on the usb-ctrl script to make it
support the USB ECM device, which creates a USB ethernet device
between BMC and the host.

So my proposal is to add the `usb-ctrl` script into the phosphor-misc
repo so that it gets reviewed and could be used by upstream.

Any ideas?

[1]: https://github.com/Intel-BMC/openbmc/blob/intel/meta-openbmc-mods/meta-common/recipes-core/fw-update/files/usb-ctrl
[2]: https://github.com/openbmc/openbmc/blob/master/meta-phosphor/aspeed-layer/recipes-connectivity/jsnbd/jsnbd/state_hook

-- 
BRs,
Lei YU

Re: Adding usb-ctrl from intel-bmc into phosphor-misc

[Brad Bishop]

On Wed, 2020-05-27 at 11:07 +0800, 郁雷 wrote:
> There is a script [usb-ctrl][1] hosted in intel-bmc.
> It supports the VirtualMedia feature by insert/eject files to the host
> as a USB mass-storage device.
> Comparing to the existing [state_hook][2] in jsnbd, it supports
> multiple UDCs, so it supports mount multiple files.
> 
> In addition, I have some updates on the usb-ctrl script to make it
> support the USB ECM device, which creates a USB ethernet device
> between BMC and the host.
> 
> So my proposal is to add the `usb-ctrl` script into the phosphor-misc
> repo so that it gets reviewed and could be used by upstream.
> 
> Any ideas?
> 
> [1]: 
> https://github.com/Intel-BMC/openbmc/blob/intel/meta-openbmc-mods/meta-common/recipes-core/fw-update/files/usb-ctrl
> [2]: 
> https://github.com/openbmc/openbmc/blob/master/meta-phosphor/aspeed-layer/recipes-connectivity/jsnbd/jsnbd/state_hook
> 

I'm the current maintainer of phosphor-misc and I am looking for help
with that.  I would be fine with adding this script to that repository. 
It would be nice, but not required, to hear from the Intel team that
they would pull from the new location if we do this...

Re: Adding usb-ctrl from intel-bmc into phosphor-misc

[James Feist]

On 5/28/2020 5:48 AM, Brad Bishop wrote:
> On Wed, 2020-05-27 at 11:07 +0800, 郁雷 wrote:
>> There is a script [usb-ctrl][1] hosted in intel-bmc.
>> It supports the VirtualMedia feature by insert/eject files to the host
>> as a USB mass-storage device.
>> Comparing to the existing [state_hook][2] in jsnbd, it supports
>> multiple UDCs, so it supports mount multiple files.
>>
>> In addition, I have some updates on the usb-ctrl script to make it
>> support the USB ECM device, which creates a USB ethernet device
>> between BMC and the host.
>>
>> So my proposal is to add the `usb-ctrl` script into the phosphor-misc
>> repo so that it gets reviewed and could be used by upstream.
>>
>> Any ideas?
>>
>> [1]:
>> https://github.com/Intel-BMC/openbmc/blob/intel/meta-openbmc-mods/meta-common/recipes-core/fw-update/files/usb-ctrl
>> [2]:
>> https://github.com/openbmc/openbmc/blob/master/meta-phosphor/aspeed-layer/recipes-connectivity/jsnbd/jsnbd/state_hook
>>
> 
> I'm the current maintainer of phosphor-misc and I am looking for help
> with that.  I would be fine with adding this script to that repository.
> It would be nice, but not required, to hear from the Intel team that
> they would pull from the new location if we do this...

Yes, we could start using it from there. Just would have to move the 
recipes to point to the right place. CCing Vernon who was the original 
author.

> 

Re: Adding usb-ctrl from intel-bmc into phosphor-misc

[Vernon Mauery]

On 29-May-2020 10:09 AM, James Feist wrote:
>On 5/28/2020 5:48 AM, Brad Bishop wrote:
>>On Wed, 2020-05-27 at 11:07 +0800, 郁雷 wrote:
>>>There is a script [usb-ctrl][1] hosted in intel-bmc.
>>>It supports the VirtualMedia feature by insert/eject files to the host
>>>as a USB mass-storage device.
>>>Comparing to the existing [state_hook][2] in jsnbd, it supports
>>>multiple UDCs, so it supports mount multiple files.
>>>
>>>In addition, I have some updates on the usb-ctrl script to make it
>>>support the USB ECM device, which creates a USB ethernet device
>>>between BMC and the host.
>>>
>>>So my proposal is to add the `usb-ctrl` script into the phosphor-misc
>>>repo so that it gets reviewed and could be used by upstream.
>>>
>>>Any ideas?
>>>
>>>[1]:
>>>https://github.com/Intel-BMC/openbmc/blob/intel/meta-openbmc-mods/meta-common/recipes-core/fw-update/files/usb-ctrl
>>>[2]:
>>>https://github.com/openbmc/openbmc/blob/master/meta-phosphor/aspeed-layer/recipes-connectivity/jsnbd/jsnbd/state_hook
>>>
>>
>>I'm the current maintainer of phosphor-misc and I am looking for help
>>with that.  I would be fine with adding this script to that repository.
>>It would be nice, but not required, to hear from the Intel team that
>>they would pull from the new location if we do this...
>
>Yes, we could start using it from there. Just would have to move the 
>recipes to point to the right place. CCing Vernon who was the original 
>author.

That old thing? :) Seems like a long time since I wrote that. I am fine 
with it moving to a new home. That being said, it might be better off as 
a c++ binary that is controlled from D-Bus than a shell script. It 
started off as a script because we just needed it NOW.

--Vernon

RE: Adding usb-ctrl from intel-bmc into phosphor-misc

[CS20 KWLiu]

Hi

RNDIS is a Microsoft standard, it is not only supported in Windows OS but also in other OS platforms.
So, this is an option we can provide as well.

I will check your patch to see how to merge rndis script.

Thanks.
-----Original Message-----
From: 郁雷 <yulei.sh@bytedance.com>
Sent: Thursday, May 28, 2020 5:34 PM
To: CS20 KWLiu <KWLIU@nuvoton.com>
Cc: Wang, Kuiying <kuiying.wang@intel.com>; openbmc@lists.ozlabs.org
Subject: RE: Adding usb-ctrl from intel-bmc into phosphor-misc

On Thu, May 28, 2020 at 5:02 PM CS20 KWLiu <KWLIU@nuvoton.com> wrote:
>
> Hi,
>
> For in-band usb network communication, I recommend that you can use rndis.
> There is a usb network recipe locates in quanta's layer, you can take it as reference.
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openbm
> c_openbmc_tree_master_meta-2Dquanta_meta-2Dcommon_network&d=DwIBaQ&c=u
> e8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPx
> PxfpLww1MiDbLW4v8Q&m=B-UYt0PbqENhhFwPReR07OF8di1nauIg7z0r3u2ZpqM&s=xxw
> O5BMx8cMwRXtNZ-ZGTPgCDrgIy5eXfhEMorF-FNY&e=
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openbm
> c_openbmc_blob_master_meta-2Dquanta_meta-2Dgsj_recipes-2Dkernel_linux_
> linux-2Dnuvoton_gsj.cfg-23L40&d=DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UF
> DmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=B-UYt0P
> bqENhhFwPReR07OF8di1nauIg7z0r3u2ZpqM&s=iOvDtZiIJKoEIQBa6UaKNhWbUQJhDH-
> tuSlnDnDP0dg&e=

Yup, it looks like both rndis and ecm work.
Could you kindly elaborate why you recommend rndis?

Btw, I see there are two different scripts in meta-quanta layer, one uses rndis and the other uses ecm:
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openbmc_openbmc_blob_master_meta-2Dquanta_meta-2Dgsj_recipes-2Dgsj_usb-2Dnetwork_files_usb-5Fnetwork.sh&d=DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=B-UYt0PbqENhhFwPReR07OF8di1nauIg7z0r3u2ZpqM&s=mDp-Bk9eSS8-xyRsSebF2Svn-omhZyA9eINaIrP7kd0&e=
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openbmc_openbmc_blob_master_meta-2Dquanta_meta-2Dcommon_network_usb-2Dnetwork_usb-2Dnetwork.sh&d=DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=B-UYt0PbqENhhFwPReR07OF8di1nauIg7z0r3u2ZpqM&s=J6AOmmmisgGa-TvoqfwTrtrx6M1cJGyoEPNbYnfMWMU&e=

Would you mind if you could merge the scripts into https://urldefense.proofpoint.com/v2/url?u=https-3A__gerrit.openbmc-2Dproject.xyz_c_openbmc_phosphor-2Dmisc_-2B_32878-3F&d=DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=B-UYt0PbqENhhFwPReR07OF8di1nauIg7z0r3u2ZpqM&s=z5xxtqsQN3WqZu4mkS98aTmGRZ1O-Y6spzjtLzcBUes&e=
________________________________
________________________________
 The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

RE: Adding usb-ctrl from intel-bmc into phosphor-misc

[郁雷]

On Thu, May 28, 2020 at 5:02 PM CS20 KWLiu <KWLIU@nuvoton.com> wrote:
>
> Hi,
>
> For in-band usb network communication, I recommend that you can use rndis.
> There is a usb network recipe locates in quanta's layer, you can take it as reference.
> https://github.com/openbmc/openbmc/tree/master/meta-quanta/meta-common/network
> https://github.com/openbmc/openbmc/blob/master/meta-quanta/meta-gsj/recipes-kernel/linux/linux-nuvoton/gsj.cfg#L40

Yup, it looks like both rndis and ecm work.
Could you kindly elaborate why you recommend rndis?

Btw, I see there are two different scripts in meta-quanta layer, one
uses rndis and the other uses ecm:
https://github.com/openbmc/openbmc/blob/master/meta-quanta/meta-gsj/recipes-gsj/usb-network/files/usb_network.sh
https://github.com/openbmc/openbmc/blob/master/meta-quanta/meta-common/network/usb-network/usb-network.sh

Would you mind if you could merge the scripts into
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-misc/+/32878?

RE: Adding usb-ctrl from intel-bmc into phosphor-misc

[Wang, Kuiying]

Ok, it is a working way, we could discuss more detail on your patch review.


Thanks,
Kwin.


-----Original Message-----
From: 郁雷 [mailto:yulei.sh@bytedance.com] 
Sent: Wednesday, May 27, 2020 5:35 PM
To: Wang, Kuiying <kuiying.wang@intel.com>
Cc: openbmc@lists.ozlabs.org
Subject: RE: Adding usb-ctrl from intel-bmc into phosphor-misc

On Wed, May 27, 2020 at 4:41 PM Wang, Kuiying <kuiying.wang@intel.com> wrote:
>
> Hi Lei,
>
> What’s your final purpose for this?
>

The USB ECM device is an ethernet between BMC and Host, so that they could have a real local ethernet between them.

On this internal ethernet, it is possible to do internal communication, e.g. host calls Redfish API to BMC without any outside-network.

--
BRs,
Lei YU

RE: Adding usb-ctrl from intel-bmc into phosphor-misc

[郁雷]

On Wed, May 27, 2020 at 4:41 PM Wang, Kuiying <kuiying.wang@intel.com> wrote:
>
> Hi Lei,
>
> What’s your final purpose for this?
>

The USB ECM device is an ethernet between BMC and Host, so that they
could have a real local ethernet between them.

On this internal ethernet, it is possible to do internal
communication, e.g. host calls Redfish API to BMC without any
outside-network.

-- 
BRs,
Lei YU

RE: Adding usb-ctrl from intel-bmc into phosphor-misc

[Wang, Kuiying]

[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]

Hi Lei,
What’s your final purpose for this?

Now we already have KCS between host and bmc.


Thanks,
Kwin.


郁雷 yulei.sh at bytedance.com<mailto:openbmc%40lists.ozlabs.org?Subject=Re%3A%20Adding%20usb-ctrl%20from%20intel-bmc%20into%20phosphor-misc&In-Reply-To=%3CCAGm54UEDRmEQVQ-WaRiUa%2BfpxL0UUe-OZ4rwRZHVLTUJBZZb%3DA%40mail.gmail.com%3E>
Wed May 27 13:07:45 AEST 2020

There is a script [usb-ctrl][1] hosted in intel-bmc.

It supports the VirtualMedia feature by insert/eject files to the host

as a USB mass-storage device.

Comparing to the existing [state_hook][2] in jsnbd, it supports

multiple UDCs, so it supports mount multiple files.



In addition, I have some updates on the usb-ctrl script to make it

support the USB ECM device, which creates a USB ethernet device

between BMC and the host.



So my proposal is to add the `usb-ctrl` script into the phosphor-misc

repo so that it gets reviewed and could be used by upstream.



Any ideas?



[1]: https://github.com/Intel-BMC/openbmc/blob/intel/meta-openbmc-mods/meta-common/recipes-core/fw-update/files/usb-ctrl

[2]: https://github.com/openbmc/openbmc/blob/master/meta-phosphor/aspeed-layer/recipes-connectivity/jsnbd/jsnbd/state_hook



--

BRs,

Lei YU


[-- Attachment #2: Type: text/html, Size: 5353 bytes --]