[mlankhorst:locking-rework 24/24] drivers/gpu/drm/i915/i915_vma.c:1014:2: note: in expansion of macro 'WARN_ON'

[mlankhorst:locking-rework 24/24] drivers/gpu/drm/i915/i915_vma.c:1014:2: note: in expansion of macro 'WARN_ON'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 3196 bytes --]

tree:   git://people.freedesktop.org/~mlankhorst/linux locking-rework
head:   e726cfba53476e81a890060586976e66c81484e1
commit: e726cfba53476e81a890060586976e66c81484e1 [24/24] drm/i915: Ensure we hold the pin mutex
config: x86_64-rhel (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
        git checkout e726cfba53476e81a890060586976e66c81484e1
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

In file included from arch/x86/include/asm/bug.h:83,
from include/linux/bug.h:5,
from arch/x86/include/asm/paravirt.h:15,
from arch/x86/include/asm/irqflags.h:72,
from include/linux/irqflags.h:16,
from include/linux/rcupdate.h:26,
from include/linux/rculist.h:11,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/sched/mm.h:7,
from drivers/gpu/drm/i915/i915_vma.c:25:
drivers/gpu/drm/i915/i915_vma.c: In function 'i915_ggtt_pin':
include/linux/dma-resv.h:80:28: error: implicit declaration of function 'lockdep_is_held'; did you mean 'lockdep_assert_held'? [-Werror=implicit-function-declaration]
80 | #define dma_resv_held(obj) lockdep_is_held(&(obj)->lock.base)
|                            ^~~~~~~~~~~~~~~
include/asm-generic/bug.h:122:25: note: in definition of macro 'WARN'
122 |  int __ret_warn_on = !!(condition);             |                         ^~~~~~~~~
>> drivers/gpu/drm/i915/i915_vma.c:1014:2: note: in expansion of macro 'WARN_ON'
1014 |  WARN_ON(!ww && vma->resv && dma_resv_held(vma->resv));
|  ^~~~~~~
>> drivers/gpu/drm/i915/i915_vma.c:1014:30: note: in expansion of macro 'dma_resv_held'
1014 |  WARN_ON(!ww && vma->resv && dma_resv_held(vma->resv));
|                              ^~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/WARN_ON +1014 drivers/gpu/drm/i915/i915_vma.c

  1005	
  1006	int i915_ggtt_pin(struct i915_vma *vma, struct i915_gem_ww_ctx *ww,
  1007			  u32 align, unsigned int flags)
  1008	{
  1009		struct i915_address_space *vm = vma->vm;
  1010		int err;
  1011	
  1012		GEM_BUG_ON(!i915_vma_is_ggtt(vma));
  1013	
> 1014		WARN_ON(!ww && vma->resv && dma_resv_held(vma->resv));
  1015	
  1016		do {
  1017			if (ww)
  1018				err = i915_vma_pin_ww(vma, ww, 0, align, flags | PIN_GLOBAL);
  1019			else
  1020				err = i915_vma_pin(vma, 0, align, flags | PIN_GLOBAL);
  1021			if (err != -ENOSPC) {
  1022				if (!err) {
  1023					err = i915_vma_wait_for_bind(vma);
  1024					if (err)
  1025						i915_vma_unpin(vma);
  1026				}
  1027				return err;
  1028			}
  1029	
  1030			/* Unlike i915_vma_pin, we don't take no for an answer! */
  1031			flush_idle_contexts(vm->gt);
  1032			if (mutex_lock_interruptible(&vm->mutex) == 0) {
  1033				i915_gem_evict_vm(vm);
  1034				mutex_unlock(&vm->mutex);
  1035			}
  1036		} while (1);
  1037	}
  1038	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 44824 bytes --]