[regulator:for-5.8 14/18] drivers/regulator/max8998.c:418:5: sparse: sparse: symbol 'max8998_get_current_limit' was not declared. Should it be static?

[regulator:for-5.8 14/18] drivers/regulator/max8998.c:418:5: sparse: sparse: symbol 'max8998_get_current_limit' was not declared. Should it be static?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.8
head:   81227f49bd272cbcd9bb4650b250519c8aa22065
commit: 4ffea5e083f8125fe273cf331ecb10d901eb64a2 [14/18] regulator: max8998: Add charger regulator
config: x86_64-randconfig-s021-20200529 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-243-gc100a7ab-dirty
        git checkout 4ffea5e083f8125fe273cf331ecb10d901eb64a2
        # save the attached .config to linux build tree
        make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

   drivers/regulator/max8998.c:374:5: sparse: sparse: symbol 'max8998_set_current_limit' was not declared. Should it be static?
>> drivers/regulator/max8998.c:418:5: sparse: sparse: symbol 'max8998_get_current_limit' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36703 bytes --]

[regulator:for-5.8 14/18] drivers/regulator/max8998.c:418:5: sparse: sparse: symbol 'max8998_get_current_limit' was not declared. Should it be static?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.8
head:   81227f49bd272cbcd9bb4650b250519c8aa22065
commit: 4ffea5e083f8125fe273cf331ecb10d901eb64a2 [14/18] regulator: max8998: Add charger regulator
config: x86_64-randconfig-s021-20200529 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-243-gc100a7ab-dirty
        git checkout 4ffea5e083f8125fe273cf331ecb10d901eb64a2
        # save the attached .config to linux build tree
        make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

   drivers/regulator/max8998.c:374:5: sparse: sparse: symbol 'max8998_set_current_limit' was not declared. Should it be static?
>> drivers/regulator/max8998.c:418:5: sparse: sparse: symbol 'max8998_get_current_limit' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36703 bytes --]

[RFC PATCH regulator] regulator: max8998: max8998_get_current_limit() can be static

[kbuild test robot]

Fixes: 4ffea5e083f8 ("regulator: max8998: Add charger regulator")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 max8998.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/max8998.c b/drivers/regulator/max8998.c
index 668ced0064179..ab16790a02068 100644
--- a/drivers/regulator/max8998.c
+++ b/drivers/regulator/max8998.c
@@ -415,7 +415,7 @@ int max8998_set_current_limit(struct regulator_dev *rdev,
 				  sel, rdev->desc->csel_mask);
 }
 
-int max8998_get_current_limit(struct regulator_dev *rdev)
+static int max8998_get_current_limit(struct regulator_dev *rdev)
 {
 	struct max8998_data *max8998 = rdev_get_drvdata(rdev);
 	struct i2c_client *i2c = max8998->iodev->i2c;

[RFC PATCH regulator] regulator: max8998: max8998_get_current_limit() can be static

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 740 bytes --]


Fixes: 4ffea5e083f8 ("regulator: max8998: Add charger regulator")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 max8998.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/max8998.c b/drivers/regulator/max8998.c
index 668ced0064179..ab16790a02068 100644
--- a/drivers/regulator/max8998.c
+++ b/drivers/regulator/max8998.c
@@ -415,7 +415,7 @@ int max8998_set_current_limit(struct regulator_dev *rdev,
 				  sel, rdev->desc->csel_mask);
 }
 
-int max8998_get_current_limit(struct regulator_dev *rdev)
+static int max8998_get_current_limit(struct regulator_dev *rdev)
 {
 	struct max8998_data *max8998 = rdev_get_drvdata(rdev);
 	struct i2c_client *i2c = max8998->iodev->i2c;