Re: [PATCH RFC] seccomp: Implement syscall isolation based on memory areas

Re: [PATCH RFC] seccomp: Implement syscall isolation based on memory areas

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1710 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20200530055953.817666-1-krisman@collabora.com>
References: <20200530055953.817666-1-krisman@collabora.com>
TO: Gabriel Krisman Bertazi <krisman@collabora.com>

Hi Gabriel,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on tip/x86/core]
[also build test WARNING on linus/master v5.7 next-20200529]
[cannot apply to asm-generic/master linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Gabriel-Krisman-Bertazi/seccomp-Implement-syscall-isolation-based-on-memory-areas/20200601-014401
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 9cb1fd0efd195590b828b9b865421ad345a4a145
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
config: arm-randconfig-c024-20200531 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


coccinelle warnings: (new ones prefixed by >>)

>> kernel/seccomp.c:939:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG.
   Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39404 bytes --]

[PATCH] seccomp: fix bugon.cocci warnings

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20200530055953.817666-1-krisman@collabora.com>
References: <20200530055953.817666-1-krisman@collabora.com>
TO: Gabriel Krisman Bertazi <krisman@collabora.com>

From: kbuild test robot <lkp@intel.com>

kernel/seccomp.c:939:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG.
Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)

 Use BUG_ON instead of a if condition followed by BUG.

Semantic patch information:
 This makes an effort to find cases where BUG() follows an if
 condition on an expression and replaces the if condition and BUG()
 with a BUG_ON having the conditional expression of the if statement
 as argument.

Generated by: scripts/coccinelle/misc/bugon.cocci

CC: Gabriel Krisman Bertazi <krisman@collabora.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
---

url:    https://github.com/0day-ci/linux/commits/Gabriel-Krisman-Bertazi/seccomp-Implement-syscall-isolation-based-on-memory-areas/20200601-014401
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 9cb1fd0efd195590b828b9b865421ad345a4a145
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago

Please take the patch only if it's a positive warning. Thanks!

 seccomp.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/kernel/seccomp.c
+++ b/kernel/seccomp.c
@@ -935,8 +935,7 @@ static int __seccomp_memmap(int this_sys
 {
 	struct vm_area_struct *vma = find_vma(current->mm,
 					      sd->instruction_pointer);
-	if (!vma)
-		BUG();
+	BUG_ON(!vma);
 
 	if (!(vma->vm_flags & VM_NOSYSCALL))
 		return 0;