All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Cc: davem@davemloft.net, kuba@kernel.org, roopa@cumulusnetworks.com,
	nikolay@cumulusnetworks.com, dlstevens@us.ibm.com,
	allas@mellanox.com, mlxsw@mellanox.com,
	Ido Schimmel <idosch@mellanox.com>
Subject: [PATCH net 0/2] Fix infinite loop in bridge and vxlan modules
Date: Mon,  1 Jun 2020 15:58:53 +0300	[thread overview]
Message-ID: <20200601125855.1751343-1-idosch@idosch.org> (raw)

From: Ido Schimmel <idosch@mellanox.com>

When suppressing invalid IPv6 Neighbour Solicitation messages, it is
possible for the bridge and vxlan modules to get stuck in an infinite
loop. See the individual changelogs for detailed explanation of the
problem and solution.

The bug was originally reported against the bridge module, but after
auditing the code base I found that the buggy code was copied from the
vxlan module. This patch set fixes both modules. Could not find more
instances of the problem.

Please consider both patches for stable releases.

Ido Schimmel (2):
  bridge: Avoid infinite loop when suppressing NS messages with invalid
    options
  vxlan: Avoid infinite loop when suppressing NS messages with invalid
    options

 drivers/net/vxlan.c          | 4 ++++
 net/bridge/br_arp_nd_proxy.c | 4 ++++
 2 files changed, 8 insertions(+)

-- 
2.26.2


WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@idosch.org>
To: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Cc: mlxsw@mellanox.com, nikolay@cumulusnetworks.com,
	roopa@cumulusnetworks.com, dlstevens@us.ibm.com,
	Ido Schimmel <idosch@mellanox.com>,
	allas@mellanox.com, kuba@kernel.org, davem@davemloft.net
Subject: [Bridge] [PATCH net 0/2] Fix infinite loop in bridge and vxlan modules
Date: Mon,  1 Jun 2020 15:58:53 +0300	[thread overview]
Message-ID: <20200601125855.1751343-1-idosch@idosch.org> (raw)

From: Ido Schimmel <idosch@mellanox.com>

When suppressing invalid IPv6 Neighbour Solicitation messages, it is
possible for the bridge and vxlan modules to get stuck in an infinite
loop. See the individual changelogs for detailed explanation of the
problem and solution.

The bug was originally reported against the bridge module, but after
auditing the code base I found that the buggy code was copied from the
vxlan module. This patch set fixes both modules. Could not find more
instances of the problem.

Please consider both patches for stable releases.

Ido Schimmel (2):
  bridge: Avoid infinite loop when suppressing NS messages with invalid
    options
  vxlan: Avoid infinite loop when suppressing NS messages with invalid
    options

 drivers/net/vxlan.c          | 4 ++++
 net/bridge/br_arp_nd_proxy.c | 4 ++++
 2 files changed, 8 insertions(+)

-- 
2.26.2


             reply	other threads:[~2020-06-01 12:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01 12:58 Ido Schimmel [this message]
2020-06-01 12:58 ` [Bridge] [PATCH net 0/2] Fix infinite loop in bridge and vxlan modules Ido Schimmel
2020-06-01 12:58 ` [PATCH net 1/2] bridge: Avoid infinite loop when suppressing NS messages with invalid options Ido Schimmel
2020-06-01 12:58   ` [Bridge] " Ido Schimmel
2020-06-01 13:02   ` Nikolay Aleksandrov
2020-06-01 13:02     ` [Bridge] " Nikolay Aleksandrov
2020-06-01 12:58 ` [PATCH net 2/2] vxlan: " Ido Schimmel
2020-06-01 12:58   ` [Bridge] " Ido Schimmel
2020-06-01 13:02   ` Nikolay Aleksandrov
2020-06-01 13:02     ` [Bridge] " Nikolay Aleksandrov
2020-06-01 18:09 ` [PATCH net 0/2] Fix infinite loop in bridge and vxlan modules David Miller
2020-06-01 18:09   ` [Bridge] " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200601125855.1751343-1-idosch@idosch.org \
    --to=idosch@idosch.org \
    --cc=allas@mellanox.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=dlstevens@us.ibm.com \
    --cc=idosch@mellanox.com \
    --cc=kuba@kernel.org \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.