From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alex Elder <elder@kernel.org>, Johan Hovold <johan@kernel.org>,
Mark Greer <mgreer@animalcreek.com>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
devel@driverdev.osuosl.org, alsa-devel@alsa-project.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org
Subject: Re: [RESEND PATCH v1 4/6] staging: greybus: audio: Resolve compilation error in topology parser
Date: Tue, 2 Jun 2020 15:39:30 +0300 [thread overview]
Message-ID: <20200602123930.GG30374@kadam> (raw)
In-Reply-To: <6131fec4cf9e18dbf70fa7f992de9d588299ee18.1591040859.git.vaibhav.sr@gmail.com>
On Tue, Jun 02, 2020 at 10:51:13AM +0530, Vaibhav Agarwal wrote:
> Fix compilation errors for GB Audio topology parser code with recent
> kernel versions.
>
> Signed-off-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
> ---
> drivers/staging/greybus/audio_topology.c | 130 +++++++++++------------
> 1 file changed, 61 insertions(+), 69 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c
> index 4ac30accf226..7d5e87341a5c 100644
> --- a/drivers/staging/greybus/audio_topology.c
> +++ b/drivers/staging/greybus/audio_topology.c
> @@ -5,8 +5,8 @@
> * Copyright 2015-2016 Linaro Ltd.
> */
>
> +#include <linux/greybus.h>
> #include "audio_codec.h"
> -#include "greybus_protocols.h"
>
> #define GBAUDIO_INVALID_ID 0xFF
>
> @@ -165,15 +165,15 @@ static int gbcodec_mixer_ctl_info(struct snd_kcontrol *kcontrol,
> struct gbaudio_ctl_pvt *data;
> struct gb_audio_ctl_elem_info *info;
> struct gbaudio_module_info *module;
> - struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
> - struct gbaudio_codec_info *gbcodec = snd_soc_codec_get_drvdata(codec);
> + struct snd_soc_component *comp = snd_soc_kcontrol_component(kcontrol);
> + struct gbaudio_codec_info *gb = snd_soc_component_get_drvdata(comp);
Please rename "gbcodec" in a different patch. It's not related to
fixing the compile.
Otherwise it seems okay.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Cc: devel@driverdev.osuosl.org, alsa-devel@alsa-project.org,
Alex Elder <elder@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Greer <mgreer@animalcreek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
greybus-dev@lists.linaro.org, Mark Brown <broonie@kernel.org>,
Johan Hovold <johan@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v1 4/6] staging: greybus: audio: Resolve compilation error in topology parser
Date: Tue, 2 Jun 2020 15:39:30 +0300 [thread overview]
Message-ID: <20200602123930.GG30374@kadam> (raw)
In-Reply-To: <6131fec4cf9e18dbf70fa7f992de9d588299ee18.1591040859.git.vaibhav.sr@gmail.com>
On Tue, Jun 02, 2020 at 10:51:13AM +0530, Vaibhav Agarwal wrote:
> Fix compilation errors for GB Audio topology parser code with recent
> kernel versions.
>
> Signed-off-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
> ---
> drivers/staging/greybus/audio_topology.c | 130 +++++++++++------------
> 1 file changed, 61 insertions(+), 69 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c
> index 4ac30accf226..7d5e87341a5c 100644
> --- a/drivers/staging/greybus/audio_topology.c
> +++ b/drivers/staging/greybus/audio_topology.c
> @@ -5,8 +5,8 @@
> * Copyright 2015-2016 Linaro Ltd.
> */
>
> +#include <linux/greybus.h>
> #include "audio_codec.h"
> -#include "greybus_protocols.h"
>
> #define GBAUDIO_INVALID_ID 0xFF
>
> @@ -165,15 +165,15 @@ static int gbcodec_mixer_ctl_info(struct snd_kcontrol *kcontrol,
> struct gbaudio_ctl_pvt *data;
> struct gb_audio_ctl_elem_info *info;
> struct gbaudio_module_info *module;
> - struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
> - struct gbaudio_codec_info *gbcodec = snd_soc_codec_get_drvdata(codec);
> + struct snd_soc_component *comp = snd_soc_kcontrol_component(kcontrol);
> + struct gbaudio_codec_info *gb = snd_soc_component_get_drvdata(comp);
Please rename "gbcodec" in a different patch. It's not related to
fixing the compile.
Otherwise it seems okay.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Cc: devel@driverdev.osuosl.org, alsa-devel@alsa-project.org,
Alex Elder <elder@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Greer <mgreer@animalcreek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Takashi Iwai <tiwai@suse.com>,
greybus-dev@lists.linaro.org, Mark Brown <broonie@kernel.org>,
Johan Hovold <johan@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v1 4/6] staging: greybus: audio: Resolve compilation error in topology parser
Date: Tue, 2 Jun 2020 15:39:30 +0300 [thread overview]
Message-ID: <20200602123930.GG30374@kadam> (raw)
In-Reply-To: <6131fec4cf9e18dbf70fa7f992de9d588299ee18.1591040859.git.vaibhav.sr@gmail.com>
On Tue, Jun 02, 2020 at 10:51:13AM +0530, Vaibhav Agarwal wrote:
> Fix compilation errors for GB Audio topology parser code with recent
> kernel versions.
>
> Signed-off-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
> ---
> drivers/staging/greybus/audio_topology.c | 130 +++++++++++------------
> 1 file changed, 61 insertions(+), 69 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c
> index 4ac30accf226..7d5e87341a5c 100644
> --- a/drivers/staging/greybus/audio_topology.c
> +++ b/drivers/staging/greybus/audio_topology.c
> @@ -5,8 +5,8 @@
> * Copyright 2015-2016 Linaro Ltd.
> */
>
> +#include <linux/greybus.h>
> #include "audio_codec.h"
> -#include "greybus_protocols.h"
>
> #define GBAUDIO_INVALID_ID 0xFF
>
> @@ -165,15 +165,15 @@ static int gbcodec_mixer_ctl_info(struct snd_kcontrol *kcontrol,
> struct gbaudio_ctl_pvt *data;
> struct gb_audio_ctl_elem_info *info;
> struct gbaudio_module_info *module;
> - struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
> - struct gbaudio_codec_info *gbcodec = snd_soc_codec_get_drvdata(codec);
> + struct snd_soc_component *comp = snd_soc_kcontrol_component(kcontrol);
> + struct gbaudio_codec_info *gb = snd_soc_component_get_drvdata(comp);
Please rename "gbcodec" in a different patch. It's not related to
fixing the compile.
Otherwise it seems okay.
regards,
dan carpenter
next prev parent reply other threads:[~2020-06-02 12:40 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 5:21 [RESEND PATCH v1 0/6] Enable Greybus Audio codec driver Vaibhav Agarwal
2020-06-02 5:21 ` Vaibhav Agarwal
2020-06-02 5:21 ` Vaibhav Agarwal
2020-06-02 5:21 ` [RESEND PATCH v1 1/6] staging: greybus: audio: Update snd_jack FW usage as per new APIs Vaibhav Agarwal
2020-06-02 5:21 ` Vaibhav Agarwal
2020-06-02 5:21 ` Vaibhav Agarwal
2020-06-02 11:56 ` Dan Carpenter
2020-06-02 11:56 ` Dan Carpenter
2020-06-02 11:56 ` Dan Carpenter
2020-06-02 5:21 ` [RESEND PATCH v1 2/6] staging: greybus: audio: Maintain jack list within GB Audio module Vaibhav Agarwal
2020-06-02 5:21 ` Vaibhav Agarwal
2020-06-02 5:21 ` Vaibhav Agarwal
2020-06-02 12:14 ` Dan Carpenter
2020-06-02 12:14 ` Dan Carpenter
2020-06-02 12:14 ` Dan Carpenter
2020-06-02 5:21 ` [RESEND PATCH v1 3/6] staging: greybus: audio: Resolve compilation errors for GB codec module Vaibhav Agarwal
2020-06-02 5:21 ` Vaibhav Agarwal
2020-06-02 5:21 ` Vaibhav Agarwal
2020-06-02 12:29 ` Dan Carpenter
2020-06-02 12:29 ` Dan Carpenter
2020-06-02 12:29 ` Dan Carpenter
2020-06-02 5:21 ` [RESEND PATCH v1 4/6] staging: greybus: audio: Resolve compilation error in topology parser Vaibhav Agarwal
2020-06-02 5:21 ` Vaibhav Agarwal
2020-06-02 5:21 ` Vaibhav Agarwal
2020-06-02 12:39 ` Dan Carpenter [this message]
2020-06-02 12:39 ` Dan Carpenter
2020-06-02 12:39 ` Dan Carpenter
2020-06-02 5:21 ` [RESEND PATCH v1 5/6] staging: greybus: audio: Add helper APIs for dynamic audio modules Vaibhav Agarwal
2020-06-02 5:21 ` Vaibhav Agarwal
2020-06-02 5:21 ` Vaibhav Agarwal
2020-06-02 12:44 ` Dan Carpenter
2020-06-02 12:44 ` Dan Carpenter
2020-06-02 12:44 ` Dan Carpenter
2020-06-02 5:21 ` [RESEND PATCH v1 6/6] staging: greybus: audio: Enable GB codec, audio module compilation Vaibhav Agarwal
2020-06-02 5:21 ` Vaibhav Agarwal
2020-06-02 5:21 ` Vaibhav Agarwal
2020-06-02 12:57 ` Dan Carpenter
2020-06-02 12:57 ` Dan Carpenter
2020-06-02 12:57 ` Dan Carpenter
2020-06-03 17:42 ` Vaibhav Agarwal
2020-06-03 17:42 ` Vaibhav Agarwal
2020-06-03 17:42 ` Vaibhav Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602123930.GG30374@kadam \
--to=dan.carpenter@oracle.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.