Re: [PATCH nvme] nvme: Revert "nvme: Discard workaround for non-conformant devices"

From: Dakshaja Uppalapati <dakshaja@chelsio.com>
To: Christoph Hellwig <hch@lst.de>
Cc: eduard@hasenleithner.at, kbusch@kernel.org, sagi@grimberg.me,
	hch@lst.de, gregkh@linuxfoundation.org, nirranjan@chelsio.com,
	bharat@chelsio.com, stable@vger.kernel.org
Subject: Re: [PATCH nvme] nvme: Revert "nvme: Discard workaround for non-conformant devices"
Date: Wed, 3 Jun 2020 21:47:18 +0530	[thread overview]
Message-ID: <20200603161717.GA11442@chelsio.com> (raw)
In-Reply-To: <20200603130750.GA13511@lst.de>

On Wednesday, June 06/03/20, 2020 at 15:07:50 +0200, Christoph Hellwig wrote:
> On Wed, Jun 03, 2020 at 02:48:51PM +0530, Dakshaja Uppalapati wrote:
> > This reverts upstream 'commit 530436c45ef2
> > ("nvme: Discard workaround for non-conformant devices")'
> > 
> > Since commit `530436c45ef2` introduced a regression due to which
> > blk_update_request IO error is observed on formatting device, reverting it.
> 
> Err, why?  Please send an actual bug report with details of your
> setup.

Hi Christoph,

Here is the link describing the issue initially reported for upstream 
kernel 5.5:

https://lore.kernel.org/linux-nvme/CH2PR12MB40053A64681EFA3E6F63FDFBDD2A0@CH2PR12MB4005.namprd12.prod.outlook.com/

Issue is later fixed with upstream commit b716e688.

Now the same issue is observed with stable kernels 4.19 and 5.4 as 
commit 530436c4 was pulled in to stable. Here is the link describing the same 
for stable kernels.

https://www.spinics.net/lists/stable/msg387744.html

Please let me know if you need any further info.

Thanks,
Dakshaja