All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dakshaja Uppalapati <dakshaja@chelsio.com>
To: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>
Cc: eduard@hasenleithner.at, kbusch@kernel.org,
	gregkh@linuxfoundation.org,
	Nirranjan Kirubaharan <nirranjan@chelsio.com>,
	Potnuri Bharat Teja <bharat@chelsio.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH nvme] nvme: Revert "nvme: Discard workaround for non-conformant devices"
Date: Thu, 4 Jun 2020 12:06:39 +0530	[thread overview]
Message-ID: <20200604063638.GA15118@chelsio.com> (raw)
In-Reply-To: <6b58318c-fc41-66b9-b4d2-868d832392bb@grimberg.me>

On Wednesday, June 06/03/20, 2020 at 14:20:01 -0700, Sagi Grimberg wrote:
> 
> > > > Err, why?  Please send an actual bug report with details of your
> > > > setup.
> > > 
> > > Hi Christoph,
> > > 
> > > Here is the link describing the issue initially reported for upstream
> > > kernel 5.5:
> > > 
> > > https://lore.kernel.org/linux-nvme/CH2PR12MB40053A64681EFA3E6F63FDFBDD2A0@CH2PR12MB4005.namprd12.prod.outlook.com/
> > > 
> > > Issue is later fixed with upstream commit b716e688.
> > 
> > We are talking about two different things here.  One is the Linux NVMe
> > host code that can be used with lots of different controllers.  Many of
> > them are PCIe controller, especially cheap ones.
> > 
> > The other is the Linux NVMe target code.  So if a fix for very common
> > PCIe controller trigger a bug in the target code there is no 1:1
> > relationship as even if you are talking to a Linux fabrics controller
> > it usually runs a different kernel version on a different system.
> > 
> > That being said you can always backport that fix as well, which probably
> > is a good idea as it fixes a real bug.
> > 
> > Nevermind that nothing in your revert patch indicated it wasn't for
> > mainline.
> 
> Agree..

Just to confirm that I got it right, Do you want me to send all 6 patches 
(fix and dependent patches) to stable?

  reply	other threads:[~2020-06-04  6:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03  9:18 [PATCH nvme] nvme: Revert "nvme: Discard workaround for non-conformant devices" Dakshaja Uppalapati
2020-06-03 13:07 ` Christoph Hellwig
2020-06-03 16:17   ` Dakshaja Uppalapati
2020-06-03 16:23     ` Christoph Hellwig
2020-06-03 21:20       ` Sagi Grimberg
2020-06-04  6:36         ` Dakshaja Uppalapati [this message]
2020-09-04 11:34           ` Greg KH
2020-06-05 13:43 ` Greg KH
2020-06-08  6:35   ` Dakshaja Uppalapati
2020-06-08 15:05     ` Keith Busch
2020-06-11 16:08       ` Dakshaja Uppalapati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200604063638.GA15118@chelsio.com \
    --to=dakshaja@chelsio.com \
    --cc=bharat@chelsio.com \
    --cc=eduard@hasenleithner.at \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=nirranjan@chelsio.com \
    --cc=sagi@grimberg.me \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.