* [PATCH] ARM: add psci_arch_init() declaration for CONFIG_ARMV7_PSCI
@ 2020-05-20 2:43 Masahiro Yamada
2020-05-20 3:07 ` Simon Glass
2020-06-03 16:25 ` Tom Rini
0 siblings, 2 replies; 4+ messages in thread
From: Masahiro Yamada @ 2020-05-20 2:43 UTC (permalink / raw)
To: u-boot
arch/arm/include/asm/system.h declares psci_arch_init(), but it is
surrounded by #ifdef CONFIG_ARMV8_PSCI.
psci_arch_init() is called for CONFIG_ARMV7_PSCI too. Add the missing
function declaration.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm/include/asm/system.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/include/asm/system.h b/arch/arm/include/asm/system.h
index 1e3f574403..7a40b56acd 100644
--- a/arch/arm/include/asm/system.h
+++ b/arch/arm/include/asm/system.h
@@ -528,6 +528,7 @@ void mmu_page_table_flush(unsigned long start, unsigned long stop);
#ifdef CONFIG_ARMV7_PSCI
void psci_arch_cpu_entry(void);
+void psci_arch_init(void);
u32 psci_version(void);
s32 psci_features(u32 function_id, u32 psci_fid);
s32 psci_cpu_off(void);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: add psci_arch_init() declaration for CONFIG_ARMV7_PSCI
2020-05-20 2:43 [PATCH] ARM: add psci_arch_init() declaration for CONFIG_ARMV7_PSCI Masahiro Yamada
@ 2020-05-20 3:07 ` Simon Glass
2020-05-20 3:37 ` Masahiro Yamada
2020-06-03 16:25 ` Tom Rini
1 sibling, 1 reply; 4+ messages in thread
From: Simon Glass @ 2020-05-20 3:07 UTC (permalink / raw)
To: u-boot
HI Masahiro,
On Tue, 19 May 2020 at 20:44, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> arch/arm/include/asm/system.h declares psci_arch_init(), but it is
> surrounded by #ifdef CONFIG_ARMV8_PSCI.
>
> psci_arch_init() is called for CONFIG_ARMV7_PSCI too. Add the missing
> function declaration.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/arm/include/asm/system.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/include/asm/system.h b/arch/arm/include/asm/system.h
> index 1e3f574403..7a40b56acd 100644
> --- a/arch/arm/include/asm/system.h
> +++ b/arch/arm/include/asm/system.h
> @@ -528,6 +528,7 @@ void mmu_page_table_flush(unsigned long start, unsigned long stop);
>
> #ifdef CONFIG_ARMV7_PSCI
> void psci_arch_cpu_entry(void);
> +void psci_arch_init(void);
Could you add a function comment too?
> u32 psci_version(void);
> s32 psci_features(u32 function_id, u32 psci_fid);
> s32 psci_cpu_off(void);
> --
> 2.25.1
>
Regards,
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: add psci_arch_init() declaration for CONFIG_ARMV7_PSCI
2020-05-20 3:07 ` Simon Glass
@ 2020-05-20 3:37 ` Masahiro Yamada
0 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2020-05-20 3:37 UTC (permalink / raw)
To: u-boot
On Wed, May 20, 2020 at 12:09 PM Simon Glass <sjg@chromium.org> wrote:
>
> HI Masahiro,
>
> On Tue, 19 May 2020 at 20:44, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> >
> > arch/arm/include/asm/system.h declares psci_arch_init(), but it is
> > surrounded by #ifdef CONFIG_ARMV8_PSCI.
> >
> > psci_arch_init() is called for CONFIG_ARMV7_PSCI too. Add the missing
> > function declaration.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> > arch/arm/include/asm/system.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/include/asm/system.h b/arch/arm/include/asm/system.h
> > index 1e3f574403..7a40b56acd 100644
> > --- a/arch/arm/include/asm/system.h
> > +++ b/arch/arm/include/asm/system.h
> > @@ -528,6 +528,7 @@ void mmu_page_table_flush(unsigned long start, unsigned long stop);
> >
> > #ifdef CONFIG_ARMV7_PSCI
> > void psci_arch_cpu_entry(void);
> > +void psci_arch_init(void);
>
> Could you add a function comment too?
Sorry, I can't.
It was a long time ago that I worked on the psci implementation
for my board, so I forgot what psci_arch_init() was actually intended.
I was only interested in fixing
-Wmissing-prototypes warning here.
None of the remaining functions are documented,
so "please also do this while you are here" is not
a reasonable request, I think.
If people are happy with not fixing the warning,
please feel free to ignore this patch.
> > u32 psci_version(void);
> > s32 psci_features(u32 function_id, u32 psci_fid);
> > s32 psci_cpu_off(void);
> > --
> > 2.25.1
> >
>
> Regards,
> Simon
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: add psci_arch_init() declaration for CONFIG_ARMV7_PSCI
2020-05-20 2:43 [PATCH] ARM: add psci_arch_init() declaration for CONFIG_ARMV7_PSCI Masahiro Yamada
2020-05-20 3:07 ` Simon Glass
@ 2020-06-03 16:25 ` Tom Rini
1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2020-06-03 16:25 UTC (permalink / raw)
To: u-boot
On Wed, May 20, 2020 at 11:43:34AM +0900, Masahiro Yamada wrote:
> arch/arm/include/asm/system.h declares psci_arch_init(), but it is
> surrounded by #ifdef CONFIG_ARMV8_PSCI.
>
> psci_arch_init() is called for CONFIG_ARMV7_PSCI too. Add the missing
> function declaration.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200603/2b6c9831/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-03 16:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 2:43 [PATCH] ARM: add psci_arch_init() declaration for CONFIG_ARMV7_PSCI Masahiro Yamada
2020-05-20 3:07 ` Simon Glass
2020-05-20 3:37 ` Masahiro Yamada
2020-06-03 16:25 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.