From: Mark Brown <broonie@kernel.org> To: Lukas Wunner <lukas@wunner.de> Cc: Florian Fainelli <f.fainelli@gmail.com>, linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Nicolas Saenz Julienne <nsaenzjulienne@suse.de>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." <bcm-kernel-feedback-list@broadcom.com>, "open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-rpi-kernel@lists.infradead.org>, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, Martin Sperl <kernel@martin.sperl.org> Subject: Re: [PATCH 2/3] ARM: dts: bcm2711: Update SPI nodes compatible strings Date: Thu, 4 Jun 2020 12:13:25 +0100 [thread overview] Message-ID: <20200604111325.GC6644@sirena.org.uk> (raw) In-Reply-To: <20200604042038.jzolu6k7q3d6bsvq@wunner.de> [-- Attachment #1: Type: text/plain, Size: 883 bytes --] On Thu, Jun 04, 2020 at 06:20:38AM +0200, Lukas Wunner wrote: > On Wed, Jun 03, 2020 at 08:46:54PM -0700, Florian Fainelli wrote: > > The BCM2711 SoC features 5 SPI controllers which all share the same > > interrupt line, the SPI driver needs to support interrupt sharing, > > therefore use the chip specific compatible string to help with that. > You're saying above that the 5 controllers all share the interrupt > but below you're only changing the compatible string of 4 controllers. > So I assume spi0 still has its own interrupt and only the additional > 4 controllers present on the BCM2711/BCM7211 share their interrupt? Regardless of what's going on with the interrupts the compatible string should reflect the IP version so unless for some reason someone taped out two different versions of the IP it seems odd that the compatible strings would vary within a given SoC. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Lukas Wunner <lukas@wunner.de> Cc: "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Florian Fainelli <f.fainelli@gmail.com>, Scott Branden <sbranden@broadcom.com>, Ray Jui <rjui@broadcom.com>, linux-kernel@vger.kernel.org, "open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." <bcm-kernel-feedback-list@broadcom.com>, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-rpi-kernel@lists.infradead.org>, Martin Sperl <kernel@martin.sperl.org>, Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Subject: Re: [PATCH 2/3] ARM: dts: bcm2711: Update SPI nodes compatible strings Date: Thu, 4 Jun 2020 12:13:25 +0100 [thread overview] Message-ID: <20200604111325.GC6644@sirena.org.uk> (raw) In-Reply-To: <20200604042038.jzolu6k7q3d6bsvq@wunner.de> [-- Attachment #1.1: Type: text/plain, Size: 883 bytes --] On Thu, Jun 04, 2020 at 06:20:38AM +0200, Lukas Wunner wrote: > On Wed, Jun 03, 2020 at 08:46:54PM -0700, Florian Fainelli wrote: > > The BCM2711 SoC features 5 SPI controllers which all share the same > > interrupt line, the SPI driver needs to support interrupt sharing, > > therefore use the chip specific compatible string to help with that. > You're saying above that the 5 controllers all share the interrupt > but below you're only changing the compatible string of 4 controllers. > So I assume spi0 still has its own interrupt and only the additional > 4 controllers present on the BCM2711/BCM7211 share their interrupt? Regardless of what's going on with the interrupts the compatible string should reflect the IP version so unless for some reason someone taped out two different versions of the IP it seems odd that the compatible strings would vary within a given SoC. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-04 11:13 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-04 3:46 [PATCH 0/3] spi: bcm2835: Enable shared interrupt support Florian Fainelli 2020-06-04 3:46 ` Florian Fainelli 2020-06-04 3:46 ` [PATCH 1/3] dt-bindings: spi: Document bcm2711 and bcm7211 SPI compatible Florian Fainelli 2020-06-04 3:46 ` Florian Fainelli 2020-06-04 4:23 ` Lukas Wunner 2020-06-04 3:46 ` [PATCH 2/3] ARM: dts: bcm2711: Update SPI nodes compatible strings Florian Fainelli 2020-06-04 3:46 ` Florian Fainelli 2020-06-04 4:20 ` Lukas Wunner 2020-06-04 11:13 ` Mark Brown [this message] 2020-06-04 11:13 ` Mark Brown 2020-06-04 11:21 ` Lukas Wunner 2020-06-04 14:05 ` Mark Brown 2020-06-04 14:05 ` Mark Brown 2020-06-04 16:40 ` Florian Fainelli 2020-06-04 16:40 ` Florian Fainelli 2020-06-04 16:54 ` Stefan Wahren 2020-06-04 16:54 ` Stefan Wahren 2020-06-04 16:56 ` Florian Fainelli 2020-06-04 16:56 ` Florian Fainelli 2020-06-04 16:46 ` Stefan Wahren 2020-06-04 16:46 ` Stefan Wahren 2020-06-04 3:46 ` [PATCH 3/3] spi: bcm2835: Enable shared interrupt support Florian Fainelli 2020-06-04 3:46 ` Florian Fainelli 2020-06-04 4:17 ` Lukas Wunner 2020-06-15 17:25 ` Rob Herring 2020-06-15 17:25 ` Rob Herring 2020-06-04 12:32 ` Mark Brown 2020-06-04 12:32 ` Mark Brown 2020-06-04 16:05 ` Florian Fainelli 2020-06-04 16:05 ` Florian Fainelli 2020-06-04 20:24 ` Florian Fainelli 2020-06-04 20:24 ` Florian Fainelli 2020-06-05 11:35 ` Lukas Wunner 2020-06-05 10:28 ` Mark Brown 2020-06-05 10:28 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200604111325.GC6644@sirena.org.uk \ --to=broonie@kernel.org \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=kernel@martin.sperl.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=lukas@wunner.de \ --cc=nsaenzjulienne@suse.de \ --cc=rjui@broadcom.com \ --cc=robh+dt@kernel.org \ --cc=sbranden@broadcom.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.