From: Pavel Machek <pavel@ucw.cz>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: jacek.anaszewski@gmail.com, matthias.bgg@gmail.com,
dmurphy@ti.com, linux-leds@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
gene_chen@richtek.com, Wilma.Wu@mediatek.com,
shufan_lee@richtek.com, cy_huang@richtek.com,
benjamin.chao@mediatek.com
Subject: Re: [PATCH] leds: mt6360: Add LED driver for MT6360
Date: Thu, 4 Jun 2020 15:52:12 +0200 [thread overview]
Message-ID: <20200604135212.GI7222@duo.ucw.cz> (raw)
In-Reply-To: <1591252004-12681-1-git-send-email-gene.chen.richtek@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]
Hi!
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index c664d84..c47be91 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -229,6 +229,17 @@ config LEDS_MT6323
> This option enables support for on-chip LED drivers found on
> Mediatek MT6323 PMIC.
>
> +config LEDS_MT6360
> + tristate "LED Support for Mediatek MT6360 PMIC"
> + depends on LEDS_CLASS_FLASH && OF
> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
> + depends on MFD_MT6360
> + help
> + This option enables support for dual Flash LED drivers found on
> + Mediatek MT6360 PMIC.
> + Support Torch and Strobe mode independently current source.
> + Include Low-VF and short protection.
This should be in english... and should not contain
"advertising". Just delete last two lines.
More useful information would be listing hardware where this is often
found.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: gene_chen@richtek.com, linux-kernel@vger.kernel.org,
cy_huang@richtek.com, benjamin.chao@mediatek.com,
linux-mediatek@lists.infradead.org, jacek.anaszewski@gmail.com,
linux-leds@vger.kernel.org, matthias.bgg@gmail.com,
shufan_lee@richtek.com, Wilma.Wu@mediatek.com,
linux-arm-kernel@lists.infradead.org, dmurphy@ti.com
Subject: Re: [PATCH] leds: mt6360: Add LED driver for MT6360
Date: Thu, 4 Jun 2020 15:52:12 +0200 [thread overview]
Message-ID: <20200604135212.GI7222@duo.ucw.cz> (raw)
In-Reply-To: <1591252004-12681-1-git-send-email-gene.chen.richtek@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1081 bytes --]
Hi!
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index c664d84..c47be91 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -229,6 +229,17 @@ config LEDS_MT6323
> This option enables support for on-chip LED drivers found on
> Mediatek MT6323 PMIC.
>
> +config LEDS_MT6360
> + tristate "LED Support for Mediatek MT6360 PMIC"
> + depends on LEDS_CLASS_FLASH && OF
> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
> + depends on MFD_MT6360
> + help
> + This option enables support for dual Flash LED drivers found on
> + Mediatek MT6360 PMIC.
> + Support Torch and Strobe mode independently current source.
> + Include Low-VF and short protection.
This should be in english... and should not contain
"advertising". Just delete last two lines.
More useful information would be listing hardware where this is often
found.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: gene_chen@richtek.com, linux-kernel@vger.kernel.org,
cy_huang@richtek.com, benjamin.chao@mediatek.com,
linux-mediatek@lists.infradead.org, jacek.anaszewski@gmail.com,
linux-leds@vger.kernel.org, matthias.bgg@gmail.com,
shufan_lee@richtek.com, Wilma.Wu@mediatek.com,
linux-arm-kernel@lists.infradead.org, dmurphy@ti.com
Subject: Re: [PATCH] leds: mt6360: Add LED driver for MT6360
Date: Thu, 4 Jun 2020 15:52:12 +0200 [thread overview]
Message-ID: <20200604135212.GI7222@duo.ucw.cz> (raw)
In-Reply-To: <1591252004-12681-1-git-send-email-gene.chen.richtek@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1081 bytes --]
Hi!
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index c664d84..c47be91 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -229,6 +229,17 @@ config LEDS_MT6323
> This option enables support for on-chip LED drivers found on
> Mediatek MT6323 PMIC.
>
> +config LEDS_MT6360
> + tristate "LED Support for Mediatek MT6360 PMIC"
> + depends on LEDS_CLASS_FLASH && OF
> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
> + depends on MFD_MT6360
> + help
> + This option enables support for dual Flash LED drivers found on
> + Mediatek MT6360 PMIC.
> + Support Torch and Strobe mode independently current source.
> + Include Low-VF and short protection.
This should be in english... and should not contain
"advertising". Just delete last two lines.
More useful information would be listing hardware where this is often
found.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-04 13:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 6:26 [PATCH] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-06-04 6:26 ` Gene Chen
2020-06-04 6:26 ` Gene Chen
2020-06-04 12:06 ` Pavel Machek
2020-06-04 12:06 ` Pavel Machek
2020-06-04 12:06 ` Pavel Machek
2020-06-04 13:50 ` Pavel Machek
2020-06-04 13:50 ` Pavel Machek
2020-06-04 13:50 ` Pavel Machek
2020-06-04 13:52 ` Pavel Machek [this message]
2020-06-04 13:52 ` Pavel Machek
2020-06-04 13:52 ` Pavel Machek
2020-06-04 16:07 ` Dan Murphy
2020-06-04 16:07 ` Dan Murphy
2020-06-04 16:07 ` Dan Murphy
2020-06-05 22:27 ` Jacek Anaszewski
2020-06-05 22:27 ` Jacek Anaszewski
2020-06-05 22:27 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604135212.GI7222@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=dmurphy@ti.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.