* [PATCH] scs: Report SCS usage in bytes rather than number of entries
@ 2020-06-03 15:12 ` Will Deacon
0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2020-06-03 15:12 UTC (permalink / raw)
To: linux-kernel; +Cc: keescook, linux-arm-kernel, Will Deacon, Sami Tolvanen
Fix the SCS debug usage check so that we report the number of bytes
usedm, rather than the number of entries.
Fixes: 5bbaf9d1fcb9 ("scs: Add support for stack usage debugging")
Reported-by: Sami Tolvanen <samitolvanen@google.com>
Signed-off-by: Will Deacon <will@kernel.org>
---
kernel/scs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/scs.c b/kernel/scs.c
index 222a7a9ad543..5d4d9bbdec36 100644
--- a/kernel/scs.c
+++ b/kernel/scs.c
@@ -74,7 +74,7 @@ static void scs_check_usage(struct task_struct *tsk)
for (p = task_scs(tsk); p < __scs_magic(tsk); ++p) {
if (!READ_ONCE_NOCHECK(*p))
break;
- used++;
+ used += sizeof(*p);
}
while (used > curr) {
--
2.27.0.rc2.251.g90737beb825-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] scs: Report SCS usage in bytes rather than number of entries
@ 2020-06-03 15:12 ` Will Deacon
0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2020-06-03 15:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Sami Tolvanen, Will Deacon, keescook, linux-arm-kernel
Fix the SCS debug usage check so that we report the number of bytes
usedm, rather than the number of entries.
Fixes: 5bbaf9d1fcb9 ("scs: Add support for stack usage debugging")
Reported-by: Sami Tolvanen <samitolvanen@google.com>
Signed-off-by: Will Deacon <will@kernel.org>
---
kernel/scs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/scs.c b/kernel/scs.c
index 222a7a9ad543..5d4d9bbdec36 100644
--- a/kernel/scs.c
+++ b/kernel/scs.c
@@ -74,7 +74,7 @@ static void scs_check_usage(struct task_struct *tsk)
for (p = task_scs(tsk); p < __scs_magic(tsk); ++p) {
if (!READ_ONCE_NOCHECK(*p))
break;
- used++;
+ used += sizeof(*p);
}
while (used > curr) {
--
2.27.0.rc2.251.g90737beb825-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] scs: Report SCS usage in bytes rather than number of entries
2020-06-03 15:12 ` Will Deacon
@ 2020-06-03 17:06 ` Kees Cook
-1 siblings, 0 replies; 6+ messages in thread
From: Kees Cook @ 2020-06-03 17:06 UTC (permalink / raw)
To: Will Deacon; +Cc: linux-kernel, linux-arm-kernel, Sami Tolvanen
On Wed, Jun 03, 2020 at 04:12:17PM +0100, Will Deacon wrote:
> Fix the SCS debug usage check so that we report the number of bytes
> usedm, rather than the number of entries.
typo: used
>
> Fixes: 5bbaf9d1fcb9 ("scs: Add support for stack usage debugging")
> Reported-by: Sami Tolvanen <samitolvanen@google.com>
> Signed-off-by: Will Deacon <will@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scs: Report SCS usage in bytes rather than number of entries
@ 2020-06-03 17:06 ` Kees Cook
0 siblings, 0 replies; 6+ messages in thread
From: Kees Cook @ 2020-06-03 17:06 UTC (permalink / raw)
To: Will Deacon; +Cc: Sami Tolvanen, linux-kernel, linux-arm-kernel
On Wed, Jun 03, 2020 at 04:12:17PM +0100, Will Deacon wrote:
> Fix the SCS debug usage check so that we report the number of bytes
> usedm, rather than the number of entries.
typo: used
>
> Fixes: 5bbaf9d1fcb9 ("scs: Add support for stack usage debugging")
> Reported-by: Sami Tolvanen <samitolvanen@google.com>
> Signed-off-by: Will Deacon <will@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scs: Report SCS usage in bytes rather than number of entries
2020-06-03 17:06 ` Kees Cook
@ 2020-06-04 15:15 ` Will Deacon
-1 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2020-06-04 15:15 UTC (permalink / raw)
To: Kees Cook; +Cc: linux-kernel, linux-arm-kernel, Sami Tolvanen
On Wed, Jun 03, 2020 at 10:06:13AM -0700, Kees Cook wrote:
> On Wed, Jun 03, 2020 at 04:12:17PM +0100, Will Deacon wrote:
> > Fix the SCS debug usage check so that we report the number of bytes
> > usedm, rather than the number of entries.
>
> typo: used
>
> >
> > Fixes: 5bbaf9d1fcb9 ("scs: Add support for stack usage debugging")
> > Reported-by: Sami Tolvanen <samitolvanen@google.com>
> > Signed-off-by: Will Deacon <will@kernel.org>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Cheers, Kees!
Will
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scs: Report SCS usage in bytes rather than number of entries
@ 2020-06-04 15:15 ` Will Deacon
0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2020-06-04 15:15 UTC (permalink / raw)
To: Kees Cook; +Cc: Sami Tolvanen, linux-kernel, linux-arm-kernel
On Wed, Jun 03, 2020 at 10:06:13AM -0700, Kees Cook wrote:
> On Wed, Jun 03, 2020 at 04:12:17PM +0100, Will Deacon wrote:
> > Fix the SCS debug usage check so that we report the number of bytes
> > usedm, rather than the number of entries.
>
> typo: used
>
> >
> > Fixes: 5bbaf9d1fcb9 ("scs: Add support for stack usage debugging")
> > Reported-by: Sami Tolvanen <samitolvanen@google.com>
> > Signed-off-by: Will Deacon <will@kernel.org>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Cheers, Kees!
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-04 15:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-03 15:12 [PATCH] scs: Report SCS usage in bytes rather than number of entries Will Deacon
2020-06-03 15:12 ` Will Deacon
2020-06-03 17:06 ` Kees Cook
2020-06-03 17:06 ` Kees Cook
2020-06-04 15:15 ` Will Deacon
2020-06-04 15:15 ` Will Deacon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.