All of lore.kernel.org
 help / color / mirror / Atom feed
* [arnd-playground:headers-clean-test 3/30] drivers/net/dsa/lantiq_gswip.c:1676:10: warning: assignment makes pointer from integer without a cast
@ 2020-06-04  7:07 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2020-06-04  7:07 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 5403 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git headers-clean-test
head:   a25b75e508f3199f82d682ff1c5d6968d3286581
commit: 293b42e6ba557e8e3b70d504f708aef7493b0d8d [3/30] headers: stop using linux/dma-mapping.h from linux/skbuff.h
config: x86_64-randconfig-a004-20200603 (attached as .config)
compiler: gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010
reproduce (this is a W=1 build):
        git checkout 293b42e6ba557e8e3b70d504f708aef7493b0d8d
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/net/dsa/lantiq_gswip.c: In function 'gswip_gphy_fw_load':
drivers/net/dsa/lantiq_gswip.c:1676:12: error: implicit declaration of function 'dmam_alloc_coherent' [-Werror=implicit-function-declaration]
fw_addr = dmam_alloc_coherent(dev, size, &dma_addr, GFP_KERNEL);
^
>> drivers/net/dsa/lantiq_gswip.c:1676:10: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
fw_addr = dmam_alloc_coherent(dev, size, &dma_addr, GFP_KERNEL);
^
cc1: some warnings being treated as errors

vim +1676 drivers/net/dsa/lantiq_gswip.c

14fceff4771e51 Hauke Mehrtens 2018-09-09  1647  
14fceff4771e51 Hauke Mehrtens 2018-09-09  1648  static int gswip_gphy_fw_load(struct gswip_priv *priv, struct gswip_gphy_fw *gphy_fw)
14fceff4771e51 Hauke Mehrtens 2018-09-09  1649  {
14fceff4771e51 Hauke Mehrtens 2018-09-09  1650  	struct device *dev = priv->dev;
14fceff4771e51 Hauke Mehrtens 2018-09-09  1651  	const struct firmware *fw;
14fceff4771e51 Hauke Mehrtens 2018-09-09  1652  	void *fw_addr;
14fceff4771e51 Hauke Mehrtens 2018-09-09  1653  	dma_addr_t dma_addr;
14fceff4771e51 Hauke Mehrtens 2018-09-09  1654  	dma_addr_t dev_addr;
14fceff4771e51 Hauke Mehrtens 2018-09-09  1655  	size_t size;
14fceff4771e51 Hauke Mehrtens 2018-09-09  1656  	int ret;
14fceff4771e51 Hauke Mehrtens 2018-09-09  1657  
14fceff4771e51 Hauke Mehrtens 2018-09-09  1658  	ret = clk_prepare_enable(gphy_fw->clk_gate);
14fceff4771e51 Hauke Mehrtens 2018-09-09  1659  	if (ret)
14fceff4771e51 Hauke Mehrtens 2018-09-09  1660  		return ret;
14fceff4771e51 Hauke Mehrtens 2018-09-09  1661  
14fceff4771e51 Hauke Mehrtens 2018-09-09  1662  	reset_control_assert(gphy_fw->reset);
14fceff4771e51 Hauke Mehrtens 2018-09-09  1663  
14fceff4771e51 Hauke Mehrtens 2018-09-09  1664  	ret = request_firmware(&fw, gphy_fw->fw_name, dev);
14fceff4771e51 Hauke Mehrtens 2018-09-09  1665  	if (ret) {
14fceff4771e51 Hauke Mehrtens 2018-09-09  1666  		dev_err(dev, "failed to load firmware: %s, error: %i\n",
14fceff4771e51 Hauke Mehrtens 2018-09-09  1667  			gphy_fw->fw_name, ret);
14fceff4771e51 Hauke Mehrtens 2018-09-09  1668  		return ret;
14fceff4771e51 Hauke Mehrtens 2018-09-09  1669  	}
14fceff4771e51 Hauke Mehrtens 2018-09-09  1670  
14fceff4771e51 Hauke Mehrtens 2018-09-09  1671  	/* GPHY cores need the firmware code in a persistent and contiguous
14fceff4771e51 Hauke Mehrtens 2018-09-09  1672  	 * memory area with a 16 kB boundary aligned start address.
14fceff4771e51 Hauke Mehrtens 2018-09-09  1673  	 */
14fceff4771e51 Hauke Mehrtens 2018-09-09  1674  	size = fw->size + XRX200_GPHY_FW_ALIGN;
14fceff4771e51 Hauke Mehrtens 2018-09-09  1675  
14fceff4771e51 Hauke Mehrtens 2018-09-09 @1676  	fw_addr = dmam_alloc_coherent(dev, size, &dma_addr, GFP_KERNEL);
14fceff4771e51 Hauke Mehrtens 2018-09-09  1677  	if (fw_addr) {
14fceff4771e51 Hauke Mehrtens 2018-09-09  1678  		fw_addr = PTR_ALIGN(fw_addr, XRX200_GPHY_FW_ALIGN);
14fceff4771e51 Hauke Mehrtens 2018-09-09  1679  		dev_addr = ALIGN(dma_addr, XRX200_GPHY_FW_ALIGN);
14fceff4771e51 Hauke Mehrtens 2018-09-09  1680  		memcpy(fw_addr, fw->data, fw->size);
14fceff4771e51 Hauke Mehrtens 2018-09-09  1681  	} else {
14fceff4771e51 Hauke Mehrtens 2018-09-09  1682  		dev_err(dev, "failed to alloc firmware memory\n");
14fceff4771e51 Hauke Mehrtens 2018-09-09  1683  		release_firmware(fw);
14fceff4771e51 Hauke Mehrtens 2018-09-09  1684  		return -ENOMEM;
14fceff4771e51 Hauke Mehrtens 2018-09-09  1685  	}
14fceff4771e51 Hauke Mehrtens 2018-09-09  1686  
14fceff4771e51 Hauke Mehrtens 2018-09-09  1687  	release_firmware(fw);
14fceff4771e51 Hauke Mehrtens 2018-09-09  1688  
14fceff4771e51 Hauke Mehrtens 2018-09-09  1689  	ret = regmap_write(priv->rcu_regmap, gphy_fw->fw_addr_offset, dev_addr);
14fceff4771e51 Hauke Mehrtens 2018-09-09  1690  	if (ret)
14fceff4771e51 Hauke Mehrtens 2018-09-09  1691  		return ret;
14fceff4771e51 Hauke Mehrtens 2018-09-09  1692  
14fceff4771e51 Hauke Mehrtens 2018-09-09  1693  	reset_control_deassert(gphy_fw->reset);
14fceff4771e51 Hauke Mehrtens 2018-09-09  1694  
14fceff4771e51 Hauke Mehrtens 2018-09-09  1695  	return ret;
14fceff4771e51 Hauke Mehrtens 2018-09-09  1696  }
14fceff4771e51 Hauke Mehrtens 2018-09-09  1697  

:::::: The code at line 1676 was first introduced by commit
:::::: 14fceff4771e51b23b4485b575cf9e5b3414b89b net: dsa: Add Lantiq / Intel DSA driver for vrx200

:::::: TO: Hauke Mehrtens <hauke@hauke-m.de>
:::::: CC: David S. Miller <davem@davemloft.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37731 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-04  7:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-04  7:07 [arnd-playground:headers-clean-test 3/30] drivers/net/dsa/lantiq_gswip.c:1676:10: warning: assignment makes pointer from integer without a cast kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.