* [PATCH] dmaengine: sprd: handle the failure cases of pm_runtime_get_sync
@ 2020-06-04 20:38 Navid Emamdoost
0 siblings, 0 replies; only message in thread
From: Navid Emamdoost @ 2020-06-04 20:38 UTC (permalink / raw)
To: Dan Williams, Vinod Koul, Orson Zhai, Baolin Wang, Chunyan Zhang,
dmaengine, linux-kernel
Cc: emamd001, wu000273, kjlu, smccaman, Navid Emamdoost
Calling pm_runtime_get_sync increments the counter even in case of
failure, causing incorrect ref count. Call pm_runtime_put if
pm_runtime_get_sync fails.
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
drivers/dma/sprd-dma.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
index 0ef5ca81ba4d..0ba4fe1a1905 100644
--- a/drivers/dma/sprd-dma.c
+++ b/drivers/dma/sprd-dma.c
@@ -1204,8 +1204,10 @@ static int sprd_dma_probe(struct platform_device *pdev)
pm_runtime_enable(&pdev->dev);
ret = pm_runtime_get_sync(&pdev->dev);
- if (ret < 0)
+ if (ret < 0) {
+ pm_runtime_put_noidle(&pdev->dev);
goto err_rpm;
+ }
ret = dma_async_device_register(&sdev->dma_dev);
if (ret < 0) {
@@ -1239,8 +1241,10 @@ static int sprd_dma_remove(struct platform_device *pdev)
int ret;
ret = pm_runtime_get_sync(&pdev->dev);
- if (ret < 0)
+ if (ret < 0) {
+ pm_runtime_put_noidle(&pdev->dev);
return ret;
+ }
/* explicitly free the irq */
if (sdev->irq > 0)
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-04 20:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-04 20:38 [PATCH] dmaengine: sprd: handle the failure cases of pm_runtime_get_sync Navid Emamdoost
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.