From: Mark Brown <broonie@kernel.org> To: Lee Jones <lee.jones@linaro.org> Cc: "Michael Walle" <michael@walle.cc>, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Linus Walleij" <linus.walleij@linaro.org>, "Bartosz Golaszewski" <bgolaszewski@baylibre.com>, "Rob Herring" <robh+dt@kernel.org>, "Jean Delvare" <jdelvare@suse.com>, "Guenter Roeck" <linux@roeck-us.net>, "Thierry Reding" <thierry.reding@gmail.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Wim Van Sebroeck" <wim@linux-watchdog.org>, "Shawn Guo" <shawnguo@kernel.org>, "Li Yang" <leoyang.li@nxp.com>, "Thomas Gleixner" <tglx@linutronix.de>, "Jason Cooper" <jason@lakedaemon.net>, "Marc Zyngier" <maz@kernel.org>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Andy Shevchenko" <andriy.shevchenko@linux.intel.com> Subject: Re: [PATCH v4 02/11] mfd: Add support for Kontron sl28cpld management controller Date: Fri, 5 Jun 2020 11:50:26 +0100 [thread overview] Message-ID: <20200605105026.GC5413@sirena.org.uk> (raw) In-Reply-To: <20200605065709.GD3714@dell> [-- Attachment #1: Type: text/plain, Size: 911 bytes --] On Fri, Jun 05, 2020 at 07:57:09AM +0100, Lee Jones wrote: > On Thu, 04 Jun 2020, Michael Walle wrote: > > + sl28cpld->regmap = devm_regmap_init_i2c(i2c, &sl28cpld_regmap_config); > > + if (IS_ERR(sl28cpld->regmap)) > > + return PTR_ERR(sl28cpld->regmap); > This is now a shared memory allocator and not an MFD at all. > I'm clamping down on these type of drivers! > Please find a better way to accomplish this. What is the concern with this? Looking at the patch I'm guessing the concern would be that the driver isn't instantiating any MFD children and instead requiring them to be put in the DT? > Potentially using "simple-mfd" and "simple-regmap". > The former already exists and does what you want. The latter doesn't > yet exist, but could solve your and lots of other contributor's > issues. I have no idea what you are thinking of when you say "simple-regmap" so it is difficult to comment. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Lee Jones <lee.jones@linaro.org> Cc: devicetree@vger.kernel.org, "Linus Walleij" <linus.walleij@linaro.org>, "Thierry Reding" <thierry.reding@gmail.com>, "Jason Cooper" <jason@lakedaemon.net>, "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>, "Marc Zyngier" <maz@kernel.org>, "Bartosz Golaszewski" <bgolaszewski@baylibre.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Guenter Roeck" <linux@roeck-us.net>, linux-pwm@vger.kernel.org, "Jean Delvare" <jdelvare@suse.com>, linux-watchdog@vger.kernel.org, linux-gpio@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Wim Van Sebroeck" <wim@linux-watchdog.org>, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, "Li Yang" <leoyang.li@nxp.com>, "Michael Walle" <michael@walle.cc>, "Shawn Guo" <shawnguo@kernel.org> Subject: Re: [PATCH v4 02/11] mfd: Add support for Kontron sl28cpld management controller Date: Fri, 5 Jun 2020 11:50:26 +0100 [thread overview] Message-ID: <20200605105026.GC5413@sirena.org.uk> (raw) In-Reply-To: <20200605065709.GD3714@dell> [-- Attachment #1.1: Type: text/plain, Size: 911 bytes --] On Fri, Jun 05, 2020 at 07:57:09AM +0100, Lee Jones wrote: > On Thu, 04 Jun 2020, Michael Walle wrote: > > + sl28cpld->regmap = devm_regmap_init_i2c(i2c, &sl28cpld_regmap_config); > > + if (IS_ERR(sl28cpld->regmap)) > > + return PTR_ERR(sl28cpld->regmap); > This is now a shared memory allocator and not an MFD at all. > I'm clamping down on these type of drivers! > Please find a better way to accomplish this. What is the concern with this? Looking at the patch I'm guessing the concern would be that the driver isn't instantiating any MFD children and instead requiring them to be put in the DT? > Potentially using "simple-mfd" and "simple-regmap". > The former already exists and does what you want. The latter doesn't > yet exist, but could solve your and lots of other contributor's > issues. I have no idea what you are thinking of when you say "simple-regmap" so it is difficult to comment. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-05 10:50 UTC|newest] Thread overview: 214+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-04 21:10 [PATCH v4 00/11] Add support for Kontron sl28cpld Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-04 21:10 ` [PATCH v4 01/11] dt-bindings: mfd: Add bindings for sl28cpld Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-09 16:28 ` Rob Herring 2020-06-09 16:28 ` Rob Herring 2020-06-09 16:28 ` Rob Herring 2020-06-04 21:10 ` [PATCH v4 02/11] mfd: Add support for Kontron sl28cpld management controller Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-05 6:57 ` Lee Jones 2020-06-05 6:57 ` Lee Jones 2020-06-05 6:57 ` Lee Jones 2020-06-05 9:51 ` Michael Walle 2020-06-05 9:51 ` Michael Walle 2020-06-05 9:51 ` Michael Walle 2020-06-05 10:50 ` Mark Brown [this message] 2020-06-05 10:50 ` Mark Brown 2020-06-05 20:07 ` Michael Walle 2020-06-05 20:07 ` Michael Walle 2020-06-05 20:07 ` Michael Walle 2020-06-06 11:46 ` Mark Brown 2020-06-06 11:46 ` Mark Brown 2020-06-06 12:45 ` Michael Walle 2020-06-06 12:45 ` Michael Walle 2020-06-06 12:45 ` Michael Walle 2020-06-08 8:28 ` Lee Jones 2020-06-08 8:28 ` Lee Jones 2020-06-08 8:28 ` Lee Jones 2020-06-08 10:02 ` Andy Shevchenko 2020-06-08 10:02 ` Andy Shevchenko 2020-06-08 10:02 ` Andy Shevchenko 2020-06-08 15:41 ` Michael Walle 2020-06-08 15:41 ` Michael Walle 2020-06-08 15:41 ` Michael Walle 2020-06-08 18:56 ` Lee Jones 2020-06-08 18:56 ` Lee Jones 2020-06-08 18:56 ` Lee Jones 2020-06-08 21:09 ` Michael Walle 2020-06-08 21:09 ` Michael Walle 2020-06-08 21:09 ` Michael Walle 2020-06-09 6:47 ` Lee Jones 2020-06-09 6:47 ` Lee Jones 2020-06-09 6:47 ` Lee Jones 2020-06-09 14:38 ` Michael Walle 2020-06-09 14:38 ` Michael Walle 2020-06-09 14:38 ` Michael Walle 2020-06-09 14:42 ` Mark Brown 2020-06-09 14:42 ` Mark Brown 2020-06-09 14:42 ` Mark Brown 2020-06-09 15:01 ` Michael Walle 2020-06-09 15:01 ` Michael Walle 2020-06-09 15:01 ` Michael Walle 2020-06-09 17:15 ` Rob Herring 2020-06-09 17:15 ` Rob Herring 2020-06-09 17:15 ` Rob Herring 2020-06-09 17:29 ` Mark Brown 2020-06-09 17:29 ` Mark Brown 2020-06-09 17:29 ` Mark Brown 2020-06-09 18:41 ` Lee Jones 2020-06-09 18:41 ` Lee Jones 2020-06-09 18:41 ` Lee Jones 2020-06-09 15:19 ` Lee Jones 2020-06-09 15:19 ` Lee Jones 2020-06-09 15:19 ` Lee Jones 2020-06-09 15:30 ` Michael Walle 2020-06-09 15:30 ` Michael Walle 2020-06-09 15:30 ` Michael Walle 2020-06-09 19:45 ` Lee Jones 2020-06-09 19:45 ` Lee Jones 2020-06-09 19:45 ` Lee Jones 2020-06-10 7:10 ` Michael Walle 2020-06-10 7:10 ` Michael Walle 2020-06-10 7:10 ` Michael Walle 2020-06-10 7:19 ` Lee Jones 2020-06-10 7:19 ` Lee Jones 2020-06-10 7:19 ` Lee Jones 2020-06-10 7:49 ` Michael Walle 2020-06-10 7:49 ` Michael Walle 2020-06-10 7:49 ` Michael Walle 2020-06-10 7:56 ` Lee Jones 2020-06-10 7:56 ` Lee Jones 2020-06-10 7:56 ` Lee Jones 2020-06-10 9:27 ` Michael Walle 2020-06-10 9:27 ` Michael Walle 2020-06-10 9:27 ` Michael Walle 2020-06-10 18:30 ` Lee Jones 2020-06-10 18:30 ` Lee Jones 2020-06-10 18:30 ` Lee Jones 2020-06-10 17:16 ` Rob Herring 2020-06-10 17:16 ` Rob Herring 2020-06-10 17:16 ` Rob Herring 2020-06-10 18:02 ` Lee Jones 2020-06-10 18:02 ` Lee Jones 2020-06-10 18:02 ` Lee Jones 2020-06-08 18:20 ` Lee Jones 2020-06-08 18:20 ` Lee Jones 2020-06-08 18:20 ` Lee Jones 2020-06-09 16:54 ` Rob Herring 2020-06-09 16:54 ` Rob Herring 2020-06-09 16:54 ` Rob Herring 2020-06-09 18:52 ` Lee Jones 2020-06-09 18:52 ` Lee Jones 2020-06-09 18:52 ` Lee Jones 2020-06-05 8:01 ` Andy Shevchenko 2020-06-05 8:01 ` Andy Shevchenko 2020-06-05 8:01 ` Andy Shevchenko 2020-06-05 8:02 ` Andy Shevchenko 2020-06-05 8:02 ` Andy Shevchenko 2020-06-05 8:02 ` Andy Shevchenko 2020-06-05 10:09 ` Michael Walle 2020-06-05 10:09 ` Michael Walle 2020-06-05 10:09 ` Michael Walle 2020-06-05 10:48 ` Andy Shevchenko 2020-06-05 10:48 ` Andy Shevchenko 2020-06-05 10:48 ` Andy Shevchenko 2020-06-05 11:51 ` Michael Walle 2020-06-05 11:51 ` Michael Walle 2020-06-05 11:51 ` Michael Walle 2020-06-04 21:10 ` [PATCH v4 03/11] irqchip: add sl28cpld interrupt controller support Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-05 1:26 ` kernel test robot 2020-06-05 1:26 ` kernel test robot 2020-06-05 1:26 ` kernel test robot 2020-06-05 8:07 ` Andy Shevchenko 2020-06-05 8:07 ` Andy Shevchenko 2020-06-05 8:07 ` Andy Shevchenko 2020-06-08 15:12 ` kernel test robot 2020-06-08 15:12 ` kernel test robot 2020-06-08 15:12 ` kernel test robot 2020-06-08 15:12 ` kernel test robot 2020-06-04 21:10 ` [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-05 8:14 ` Andy Shevchenko 2020-06-05 8:14 ` Andy Shevchenko 2020-06-05 8:14 ` Andy Shevchenko 2020-06-05 10:24 ` Michael Walle 2020-06-05 10:24 ` Michael Walle 2020-06-05 10:24 ` Michael Walle 2020-06-05 10:50 ` Andy Shevchenko 2020-06-05 10:50 ` Andy Shevchenko 2020-06-05 10:50 ` Andy Shevchenko 2020-06-05 13:52 ` Guenter Roeck 2020-06-05 13:52 ` Guenter Roeck 2020-06-05 13:52 ` Guenter Roeck 2020-06-05 14:09 ` Andy Shevchenko 2020-06-05 14:09 ` Andy Shevchenko 2020-06-05 14:09 ` Andy Shevchenko 2020-06-05 15:05 ` Guenter Roeck 2020-06-05 15:05 ` Guenter Roeck 2020-06-05 15:05 ` Guenter Roeck 2020-06-05 16:04 ` Andy Shevchenko 2020-06-05 16:04 ` Andy Shevchenko 2020-06-05 16:04 ` Andy Shevchenko 2020-06-05 16:34 ` Guenter Roeck 2020-06-05 16:34 ` Guenter Roeck 2020-06-05 16:34 ` Guenter Roeck 2020-06-04 21:10 ` [PATCH v4 05/11] pwm: add support for sl28cpld PWM controller Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-05 8:15 ` Andy Shevchenko 2020-06-05 8:15 ` Andy Shevchenko 2020-06-05 8:15 ` Andy Shevchenko 2020-06-05 8:49 ` Lee Jones 2020-06-05 8:49 ` Lee Jones 2020-06-05 8:49 ` Lee Jones 2020-06-05 9:33 ` Andy Shevchenko 2020-06-05 9:33 ` Andy Shevchenko 2020-06-05 9:33 ` Andy Shevchenko 2020-06-05 11:39 ` Michael Walle 2020-06-05 11:39 ` Michael Walle 2020-06-05 11:39 ` Michael Walle 2020-06-05 18:17 ` Michael Walle 2020-06-05 18:17 ` Michael Walle 2020-06-05 18:17 ` Michael Walle 2020-06-08 7:46 ` Lee Jones 2020-06-08 7:46 ` Lee Jones 2020-06-08 7:46 ` Lee Jones 2020-06-04 21:10 ` [PATCH v4 06/11] gpio: add support for the sl28cpld GPIO controller Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-05 12:00 ` Andy Shevchenko 2020-06-05 12:00 ` Andy Shevchenko 2020-06-05 12:00 ` Andy Shevchenko 2020-06-05 12:42 ` Michael Walle 2020-06-05 12:42 ` Michael Walle 2020-06-05 12:42 ` Michael Walle 2020-06-05 13:15 ` Andy Shevchenko 2020-06-05 13:15 ` Andy Shevchenko 2020-06-05 13:15 ` Andy Shevchenko 2020-06-05 18:44 ` Michael Walle 2020-06-05 18:44 ` Michael Walle 2020-06-05 18:44 ` Michael Walle 2020-06-05 21:19 ` Andy Shevchenko 2020-06-05 21:19 ` Andy Shevchenko 2020-06-05 21:19 ` Andy Shevchenko 2020-06-04 21:10 ` [PATCH v4 07/11] hwmon: add support for the sl28cpld hardware monitoring controller Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-05 12:06 ` Andy Shevchenko 2020-06-05 12:06 ` Andy Shevchenko 2020-06-05 12:06 ` Andy Shevchenko 2020-06-04 21:10 ` [PATCH v4 08/11] arm64: dts: freescale: sl28: enable sl28cpld Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-04 21:10 ` [PATCH v4 09/11] arm64: dts: freescale: sl28: map GPIOs to input events Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-04 21:10 ` [PATCH v4 10/11] arm64: dts: freescale: sl28: enable LED support Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-04 21:10 ` [PATCH v4 11/11] arm64: dts: freescale: sl28: enable fan support Michael Walle 2020-06-04 21:10 ` Michael Walle 2020-06-05 6:13 ` [PATCH v4 00/11] Add support for Kontron sl28cpld Lee Jones 2020-06-05 6:13 ` Lee Jones 2020-06-05 6:13 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200605105026.GC5413@sirena.org.uk \ --to=broonie@kernel.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=bgolaszewski@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jason@lakedaemon.net \ --cc=jdelvare@suse.com \ --cc=lee.jones@linaro.org \ --cc=leoyang.li@nxp.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=maz@kernel.org \ --cc=michael@walle.cc \ --cc=robh+dt@kernel.org \ --cc=shawnguo@kernel.org \ --cc=tglx@linutronix.de \ --cc=thierry.reding@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ --cc=wim@linux-watchdog.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.