From: Matthew Wilcox <willy@infradead.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jason Yan <yanaijie@huawei.com>,
hulkci@huawei.com, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
Jens Axboe <axboe@kernel.dk>, Ming Lei <ming.lei@redhat.com>
Subject: Re: block: Fix use-after-free in blkdev_get()
Date: Fri, 5 Jun 2020 04:42:08 -0700 [thread overview]
Message-ID: <20200605114208.GC19604@bombadil.infradead.org> (raw)
In-Reply-To: <63e57552-ab95-7bb4-b4f1-70a307b6381d@web.de>
On Fri, Jun 05, 2020 at 01:40:37PM +0200, Markus Elfring wrote:
> >> I am trying to contribute a bit of patch review as usual.
> >
> > We have asked you again and again to stop commenting on commit messages.
>
> I am going to continue with constructive feedback at some places.
>
>
> > New kernel developers have emailed me privately to say that your review
> > comments confused and discouraged them.
>
> Did these contributors not dare to ask me directly about mentioned details?
>
> Some developers found parts of my reviews helpful, didn't they?
Overall you are a net negative to kernel development. Please change
how you contribute.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jason Yan <yanaijie@huawei.com>,
hulkci@huawei.com, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
Jens Axboe <axboe@kernel.dk>, Ming Lei <ming.lei@redhat.com>
Subject: Re: block: Fix use-after-free in blkdev_get()
Date: Fri, 05 Jun 2020 11:42:08 +0000 [thread overview]
Message-ID: <20200605114208.GC19604@bombadil.infradead.org> (raw)
In-Reply-To: <63e57552-ab95-7bb4-b4f1-70a307b6381d@web.de>
On Fri, Jun 05, 2020 at 01:40:37PM +0200, Markus Elfring wrote:
> >> I am trying to contribute a bit of patch review as usual.
> >
> > We have asked you again and again to stop commenting on commit messages.
>
> I am going to continue with constructive feedback at some places.
>
>
> > New kernel developers have emailed me privately to say that your review
> > comments confused and discouraged them.
>
> Did these contributors not dare to ask me directly about mentioned details?
>
> Some developers found parts of my reviews helpful, didn't they?
Overall you are a net negative to kernel development. Please change
how you contribute.
next prev parent reply other threads:[~2020-06-05 11:42 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 8:30 [PATCH v2] block: Fix use-after-free in blkdev_get() Markus Elfring
2020-06-05 8:30 ` Markus Elfring
2020-06-05 9:05 ` Jason Yan
2020-06-05 9:05 ` Jason Yan
2020-06-05 9:43 ` Dan Carpenter
2020-06-05 9:43 ` Dan Carpenter
2020-06-05 10:56 ` Markus Elfring
2020-06-05 10:56 ` Markus Elfring
2020-06-05 11:10 ` Dan Carpenter
2020-06-05 11:10 ` Dan Carpenter
2020-06-05 11:40 ` Markus Elfring
2020-06-05 11:40 ` Markus Elfring
2020-06-05 11:42 ` Matthew Wilcox [this message]
2020-06-05 11:42 ` Matthew Wilcox
2020-06-05 12:47 ` Markus Elfring
2020-06-05 12:47 ` Markus Elfring
2020-06-05 12:52 ` Matthew Wilcox
2020-06-05 12:52 ` Matthew Wilcox
2020-06-05 13:12 ` Markus Elfring
2020-06-05 13:12 ` Markus Elfring
2020-06-05 15:15 ` Matthew Wilcox
2020-06-05 15:15 ` Matthew Wilcox
2020-06-05 15:25 ` Markus Elfring
2020-06-05 15:25 ` Markus Elfring
2020-06-05 11:10 ` [PATCH v2] " Matthew Wilcox
2020-06-05 11:10 ` Matthew Wilcox
2020-06-05 11:48 ` Markus Elfring
2020-06-05 11:48 ` Markus Elfring
2020-06-05 11:51 ` Matthew Wilcox
2020-06-05 11:51 ` Matthew Wilcox
2020-06-05 13:01 ` Markus Elfring
2020-06-05 13:01 ` Markus Elfring
2020-06-05 13:01 ` Markus Elfring
2020-06-05 13:01 ` Markus Elfring
2020-06-05 13:04 ` Jens Axboe
2020-06-05 13:04 ` Jens Axboe
2020-06-05 13:23 ` Markus Elfring
2020-06-05 13:23 ` Markus Elfring
2020-06-05 11:10 ` [PATCH v2] " Sedat Dilek
2020-06-05 11:10 ` Sedat Dilek
2020-06-05 14:42 ` Jan Kara
2020-06-05 14:42 ` Jan Kara
2020-06-05 18:08 ` Dan Carpenter
2020-06-05 18:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605114208.GC19604@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=Markus.Elfring@web.de \
--cc=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=hch@lst.de \
--cc=hulkci@huawei.com \
--cc=jack@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.