* [Intel-gfx] [PATCH] drm/i915: Fix comments mentioning typo in IS_ENABLED()
@ 2020-06-05 14:19 ` Kees Cook
0 siblings, 0 replies; 13+ messages in thread
From: Kees Cook @ 2020-06-05 14:19 UTC (permalink / raw)
To: David Airlie, Daniel Vetter
Cc: intel-gfx, linux-kernel, dri-devel, Chris Wilson, Joe Perches
This has no code changes, but the typo is clearly getting copy/pasted,
so better to avoid this now and fix the typo. IS_ENABLED() takes full
names, and must have the "CONFIG_" prefix.
Reported-by: Joe Perches <joe@perches.com>
Link: https://lore.kernel.org/lkml/b08611018fdb6d88757c6008a5c02fa0e07b32fb.camel@perches.com
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/dma-buf/selftests.h | 2 +-
drivers/gpu/drm/i915/selftests/i915_live_selftests.h | 2 +-
drivers/gpu/drm/i915/selftests/i915_mock_selftests.h | 2 +-
drivers/gpu/drm/i915/selftests/i915_perf_selftests.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/dma-buf/selftests.h b/drivers/dma-buf/selftests.h
index 55918ef9adab..bc8cea67bf1e 100644
--- a/drivers/dma-buf/selftests.h
+++ b/drivers/dma-buf/selftests.h
@@ -5,7 +5,7 @@
* a module parameter. It must be unique and legal for a C identifier.
*
* The function should be of type int function(void). It may be conditionally
- * compiled using #if IS_ENABLED(DRM_I915_SELFTEST).
+ * compiled using #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST).
*
* Tests are executed in order by igt/dmabuf_selftest
*/
diff --git a/drivers/gpu/drm/i915/selftests/i915_live_selftests.h b/drivers/gpu/drm/i915/selftests/i915_live_selftests.h
index 5dd5d81646c4..e42ea9c6703b 100644
--- a/drivers/gpu/drm/i915/selftests/i915_live_selftests.h
+++ b/drivers/gpu/drm/i915/selftests/i915_live_selftests.h
@@ -11,7 +11,7 @@
* a module parameter. It must be unique and legal for a C identifier.
*
* The function should be of type int function(void). It may be conditionally
- * compiled using #if IS_ENABLED(DRM_I915_SELFTEST).
+ * compiled using #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST).
*
* Tests are executed in order by igt/drv_selftest
*/
diff --git a/drivers/gpu/drm/i915/selftests/i915_mock_selftests.h b/drivers/gpu/drm/i915/selftests/i915_mock_selftests.h
index 6a2be7d0dd95..4be044198af9 100644
--- a/drivers/gpu/drm/i915/selftests/i915_mock_selftests.h
+++ b/drivers/gpu/drm/i915/selftests/i915_mock_selftests.h
@@ -11,7 +11,7 @@
* a module parameter. It must be unique and legal for a C identifier.
*
* The function should be of type int function(void). It may be conditionally
- * compiled using #if IS_ENABLED(DRM_I915_SELFTEST).
+ * compiled using #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST).
*
* Tests are executed in order by igt/drv_selftest
*/
diff --git a/drivers/gpu/drm/i915/selftests/i915_perf_selftests.h b/drivers/gpu/drm/i915/selftests/i915_perf_selftests.h
index d8da142985eb..c2389f8a257d 100644
--- a/drivers/gpu/drm/i915/selftests/i915_perf_selftests.h
+++ b/drivers/gpu/drm/i915/selftests/i915_perf_selftests.h
@@ -11,7 +11,7 @@
* a module parameter. It must be unique and legal for a C identifier.
*
* The function should be of type int function(void). It may be conditionally
- * compiled using #if IS_ENABLED(DRM_I915_SELFTEST).
+ * compiled using #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST).
*
* Tests are executed in order by igt/i915_selftest
*/
--
2.25.1
--
Kees Cook
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] drm/i915: Fix comments mentioning typo in IS_ENABLED()
@ 2020-06-05 14:19 ` Kees Cook
0 siblings, 0 replies; 13+ messages in thread
From: Kees Cook @ 2020-06-05 14:19 UTC (permalink / raw)
To: David Airlie, Daniel Vetter
Cc: intel-gfx, linux-kernel, dri-devel, Chris Wilson, Joe Perches
This has no code changes, but the typo is clearly getting copy/pasted,
so better to avoid this now and fix the typo. IS_ENABLED() takes full
names, and must have the "CONFIG_" prefix.
Reported-by: Joe Perches <joe@perches.com>
Link: https://lore.kernel.org/lkml/b08611018fdb6d88757c6008a5c02fa0e07b32fb.camel@perches.com
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/dma-buf/selftests.h | 2 +-
drivers/gpu/drm/i915/selftests/i915_live_selftests.h | 2 +-
drivers/gpu/drm/i915/selftests/i915_mock_selftests.h | 2 +-
drivers/gpu/drm/i915/selftests/i915_perf_selftests.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/dma-buf/selftests.h b/drivers/dma-buf/selftests.h
index 55918ef9adab..bc8cea67bf1e 100644
--- a/drivers/dma-buf/selftests.h
+++ b/drivers/dma-buf/selftests.h
@@ -5,7 +5,7 @@
* a module parameter. It must be unique and legal for a C identifier.
*
* The function should be of type int function(void). It may be conditionally
- * compiled using #if IS_ENABLED(DRM_I915_SELFTEST).
+ * compiled using #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST).
*
* Tests are executed in order by igt/dmabuf_selftest
*/
diff --git a/drivers/gpu/drm/i915/selftests/i915_live_selftests.h b/drivers/gpu/drm/i915/selftests/i915_live_selftests.h
index 5dd5d81646c4..e42ea9c6703b 100644
--- a/drivers/gpu/drm/i915/selftests/i915_live_selftests.h
+++ b/drivers/gpu/drm/i915/selftests/i915_live_selftests.h
@@ -11,7 +11,7 @@
* a module parameter. It must be unique and legal for a C identifier.
*
* The function should be of type int function(void). It may be conditionally
- * compiled using #if IS_ENABLED(DRM_I915_SELFTEST).
+ * compiled using #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST).
*
* Tests are executed in order by igt/drv_selftest
*/
diff --git a/drivers/gpu/drm/i915/selftests/i915_mock_selftests.h b/drivers/gpu/drm/i915/selftests/i915_mock_selftests.h
index 6a2be7d0dd95..4be044198af9 100644
--- a/drivers/gpu/drm/i915/selftests/i915_mock_selftests.h
+++ b/drivers/gpu/drm/i915/selftests/i915_mock_selftests.h
@@ -11,7 +11,7 @@
* a module parameter. It must be unique and legal for a C identifier.
*
* The function should be of type int function(void). It may be conditionally
- * compiled using #if IS_ENABLED(DRM_I915_SELFTEST).
+ * compiled using #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST).
*
* Tests are executed in order by igt/drv_selftest
*/
diff --git a/drivers/gpu/drm/i915/selftests/i915_perf_selftests.h b/drivers/gpu/drm/i915/selftests/i915_perf_selftests.h
index d8da142985eb..c2389f8a257d 100644
--- a/drivers/gpu/drm/i915/selftests/i915_perf_selftests.h
+++ b/drivers/gpu/drm/i915/selftests/i915_perf_selftests.h
@@ -11,7 +11,7 @@
* a module parameter. It must be unique and legal for a C identifier.
*
* The function should be of type int function(void). It may be conditionally
- * compiled using #if IS_ENABLED(DRM_I915_SELFTEST).
+ * compiled using #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST).
*
* Tests are executed in order by igt/i915_selftest
*/
--
2.25.1
--
Kees Cook
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix comments mentioning typo in IS_ENABLED()
2020-06-05 14:19 ` Kees Cook
(?)
@ 2020-06-05 14:40 ` Chris Wilson
-1 siblings, 0 replies; 13+ messages in thread
From: Chris Wilson @ 2020-06-05 14:40 UTC (permalink / raw)
To: Daniel Vetter, David Airlie, Kees Cook
Cc: intel-gfx, linux-kernel, dri-devel, Joe Perches
Quoting Kees Cook (2020-06-05 15:19:53)
> This has no code changes, but the typo is clearly getting copy/pasted,
> so better to avoid this now and fix the typo. IS_ENABLED() takes full
> names, and must have the "CONFIG_" prefix.
>
> Reported-by: Joe Perches <joe@perches.com>
> Link: https://lore.kernel.org/lkml/b08611018fdb6d88757c6008a5c02fa0e07b32fb.camel@perches.com
> Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix comments mentioning typo in IS_ENABLED()
@ 2020-06-05 14:40 ` Chris Wilson
0 siblings, 0 replies; 13+ messages in thread
From: Chris Wilson @ 2020-06-05 14:40 UTC (permalink / raw)
To: Daniel Vetter, David Airlie, Kees Cook
Cc: Joe Perches, intel-gfx, linux-kernel, dri-devel
Quoting Kees Cook (2020-06-05 15:19:53)
> This has no code changes, but the typo is clearly getting copy/pasted,
> so better to avoid this now and fix the typo. IS_ENABLED() takes full
> names, and must have the "CONFIG_" prefix.
>
> Reported-by: Joe Perches <joe@perches.com>
> Link: https://lore.kernel.org/lkml/b08611018fdb6d88757c6008a5c02fa0e07b32fb.camel@perches.com
> Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix comments mentioning typo in IS_ENABLED()
@ 2020-06-05 14:40 ` Chris Wilson
0 siblings, 0 replies; 13+ messages in thread
From: Chris Wilson @ 2020-06-05 14:40 UTC (permalink / raw)
To: Daniel Vetter, David Airlie, Kees Cook
Cc: Joe Perches, intel-gfx, linux-kernel, dri-devel
Quoting Kees Cook (2020-06-05 15:19:53)
> This has no code changes, but the typo is clearly getting copy/pasted,
> so better to avoid this now and fix the typo. IS_ENABLED() takes full
> names, and must have the "CONFIG_" prefix.
>
> Reported-by: Joe Perches <joe@perches.com>
> Link: https://lore.kernel.org/lkml/b08611018fdb6d88757c6008a5c02fa0e07b32fb.camel@perches.com
> Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix comments mentioning typo in IS_ENABLED()
2020-06-05 14:19 ` Kees Cook
` (2 preceding siblings ...)
(?)
@ 2020-06-05 15:39 ` Patchwork
-1 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-06-05 15:39 UTC (permalink / raw)
To: Kees Cook; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix comments mentioning typo in IS_ENABLED()
URL : https://patchwork.freedesktop.org/series/78044/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8590 -> Patchwork_17888
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/index.html
Known issues
------------
Here are the changes found in Patchwork_17888 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-icl-u2: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-byt-j1900: [DMESG-WARN][3] ([i915#1982]) -> [PASS][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/fi-byt-j1900/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/fi-byt-j1900/igt@i915_module_load@reload.html
- fi-byt-n2820: [DMESG-WARN][5] ([i915#1982]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/fi-byt-n2820/igt@i915_module_load@reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/fi-byt-n2820/igt@i915_module_load@reload.html
- fi-tgl-y: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/fi-tgl-y/igt@i915_module_load@reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/fi-tgl-y/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- {fi-tgl-dsi}: [DMESG-WARN][9] ([i915#1982]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/fi-tgl-dsi/igt@i915_pm_rpm@basic-pci-d3-state.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/fi-tgl-dsi/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@module-reload:
- fi-apl-guc: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/fi-apl-guc/igt@i915_pm_rpm@module-reload.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/fi-apl-guc/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@active:
- fi-whl-u: [DMESG-FAIL][13] ([i915#666]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/fi-whl-u/igt@i915_selftest@live@active.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/fi-whl-u/igt@i915_selftest@live@active.html
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92] / [i915#95]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/fi-kbl-x1275/igt@kms_busy@basic@flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/fi-kbl-x1275/igt@kms_busy@basic@flip.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-n3050: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
- fi-icl-guc: [DMESG-WARN][19] ([i915#1982]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/fi-icl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/fi-icl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
- fi-bsw-kefka: [DMESG-WARN][21] ([i915#1982]) -> [PASS][22] +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][23] ([i915#62] / [i915#92]) -> [DMESG-WARN][24] ([i915#62] / [i915#92] / [i915#95]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][25] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][26] ([i915#62] / [i915#92]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#666]: https://gitlab.freedesktop.org/drm/intel/issues/666
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (50 -> 43)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8590 -> Patchwork_17888
CI-20190529: 20190529
CI_DRM_8590: 91c6f0274b54c89679cd23f6fc65e9fe5922971f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5695: 53e8c878a6fb5708e63c99403691e8960b86ea9c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17888: f6f5eb4457be93abbc43374cbb6e2c6cca6f2035 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f6f5eb4457be drm/i915: Fix comments mentioning typo in IS_ENABLED()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix comments mentioning typo in IS_ENABLED()
2020-06-05 14:19 ` Kees Cook
` (3 preceding siblings ...)
(?)
@ 2020-06-05 17:15 ` Patchwork
-1 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-06-05 17:15 UTC (permalink / raw)
To: Kees Cook; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix comments mentioning typo in IS_ENABLED()
URL : https://patchwork.freedesktop.org/series/78044/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8590_full -> Patchwork_17888_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
New tests
---------
New tests have been introduced between CI_DRM_8590_full and Patchwork_17888_full:
### New IGT tests (14) ###
* igt@gem_exec_balancer@bonded-cork:
- Statuses : 6 pass(s) 2 skip(s)
- Exec time: [0.0, 10.11] s
* igt@gem_exec_balancer@bonded-imm:
- Statuses : 6 pass(s) 2 skip(s)
- Exec time: [0.0, 9.77] s
* igt@gem_exec_balancer@busy:
- Statuses : 6 pass(s) 2 skip(s)
- Exec time: [0.0, 5.08] s
* igt@gem_exec_balancer@full:
- Statuses : 6 pass(s) 2 skip(s)
- Exec time: [0.0, 10.29] s
* igt@gem_exec_balancer@full-late:
- Statuses : 6 pass(s) 2 skip(s)
- Exec time: [0.0, 10.39] s
* igt@gem_exec_balancer@full-late-pulse:
- Statuses : 6 pass(s) 2 skip(s)
- Exec time: [0.0, 10.48] s
* igt@gem_exec_balancer@full-pulse:
- Statuses : 6 pass(s) 2 skip(s)
- Exec time: [0.0, 10.54] s
* igt@gem_exec_balancer@indices:
- Statuses : 6 pass(s) 2 skip(s)
- Exec time: [0.0, 10.19] s
* igt@gem_exec_balancer@individual:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@gem_exec_balancer@invalid-balancer:
- Statuses : 6 pass(s) 2 skip(s)
- Exec time: [0.0, 10.07] s
* igt@gem_exec_balancer@invalid-bonds:
- Statuses : 6 pass(s) 2 skip(s)
- Exec time: [0.0, 0.04] s
* igt@gem_exec_balancer@nop:
- Statuses : 6 pass(s) 2 skip(s)
- Exec time: [0.0, 45.82] s
* igt@gem_exec_balancer@semaphore:
- Statuses : 6 pass(s) 2 skip(s)
- Exec time: [0.0, 9.92] s
* igt@gem_exec_balancer@smoke:
- Statuses : 6 pass(s) 2 skip(s)
- Exec time: [0.0, 23.00] s
Known issues
------------
Here are the changes found in Patchwork_17888_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([i915#180]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-kbl4/igt@gem_exec_suspend@basic-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-kbl7/igt@gem_exec_suspend@basic-s3.html
* igt@gem_exec_whisper@basic-contexts-forked:
- shard-glk: [PASS][3] -> [DMESG-WARN][4] ([i915#118] / [i915#95])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-glk8/igt@gem_exec_whisper@basic-contexts-forked.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-glk8/igt@gem_exec_whisper@basic-contexts-forked.html
* igt@gem_tiled_pread_basic:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([i915#95]) +17 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-apl3/igt@gem_tiled_pread_basic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-apl6/igt@gem_tiled_pread_basic.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-tglb: [PASS][7] -> [DMESG-WARN][8] ([i915#402]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-tglb5/igt@i915_module_load@reload-with-fault-injection.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-tglb1/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-apl2/igt@i915_suspend@fence-restore-tiled2untiled.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@i915_suspend@forcewake:
- shard-glk: [PASS][11] -> [INCOMPLETE][12] ([i915#58] / [k.org#198133])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-glk8/igt@i915_suspend@forcewake.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-glk2/igt@i915_suspend@forcewake.html
- shard-skl: [PASS][13] -> [INCOMPLETE][14] ([i915#636] / [i915#69])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-skl1/igt@i915_suspend@forcewake.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-skl7/igt@i915_suspend@forcewake.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-0:
- shard-skl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) +5 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-skl3/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-skl2/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-0:
- shard-apl: [PASS][17] -> [DMESG-WARN][18] ([i915#1982])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-apl6/igt@kms_big_fb@x-tiled-8bpp-rotate-0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-apl1/igt@kms_big_fb@x-tiled-8bpp-rotate-0.html
- shard-glk: [PASS][19] -> [DMESG-WARN][20] ([i915#1982]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-glk4/igt@kms_big_fb@x-tiled-8bpp-rotate-0.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-glk6/igt@kms_big_fb@x-tiled-8bpp-rotate-0.html
* igt@kms_cursor_crc@pipe-a-cursor-64x21-random:
- shard-kbl: [PASS][21] -> [DMESG-FAIL][22] ([i915#54] / [i915#95])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-64x21-random.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-64x21-random.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [PASS][23] -> [FAIL][24] ([i915#57])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-hsw8/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-kbl: [PASS][25] -> [DMESG-WARN][26] ([i915#93] / [i915#95]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-kbl: [PASS][27] -> [DMESG-WARN][28] ([i915#62] / [i915#92]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-cpu:
- shard-skl: [PASS][29] -> [FAIL][30] ([i915#49])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-skl9/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-cpu.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-skl8/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-cpu.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][31] -> [FAIL][32] ([fdo#108145] / [i915#265]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-iclb8/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-d:
- shard-tglb: [PASS][35] -> [DMESG-WARN][36] ([i915#1982])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-tglb1/igt@kms_universal_plane@universal-plane-gen9-features-pipe-d.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-tglb8/igt@kms_universal_plane@universal-plane-gen9-features-pipe-d.html
#### Possible fixes ####
* {igt@gem_ctx_isolation@preservation-s3@rcs0}:
- shard-apl: [DMESG-WARN][37] ([i915#180]) -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-apl2/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-apl7/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@gem_eio@in-flight-suspend:
- shard-kbl: [DMESG-WARN][39] ([i915#180]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-kbl4/igt@gem_eio@in-flight-suspend.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-kbl1/igt@gem_eio@in-flight-suspend.html
* {igt@gem_exec_reloc@basic-concurrent0}:
- shard-glk: [FAIL][41] ([i915#1930]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-glk9/igt@gem_exec_reloc@basic-concurrent0.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-glk7/igt@gem_exec_reloc@basic-concurrent0.html
* igt@gem_exec_whisper@basic-normal-all:
- shard-glk: [DMESG-WARN][43] ([i915#118] / [i915#95]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-glk7/igt@gem_exec_whisper@basic-normal-all.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-glk2/igt@gem_exec_whisper@basic-normal-all.html
* igt@gen9_exec_parse@allowed-all:
- shard-kbl: [DMESG-WARN][45] ([i915#1436] / [i915#716]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-kbl1/igt@gen9_exec_parse@allowed-all.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-kbl6/igt@gen9_exec_parse@allowed-all.html
* igt@i915_suspend@debugfs-reader:
- shard-kbl: [INCOMPLETE][47] ([i915#155]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-kbl2/igt@i915_suspend@debugfs-reader.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-kbl2/igt@i915_suspend@debugfs-reader.html
* igt@kms_color@pipe-c-ctm-red-to-blue:
- shard-kbl: [DMESG-WARN][49] ([i915#93] / [i915#95]) -> [PASS][50] +4 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-kbl7/igt@kms_color@pipe-c-ctm-red-to-blue.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-kbl2/igt@kms_color@pipe-c-ctm-red-to-blue.html
* igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen:
- shard-skl: [FAIL][51] ([i915#54]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-skl3/igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen.html
* igt@kms_cursor_legacy@all-pipes-torture-move:
- shard-skl: [DMESG-WARN][53] ([i915#128]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-skl10/igt@kms_cursor_legacy@all-pipes-torture-move.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-skl5/igt@kms_cursor_legacy@all-pipes-torture-move.html
* {igt@kms_flip@2x-flip-vs-suspend@ab-hdmi-a1-hdmi-a2}:
- shard-glk: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-glk6/igt@kms_flip@2x-flip-vs-suspend@ab-hdmi-a1-hdmi-a2.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-glk5/igt@kms_flip@2x-flip-vs-suspend@ab-hdmi-a1-hdmi-a2.html
* igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw:
- shard-skl: [FAIL][57] ([i915#49]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-skl3/igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw.html
* {igt@kms_getfb@getfb2-handle-protection}:
- shard-apl: [DMESG-WARN][59] ([i915#95]) -> [PASS][60] +22 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-apl6/igt@kms_getfb@getfb2-handle-protection.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-apl8/igt@kms_getfb@getfb2-handle-protection.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [DMESG-WARN][61] ([i915#1982]) -> [PASS][62] +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][63] ([fdo#109642] / [fdo#111068]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-iclb1/igt@kms_psr2_su@frontbuffer.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][65] ([i915#31]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-kbl6/igt@kms_setmode@basic.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-kbl1/igt@kms_setmode@basic.html
* {igt@perf@polling-parameterized}:
- shard-hsw: [FAIL][67] ([i915#1542]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-hsw6/igt@perf@polling-parameterized.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-hsw2/igt@perf@polling-parameterized.html
#### Warnings ####
* igt@i915_pm_rpm@reg-read-ioctl:
- shard-kbl: [DMESG-WARN][69] ([i915#93] / [i915#95]) -> [DMESG-WARN][70] ([i915#62] / [i915#92])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-kbl7/igt@i915_pm_rpm@reg-read-ioctl.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-kbl2/igt@i915_pm_rpm@reg-read-ioctl.html
* igt@kms_content_protection@atomic:
- shard-apl: [FAIL][71] ([fdo#110321] / [fdo#110336]) -> [TIMEOUT][72] ([i915#1319])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-apl6/igt@kms_content_protection@atomic.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-apl8/igt@kms_content_protection@atomic.html
* igt@kms_content_protection@atomic-dpms:
- shard-kbl: [TIMEOUT][73] ([i915#1319]) -> [TIMEOUT][74] ([i915#1319] / [i915#1958])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-kbl7/igt@kms_content_protection@atomic-dpms.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-kbl4/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@legacy:
- shard-kbl: [DMESG-FAIL][75] ([fdo#110321]) -> [TIMEOUT][76] ([i915#1319] / [i915#1958])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-kbl3/igt@kms_content_protection@legacy.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-kbl4/igt@kms_content_protection@legacy.html
* igt@kms_content_protection@lic:
- shard-apl: [DMESG-FAIL][77] ([fdo#110321] / [i915#95]) -> [TIMEOUT][78] ([i915#1319] / [i915#1635]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-apl2/igt@kms_content_protection@lic.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-apl7/igt@kms_content_protection@lic.html
* igt@kms_content_protection@srm:
- shard-kbl: [DMESG-FAIL][79] ([fdo#110321] / [i915#95]) -> [TIMEOUT][80] ([i915#1319])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-kbl2/igt@kms_content_protection@srm.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-kbl7/igt@kms_content_protection@srm.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [DMESG-WARN][81] ([i915#180] / [i915#95]) -> [DMESG-WARN][82] ([i915#95])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8590/shard-apl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/shard-apl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1928]: https://gitlab.freedesktop.org/drm/intel/issues/1928
[i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#57]: https://gitlab.freedesktop.org/drm/intel/issues/57
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#636]: https://gitlab.freedesktop.org/drm/intel/issues/636
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8590 -> Patchwork_17888
CI-20190529: 20190529
CI_DRM_8590: 91c6f0274b54c89679cd23f6fc65e9fe5922971f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5695: 53e8c878a6fb5708e63c99403691e8960b86ea9c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17888: f6f5eb4457be93abbc43374cbb6e2c6cca6f2035 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17888/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] checkpatch: Add test for possible misuse of IS_ENABLED() without CONFIG_
2020-06-05 14:19 ` Kees Cook
` (4 preceding siblings ...)
(?)
@ 2020-06-05 18:24 ` Joe Perches
2020-06-05 18:48 ` Kees Cook
2020-06-06 0:32 ` Andrew Morton
-1 siblings, 2 replies; 13+ messages in thread
From: Joe Perches @ 2020-06-05 18:24 UTC (permalink / raw)
To: Andrew Morton; +Cc: Kees Cook, linux-kernel
IS_ENABLED is almost always used with CONFIG_<FOO> defines.
Add a test to verify that the #define being tested starts with CONFIG_.
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/checkpatch.pl | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 5f00df2c3f59..83be88b16166 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6480,6 +6480,12 @@ sub process {
}
}
+# check for IS_ENABLED() without CONFIG_<FOO> ($rawline for comments too)
+ if ($rawline =~ /\bIS_ENABLED\s*\(\s*(\w+)\s*\)/ && $1 !~ /^CONFIG_/) {
+ WARN("IS_ENABLED_CONFIG",
+ "IS_ENABLED($1) is normally used as IS_ENABLED(CONFIG_$1)\n" . $herecurr);
+ }
+
# check for #if defined CONFIG_<FOO> || defined CONFIG_<FOO>_MODULE
if ($line =~ /^\+\s*#\s*if\s+defined(?:\s*\(?\s*|\s+)(CONFIG_[A-Z_]+)\s*\)?\s*\|\|\s*defined(?:\s*\(?\s*|\s+)\1_MODULE\s*\)?\s*$/) {
my $config = $1;
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] checkpatch: Add test for possible misuse of IS_ENABLED() without CONFIG_
2020-06-05 18:24 ` [PATCH] checkpatch: Add test for possible misuse of IS_ENABLED() without CONFIG_ Joe Perches
@ 2020-06-05 18:48 ` Kees Cook
2020-06-06 0:32 ` Andrew Morton
1 sibling, 0 replies; 13+ messages in thread
From: Kees Cook @ 2020-06-05 18:48 UTC (permalink / raw)
To: Joe Perches; +Cc: Andrew Morton, linux-kernel
On Fri, Jun 05, 2020 at 11:24:43AM -0700, Joe Perches wrote:
> IS_ENABLED is almost always used with CONFIG_<FOO> defines.
>
> Add a test to verify that the #define being tested starts with CONFIG_.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] checkpatch: Add test for possible misuse of IS_ENABLED() without CONFIG_
2020-06-05 18:24 ` [PATCH] checkpatch: Add test for possible misuse of IS_ENABLED() without CONFIG_ Joe Perches
2020-06-05 18:48 ` Kees Cook
@ 2020-06-06 0:32 ` Andrew Morton
2020-06-06 1:58 ` Joe Perches
1 sibling, 1 reply; 13+ messages in thread
From: Andrew Morton @ 2020-06-06 0:32 UTC (permalink / raw)
To: Joe Perches; +Cc: Kees Cook, linux-kernel
On Fri, 05 Jun 2020 11:24:43 -0700 Joe Perches <joe@perches.com> wrote:
> IS_ENABLED is almost always used with CONFIG_<FOO> defines.
>
> Add a test to verify that the #define being tested starts with CONFIG_.
Yay.
I wonder if there's a simple way of testing whether the CONFIG_ thing
can *ever* be enabled. So detect if someone does
if (IS_ENABLED(CONFIG_BLOCKK))
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] checkpatch: Add test for possible misuse of IS_ENABLED() without CONFIG_
2020-06-06 0:32 ` Andrew Morton
@ 2020-06-06 1:58 ` Joe Perches
2020-06-06 9:41 ` Joe Perches
0 siblings, 1 reply; 13+ messages in thread
From: Joe Perches @ 2020-06-06 1:58 UTC (permalink / raw)
To: Andrew Morton; +Cc: Kees Cook, linux-kernel
On Fri, 2020-06-05 at 17:32 -0700, Andrew Morton wrote:
> On Fri, 05 Jun 2020 11:24:43 -0700 Joe Perches <joe@perches.com> wrote:
>
> > IS_ENABLED is almost always used with CONFIG_<FOO> defines.
> >
> > Add a test to verify that the #define being tested starts with CONFIG_.
>
> Yay.
>
> I wonder if there's a simple way of testing whether the CONFIG_ thing
> can *ever* be enabled. So detect if someone does
>
> if (IS_ENABLED(CONFIG_BLOCKK))
No, not really. There's no simple way to do that.
It's doable, but it's not at all simple.
I think it would require something similar to the
checkpatch seed_camelcase_includes function to look
for all current config symbols and verify whatever
CONFIG_<DEFINE> against that list.
$ git grep -P -oh "^\s*config\s+\w+" -- '*/Kconfig*' | \
sed -r -e 's/^\s+//' -e 's/\s+/ /g' | \
sort | uniq -cym
Right now that takes ~1.5 seconds with my laptop
against an uncached git tree, and ~0.25 seconds cached.
Without a git tree it takes 20+ seconds.
Anyway, maybe this.
It only does the time consuming lookup when
it finds a IS_ENABLED line.
---
scripts/checkpatch.pl | 101 ++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 101 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 5f00df2c3f59..aabb01cf1e6c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -47,6 +47,7 @@ my $gitroot = $ENV{'GIT_DIR'};
$gitroot = ".git" if !defined($gitroot);
my %debug;
my %camelcase = ();
+my %Kconfig_syms = ();
my %use_type = ();
my @use = ();
my %ignore_type = ();
@@ -911,6 +912,90 @@ sub is_SPDX_License_valid {
return 1;
}
+sub seed_Kconfig_file {
+ my ($file) = @_;
+
+ return if (!(-f $file));
+
+ local $/;
+
+ open(my $Kconfig_file, '<', "$file")
+ or warn "$P: Can't read '$file' $!\n";
+ my $text = <$Kconfig_file>;
+ close($Kconfig_file);
+
+ my @lines = split('\n', $text);
+
+ foreach my $line (@lines) {
+ next if ($line !~ /^\s*config\s+(\w+)/);
+ $Kconfig_syms{$1} = 1;
+ }
+}
+
+my $Kconfig_symbols_seeded = 0;
+sub seed_Kconfig_symbols {
+ return if ($Kconfig_symbols_seeded);
+
+ my $files;
+ my @Kconfig_files = ();
+ my $Kconfig_syms_cache = "";
+
+ $Kconfig_symbols_seeded = 1;
+
+ if (-e "$gitroot") {
+ my $git_last_include_commit = `${git_command} log --no-merges --pretty=format:"%h%n" -1 -- include`;
+ chomp $git_last_include_commit;
+ $Kconfig_syms_cache = ".checkpatch-Kconfig_syms.git.$git_last_include_commit";
+ } else {
+ my $last_mod_date = 0;
+ $files = `find $root/ -name "Kconfig*"`;
+ @Kconfig_files = split('\n', $files);
+ foreach my $file (@Kconfig_files) {
+ my $date = POSIX::strftime("%Y%m%d%H%M",
+ localtime((stat $file)[9]));
+ $last_mod_date = $date if ($last_mod_date < $date);
+ }
+ $Kconfig_syms_cache = ".checkpatch-Kconfig_syms.date.$last_mod_date";
+ }
+
+ if ($Kconfig_syms_cache ne "" && -f $Kconfig_syms_cache) {
+ open(my $Kconfig_syms_file, '<', "$Kconfig_syms_cache")
+ or warn "$P: Can't read '$Kconfig_syms_cache' $!\n";
+ while (<$Kconfig_syms_file>) {
+ chomp;
+ $Kconfig_syms{$_} = 1;
+ }
+ close($Kconfig_syms_file);
+
+ return;
+ }
+
+ if (-e "$gitroot") {
+ my @syms = `${git_command} grep -P -oh '^\\s*config\\s+\\w+' -- '*/Kconfig*'`;
+ s/^\s+// for @syms;
+ s/config\s+// for @syms;
+ s/\n$// for @syms;
+ @syms = sort(uniq(@syms));
+ foreach my $sym (@syms) {
+ $Kconfig_syms{$sym} = 1;
+ }
+ } else {
+ foreach my $file (@Kconfig_files) {
+ seed_Kconfig_file($file);
+ }
+ }
+
+ if ($Kconfig_syms_cache ne "") {
+ unlink glob ".checkpatch-Kconfig_syms.*";
+ open(my $Kconfig_syms_file, '>', "$Kconfig_syms_cache")
+ or warn "$P: Can't write '$Kconfig_syms_cache' $!\n";
+ foreach (sort { lc($a) cmp lc($b) } keys(%Kconfig_syms)) {
+ print $Kconfig_syms_file ("$_\n");
+ }
+ close($Kconfig_syms_file);
+ }
+}
+
my $camelcase_seeded = 0;
sub seed_camelcase_includes {
return if ($camelcase_seeded);
@@ -6480,6 +6565,22 @@ sub process {
}
}
+# check for IS_ENABLED() used without CONFIG_<FOO> ($rawline for comment use)
+# or if the CONFIG_<FOO> symbol is not a known Kconfig entry
+ if ($rawline =~ /\bIS_ENABLED\s*\(\s*(\w+)\s*\)/) {
+ my $sym = $1;
+ seed_Kconfig_symbols();
+ if ($sym !~ /^CONFIG_/) {
+ WARN("IS_ENABLED_CONFIG",
+ "IS_ENABLED($sym) is normally used as IS_ENABLED(CONFIG_$1)\n" . $herecurr);
+ }
+ if (!exists($Kconfig_syms{$sym})) {
+ WARN("IS_ENABLED_CONFIG",
+ "'$sym' is not a known Kconfig config entry in the current kernel sources\n" . $herecurr);
+
+ }
+ }
+
# check for #if defined CONFIG_<FOO> || defined CONFIG_<FOO>_MODULE
if ($line =~ /^\+\s*#\s*if\s+defined(?:\s*\(?\s*|\s+)(CONFIG_[A-Z_]+)\s*\)?\s*\|\|\s*defined(?:\s*\(?\s*|\s+)\1_MODULE\s*\)?\s*$/) {
my $config = $1;
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] checkpatch: Add test for possible misuse of IS_ENABLED() without CONFIG_
2020-06-06 1:58 ` Joe Perches
@ 2020-06-06 9:41 ` Joe Perches
0 siblings, 0 replies; 13+ messages in thread
From: Joe Perches @ 2020-06-06 9:41 UTC (permalink / raw)
To: Andrew Morton; +Cc: Kees Cook, linux-kernel
Might s well post one that works
Interdiff similar to:
+ if ($sym !~ /^CONFIG_/) {
+ WARN("IS_ENABLED_CONFIG",
+ "IS_ENABLED($sym) is normally used as IS_ENABLED(CONFIG_$1)\n" . $herecurr);
++ } else {
++ $sym =~ s/^CONFIG_//;
+ }
+ if (!exists($Kconfig_syms{$sym})) {
+ WARN("IS_ENABLED_CONFIG",
-+ "'$sym' is not a known Kconfig config entry in the current kernel sources\n" . $herecurr);
-+
++ "'config $sym' is not a known Kconfig config entry in the current kernel sources\n" . $herecurr);
+ }
+ }
+
---
scripts/checkpatch.pl | 102 ++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 102 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 5f00df2c3f59..02814c689676 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -47,6 +47,7 @@ my $gitroot = $ENV{'GIT_DIR'};
$gitroot = ".git" if !defined($gitroot);
my %debug;
my %camelcase = ();
+my %Kconfig_syms = ();
my %use_type = ();
my @use = ();
my %ignore_type = ();
@@ -911,6 +912,90 @@ sub is_SPDX_License_valid {
return 1;
}
+sub seed_Kconfig_file {
+ my ($file) = @_;
+
+ return if (!(-f $file));
+
+ local $/;
+
+ open(my $Kconfig_file, '<', "$file")
+ or warn "$P: Can't read '$file' $!\n";
+ my $text = <$Kconfig_file>;
+ close($Kconfig_file);
+
+ my @lines = split('\n', $text);
+
+ foreach my $line (@lines) {
+ next if ($line !~ /^\s*config\s+(\w+)/);
+ $Kconfig_syms{$1} = 1;
+ }
+}
+
+my $Kconfig_symbols_seeded = 0;
+sub seed_Kconfig_symbols {
+ return if ($Kconfig_symbols_seeded);
+
+ my $files;
+ my @Kconfig_files = ();
+ my $Kconfig_syms_cache = "";
+
+ $Kconfig_symbols_seeded = 1;
+
+ if (-e "$gitroot") {
+ my $git_last_include_commit = `${git_command} log --no-merges --pretty=format:"%h%n" -1 -- include`;
+ chomp $git_last_include_commit;
+ $Kconfig_syms_cache = ".checkpatch-Kconfig_syms.git.$git_last_include_commit";
+ } else {
+ my $last_mod_date = 0;
+ $files = `find $root/ -name "Kconfig*"`;
+ @Kconfig_files = split('\n', $files);
+ foreach my $file (@Kconfig_files) {
+ my $date = POSIX::strftime("%Y%m%d%H%M",
+ localtime((stat $file)[9]));
+ $last_mod_date = $date if ($last_mod_date < $date);
+ }
+ $Kconfig_syms_cache = ".checkpatch-Kconfig_syms.date.$last_mod_date";
+ }
+
+ if ($Kconfig_syms_cache ne "" && -f $Kconfig_syms_cache) {
+ open(my $Kconfig_syms_file, '<', "$Kconfig_syms_cache")
+ or warn "$P: Can't read '$Kconfig_syms_cache' $!\n";
+ while (<$Kconfig_syms_file>) {
+ chomp;
+ $Kconfig_syms{$_} = 1;
+ }
+ close($Kconfig_syms_file);
+
+ return;
+ }
+
+ if (-e "$gitroot") {
+ my @syms = `${git_command} grep -P -oh '^\\s*config\\s+\\w+' -- '*/Kconfig*'`;
+ s/^\s+// for @syms;
+ s/config\s+// for @syms;
+ s/\n$// for @syms;
+ @syms = sort(uniq(@syms));
+ foreach my $sym (@syms) {
+ $Kconfig_syms{$sym} = 1;
+ }
+ } else {
+ foreach my $file (@Kconfig_files) {
+ seed_Kconfig_file($file);
+ }
+ }
+
+ if ($Kconfig_syms_cache ne "") {
+ unlink glob ".checkpatch-Kconfig_syms.*";
+ open(my $Kconfig_syms_file, '>', "$Kconfig_syms_cache")
+ or warn "$P: Can't write '$Kconfig_syms_cache' $!\n";
+ foreach (sort { lc($a) cmp lc($b) } keys(%Kconfig_syms)) {
+ print $Kconfig_syms_file ("$_\n");
+ }
+ close($Kconfig_syms_file);
+ }
+}
+
my $camelcase_seeded = 0;
sub seed_camelcase_includes {
return if ($camelcase_seeded);
@@ -6480,6 +6565,23 @@ sub process {
}
}
+# check for IS_ENABLED() used without CONFIG_<FOO> ($rawline for comment use)
+# or if the CONFIG_<FOO> symbol is not a known Kconfig entry
+ if ($rawline =~ /\bIS_ENABLED\s*\(\s*(\w+)\s*\)/) {
+ my $sym = $1;
+ seed_Kconfig_symbols();
+ if ($sym !~ /^CONFIG_/) {
+ WARN("IS_ENABLED_CONFIG",
+ "IS_ENABLED($sym) is normally used as IS_ENABLED(CONFIG_$1)\n" . $herecurr);
+ } else {
+ $sym =~ s/^CONFIG_//;
+ }
+ if (!exists($Kconfig_syms{$sym})) {
+ WARN("IS_ENABLED_CONFIG",
+ "'config $sym' is not a known Kconfig config entry in the current kernel sources\n" . $herecurr);
+ }
+ }
+
# check for #if defined CONFIG_<FOO> || defined CONFIG_<FOO>_MODULE
if ($line =~ /^\+\s*#\s*if\s+defined(?:\s*\(?\s*|\s+)(CONFIG_[A-Z_]+)\s*\)?\s*\|\|\s*defined(?:\s*\(?\s*|\s+)\1_MODULE\s*\)?\s*$/) {
my $config = $1;
^ permalink raw reply related [flat|nested] 13+ messages in thread