invalid user 123456-fsgqa

invalid user 123456-fsgqa

[Aurélien Aptel]

Hi,

Some tests require a second user named 123456-fsgqa
(generic/{381,383,597,598}) but that username is invalid on some Linux
systems (SUSE distros at least) where a username cannot start with a
digit.

Would it be ok to send a patch to change that second user to "fsgqa2"?

Cheers,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)

Re: invalid user 123456-fsgqa

[Darrick J. Wong]

On Thu, Jun 04, 2020 at 03:37:18PM +0200, Aurélien Aptel wrote:
> Hi,
> 
> Some tests require a second user named 123456-fsgqa
> (generic/{381,383,597,598}) but that username is invalid on some Linux
> systems (SUSE distros at least) where a username cannot start with a
> digit.
> 
> Would it be ok to send a patch to change that second user to "fsgqa2"?

Does it break generic/381 or generic/383?  Those look like regression
tests for broken behavior when usernames start with digits.

This sounds more like something to _notrun the test from a _require*
check.

--D

> Cheers,
> -- 
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)

Re: invalid user 123456-fsgqa

[Zorro Lang]

On Thu, Jun 04, 2020 at 03:37:18PM +0200, Aurélien Aptel wrote:
> Hi,
> 
> Some tests require a second user named 123456-fsgqa
> (generic/{381,383,597,598}) but that username is invalid on some Linux
> systems (SUSE distros at least) where a username cannot start with a
> digit.
> 
> Would it be ok to send a patch to change that second user to "fsgqa2"?

No.

For g/381 and g/383, the 123456-fsgqa is necessary, they test xfs_quota with
user/group name beginning with digits, they're known bug coverage. If you system
can't create a user name likes 123456-fsgqa, just skip that. I think if your
system doesn't have 123456-fsgqa, the g/381 and g/383 will _notrun automatically,
right?

I don't learn about g/597,598(Eric might know that), if some other cases just
need another user name, you can have fsgqa2 or anyother names. But please update
README, if you change that.

Thanks,
Zorro

> 
> Cheers,
> -- 
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
>