[PATCH libnetfilter_queue 0/1] URGENT: libnetfilter_queue-1.0.4 fails to build

[PATCH libnetfilter_queue 0/1] URGENT: libnetfilter_queue-1.0.4 fails to build

[Duncan Roe]

'make' says: No rule to build ../fixmanpages.sh: stop
Maybe you can push out a re-release before anyone else notices?
Do what you must,

Cheers ... Duncan.

Duncan Roe (1):
  build: dist: Add fixmanpages.sh to distribution tree

 Makefile.am | 1 +
 1 file changed, 1 insertion(+)

-- 
2.14.5

[PATCH libnetfilter_queue 1/1] build: dist: Add fixmanpages.sh to distribution tree

[Duncan Roe]

Tested by running Slackware package builder on libnetfilter_queue-1.0.4.tar.bz2
created by 'make dist' after applying the patch. Works now, failed before.

Signed-off-by: Duncan Roe <duncan_roe@optusnet.com.au>
---
 Makefile.am | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile.am b/Makefile.am
index a5b347b..796f0d0 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -10,3 +10,4 @@ pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = libnetfilter_queue.pc
 
 EXTRA_DIST += Make_global.am
+EXTRA_DIST += fixmanpages.sh
-- 
2.14.5

Re: [PATCH libnetfilter_queue 0/1] URGENT: libnetfilter_queue-1.0.4 fails to build

[Jan Engelhardt]

On Saturday 2020-06-06 07:25, Duncan Roe wrote:

>'make' says: No rule to build ../fixmanpages.sh: stop
>Maybe you can push out a re-release before anyone else notices?

No to rereleases. That just upsets distros and automated scripts that 
have already downloaded the file (we're now past 23 hours anyway) and 
would raise a "their server was hacked" flag because the 
signatures/checksums no longer match between what's brewing in the 
distro staging and upstream URL.

Re: [PATCH libnetfilter_queue 1/1] build: dist: Add fixmanpages.sh to distribution tree

[Pablo Neira Ayuso]

On Sat, Jun 06, 2020 at 03:25:10PM +1000, Duncan Roe wrote:
> Tested by running Slackware package builder on libnetfilter_queue-1.0.4.tar.bz2
> created by 'make dist' after applying the patch. Works now, failed before.
> 
> Signed-off-by: Duncan Roe <duncan_roe@optusnet.com.au>
> ---
>  Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile.am b/Makefile.am
> index a5b347b..796f0d0 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -10,3 +10,4 @@ pkgconfigdir = $(libdir)/pkgconfig
>  pkgconfig_DATA = libnetfilter_queue.pc
>  
>  EXTRA_DIST += Make_global.am
> +EXTRA_DIST += fixmanpages.sh

Please, move this script to the 'doxygen' folder.

Thanks.

Re: [PATCH libnetfilter_queue 0/1] URGENT: libnetfilter_queue-1.0.4 fails to build

[Pablo Neira Ayuso]

On Sat, Jun 06, 2020 at 08:08:35AM +0200, Jan Engelhardt wrote:
> On Saturday 2020-06-06 07:25, Duncan Roe wrote:
> 
> >'make' says: No rule to build ../fixmanpages.sh: stop
> >Maybe you can push out a re-release before anyone else notices?
> 
> No to rereleases. That just upsets distros and automated scripts that 
> have already downloaded the file (we're now past 23 hours anyway) and 
> would raise a "their server was hacked" flag because the 
> signatures/checksums no longer match between what's brewing in the 
> distro staging and upstream URL.

I agree a new is the way to go.