All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clay Harris <bugs@claycon.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org
Subject: Re: IORING_OP_CLOSE fails on fd opened with O_PATH
Date: Mon, 8 Jun 2020 20:40:14 -0500	[thread overview]
Message-ID: <20200609014014.6njp6fkjrcwrdqbt@ps29521.dreamhostps.com> (raw)
In-Reply-To: <4e72f006-418d-91bc-1d6f-c15bce360575@kernel.dk>

On Mon, Jun 08 2020 at 14:19:56 -0600, Jens Axboe quoth thus:

> On 6/8/20 5:21 AM, Clay Harris wrote:
> > On Sun, May 31 2020 at 08:46:03 -0600, Jens Axboe quoth thus:
> > 
> >> On 5/31/20 6:47 AM, Clay Harris wrote:
> >>> Tested on kernel 5.6.14
> >>>
> >>> $ ./closetest closetest.c
> >>>
> >>> path closetest.c open on fd 3 with O_RDONLY
> >>>  ---- io_uring close(3)
> >>>  ---- ordinary close(3)
> >>> ordinary close(3) failed, errno 9: Bad file descriptor
> >>>
> >>>
> >>> $ ./closetest closetest.c opath
> >>>
> >>> path closetest.c open on fd 3 with O_PATH
> >>>  ---- io_uring close(3)
> >>> io_uring close() failed, errno 9: Bad file descriptor
> >>>  ---- ordinary close(3)
> >>> ordinary close(3) returned 0
> >>
> >> Can you include the test case, please? Should be an easy fix, but no
> >> point rewriting a test case if I can avoid it...
> > 
> > Sure.  Here's a cleaned-up test program.
> > https://claycon.org/software/io_uring/tests/close_opath.c
> 
> Thanks for sending this - but it's GPL v3, I can't take that. I'll
> probably just add an O_PATH test case to the existing open-close test
> cases.

I didn't realize that would be an issue.
I'll change it.  Would you prefer GPL 2, or should I just delete the
license line altogether?

> -- 
> Jens Axboe

  reply	other threads:[~2020-06-09  1:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-31 12:47 IORING_OP_CLOSE fails on fd opened with O_PATH Clay Harris
2020-05-31 14:46 ` Jens Axboe
2020-05-31 20:19   ` Jens Axboe
2020-06-02 18:22     ` Jann Horn
2020-06-02 18:42       ` Jens Axboe
2020-06-02 19:16         ` Jann Horn
2020-06-02 21:39           ` Jens Axboe
2020-06-08 11:21   ` Clay Harris
2020-06-08 20:19     ` Jens Axboe
2020-06-09  1:40       ` Clay Harris [this message]
2020-06-09  2:14         ` Jens Axboe
2020-06-09  5:16           ` Clay Harris
2020-06-10  1:52             ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200609014014.6njp6fkjrcwrdqbt@ps29521.dreamhostps.com \
    --to=bugs@claycon.org \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.