From: Jens Axboe <axboe@kernel.dk>
To: Clay Harris <bugs@claycon.org>, io-uring@vger.kernel.org
Subject: Re: IORING_OP_CLOSE fails on fd opened with O_PATH
Date: Sun, 31 May 2020 14:19:51 -0600 [thread overview]
Message-ID: <4eaad89b-f6e3-2ff4-af07-f63f7ce35bdc@kernel.dk> (raw)
In-Reply-To: <5d8c06cb-7505-e0c5-a7f4-507e7105ce5e@kernel.dk>
On 5/31/20 8:46 AM, Jens Axboe wrote:
> On 5/31/20 6:47 AM, Clay Harris wrote:
>> Tested on kernel 5.6.14
>>
>> $ ./closetest closetest.c
>>
>> path closetest.c open on fd 3 with O_RDONLY
>> ---- io_uring close(3)
>> ---- ordinary close(3)
>> ordinary close(3) failed, errno 9: Bad file descriptor
>>
>>
>> $ ./closetest closetest.c opath
>>
>> path closetest.c open on fd 3 with O_PATH
>> ---- io_uring close(3)
>> io_uring close() failed, errno 9: Bad file descriptor
>> ---- ordinary close(3)
>> ordinary close(3) returned 0
>
> Can you include the test case, please? Should be an easy fix, but no
> point rewriting a test case if I can avoid it...
We just need this ported to stable once it goes into 5.8-rc:
https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.8/io_uring&id=904fbcb115c85090484dfdffaf7f461d96fe8e53
--
Jens Axboe
next prev parent reply other threads:[~2020-05-31 20:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 12:47 IORING_OP_CLOSE fails on fd opened with O_PATH Clay Harris
2020-05-31 14:46 ` Jens Axboe
2020-05-31 20:19 ` Jens Axboe [this message]
2020-06-02 18:22 ` Jann Horn
2020-06-02 18:42 ` Jens Axboe
2020-06-02 19:16 ` Jann Horn
2020-06-02 21:39 ` Jens Axboe
2020-06-08 11:21 ` Clay Harris
2020-06-08 20:19 ` Jens Axboe
2020-06-09 1:40 ` Clay Harris
2020-06-09 2:14 ` Jens Axboe
2020-06-09 5:16 ` Clay Harris
2020-06-10 1:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4eaad89b-f6e3-2ff4-af07-f63f7ce35bdc@kernel.dk \
--to=axboe@kernel.dk \
--cc=bugs@claycon.org \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.