* [PATCH 0/1] selftests for drivers/fpga
@ 2020-06-09 13:02 trix
2020-06-09 13:02 ` [PATCH 1/1] selftests: fpga: dfl: A test for afu interrupt support trix
0 siblings, 1 reply; 5+ messages in thread
From: trix @ 2020-06-09 13:02 UTC (permalink / raw)
To: linux-fpga, shuah; +Cc: linux-kernel, linux-kselftest, Tom Rix
From: Tom Rix <trix@redhat.com>
repo : linux-next
tag : next-20200608
Start applying selftests to drivers/fpga.
While testing out this upcoming change on linux-fpga
'Add interrupt support to FPGA DFL drivers'
I did not see any existing fpga tests.
So I added one.
Tom Rix (1):
selftests: fpga: dfl: A test for afu interrupt support
tools/testing/selftests/Makefile | 1 +
tools/testing/selftests/drivers/fpga/Makefile | 9 +++++
.../testing/selftests/drivers/fpga/afu_intr.c | 38 +++++++++++++++++++
tools/testing/selftests/drivers/fpga/config | 1 +
4 files changed, 49 insertions(+)
create mode 100644 tools/testing/selftests/drivers/fpga/Makefile
create mode 100644 tools/testing/selftests/drivers/fpga/afu_intr.c
create mode 100644 tools/testing/selftests/drivers/fpga/config
--
2.18.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] selftests: fpga: dfl: A test for afu interrupt support
2020-06-09 13:02 [PATCH 0/1] selftests for drivers/fpga trix
@ 2020-06-09 13:02 ` trix
2020-06-09 14:20 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: trix @ 2020-06-09 13:02 UTC (permalink / raw)
To: linux-fpga, shuah; +Cc: linux-kernel, linux-kselftest, Tom Rix
From: Tom Rix <trix@redhat.com>
Check that the ioctl DFL_FPGA_PORT_ERR_GET_IRQ_NUM returns
an expected result.
Tested on vf device 0xbcc1
Sample run with
$ sudo make -C tools/testing/selftests TARGETS=drivers/fpga run_tests
...
ok 1 selftests: drivers/fpga: afu_intr
Signed-off-by: Tom Rix <trix@redhat.com>
---
tools/testing/selftests/Makefile | 1 +
tools/testing/selftests/drivers/fpga/Makefile | 9 +++++
.../testing/selftests/drivers/fpga/afu_intr.c | 38 +++++++++++++++++++
tools/testing/selftests/drivers/fpga/config | 1 +
4 files changed, 49 insertions(+)
create mode 100644 tools/testing/selftests/drivers/fpga/Makefile
create mode 100644 tools/testing/selftests/drivers/fpga/afu_intr.c
create mode 100644 tools/testing/selftests/drivers/fpga/config
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 1195bd85af38..4c6eda659125 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -9,6 +9,7 @@ TARGETS += clone3
TARGETS += cpufreq
TARGETS += cpu-hotplug
TARGETS += drivers/dma-buf
+TARGETS += drivers/fpga
TARGETS += efivarfs
TARGETS += exec
TARGETS += filesystems
diff --git a/tools/testing/selftests/drivers/fpga/Makefile b/tools/testing/selftests/drivers/fpga/Makefile
new file mode 100644
index 000000000000..0a472e8c67c5
--- /dev/null
+++ b/tools/testing/selftests/drivers/fpga/Makefile
@@ -0,0 +1,9 @@
+# SPDX-License-Identifier: GPL-2.0-only
+CFLAGS += -I../../../../../usr/include/
+CFLAGS += -I../../../../../include/uapi/
+
+TEST_GEN_PROGS := afu_intr
+
+top_srcdir ?=../../../../..
+
+include ../../lib.mk
diff --git a/tools/testing/selftests/drivers/fpga/afu_intr.c b/tools/testing/selftests/drivers/fpga/afu_intr.c
new file mode 100644
index 000000000000..aa1efba94605
--- /dev/null
+++ b/tools/testing/selftests/drivers/fpga/afu_intr.c
@@ -0,0 +1,38 @@
+// SPDX-License-Identifier: GPL-2.0
+#include <stdio.h>
+#include <stdlib.h>
+#include <stdint.h>
+#include <string.h>
+#include <linux/fcntl.h>
+#include <linux/fpga-dfl.h>
+
+#define TEST_PREFIX "drivers/fpga/afu_intr"
+
+int main(int argc, char *argv[])
+{
+ int devfd, status;
+ struct dfl_fpga_port_info port_info;
+ uint32_t irq_num;
+
+ devfd = open("/dev/dfl-port.0", O_RDONLY);
+ if (devfd < 0) {
+ printf("%s: [skip,no-ufpgaintr]\n", TEST_PREFIX);
+ exit(77);
+ }
+
+ /*
+ * From fpga-dl.h :
+ * Currently hardware supports up to 1 irq.
+ * Return: 0 on success, -errno on failure.
+ */
+ irq_num = -1;
+ status = ioctl(devfd, DFL_FPGA_PORT_ERR_GET_IRQ_NUM, &irq_num);
+ if (status != 0 || irq_num > 255) {
+ printf("%s: [FAIL,err-get-irq-num]\n", TEST_PREFIX);
+ close(devfd);
+ exit(1);
+ }
+
+ close(devfd);
+ return 0;
+}
diff --git a/tools/testing/selftests/drivers/fpga/config b/tools/testing/selftests/drivers/fpga/config
new file mode 100644
index 000000000000..e2111b81d8d7
--- /dev/null
+++ b/tools/testing/selftests/drivers/fpga/config
@@ -0,0 +1 @@
+CONFIG_FPGA_DFL_AFU=m
--
2.18.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] selftests: fpga: dfl: A test for afu interrupt support
2020-06-09 13:02 ` [PATCH 1/1] selftests: fpga: dfl: A test for afu interrupt support trix
@ 2020-06-09 14:20 ` Greg KH
2020-06-09 14:45 ` Tom Rix
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2020-06-09 14:20 UTC (permalink / raw)
To: trix; +Cc: stable, linux-fpga, shuah, linux-kernel, linux-kselftest
On Tue, Jun 09, 2020 at 06:02:08AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Check that the ioctl DFL_FPGA_PORT_ERR_GET_IRQ_NUM returns
> an expected result.
>
> Tested on vf device 0xbcc1
>
> Sample run with
> $ sudo make -C tools/testing/selftests TARGETS=drivers/fpga run_tests
> ...
> ok 1 selftests: drivers/fpga: afu_intr
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> tools/testing/selftests/Makefile | 1 +
> tools/testing/selftests/drivers/fpga/Makefile | 9 +++++
> .../testing/selftests/drivers/fpga/afu_intr.c | 38 +++++++++++++++++++
> tools/testing/selftests/drivers/fpga/config | 1 +
> 4 files changed, 49 insertions(+)
> create mode 100644 tools/testing/selftests/drivers/fpga/Makefile
> create mode 100644 tools/testing/selftests/drivers/fpga/afu_intr.c
> create mode 100644 tools/testing/selftests/drivers/fpga/config
>
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 1195bd85af38..4c6eda659125 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -9,6 +9,7 @@ TARGETS += clone3
> TARGETS += cpufreq
> TARGETS += cpu-hotplug
> TARGETS += drivers/dma-buf
> +TARGETS += drivers/fpga
> TARGETS += efivarfs
> TARGETS += exec
> TARGETS += filesystems
> diff --git a/tools/testing/selftests/drivers/fpga/Makefile b/tools/testing/selftests/drivers/fpga/Makefile
> new file mode 100644
> index 000000000000..0a472e8c67c5
> --- /dev/null
> +++ b/tools/testing/selftests/drivers/fpga/Makefile
> @@ -0,0 +1,9 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +CFLAGS += -I../../../../../usr/include/
> +CFLAGS += -I../../../../../include/uapi/
> +
> +TEST_GEN_PROGS := afu_intr
> +
> +top_srcdir ?=../../../../..
> +
> +include ../../lib.mk
> diff --git a/tools/testing/selftests/drivers/fpga/afu_intr.c b/tools/testing/selftests/drivers/fpga/afu_intr.c
> new file mode 100644
> index 000000000000..aa1efba94605
> --- /dev/null
> +++ b/tools/testing/selftests/drivers/fpga/afu_intr.c
> @@ -0,0 +1,38 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <stdint.h>
> +#include <string.h>
> +#include <linux/fcntl.h>
> +#include <linux/fpga-dfl.h>
> +
> +#define TEST_PREFIX "drivers/fpga/afu_intr"
> +
> +int main(int argc, char *argv[])
> +{
> + int devfd, status;
> + struct dfl_fpga_port_info port_info;
> + uint32_t irq_num;
> +
> + devfd = open("/dev/dfl-port.0", O_RDONLY);
> + if (devfd < 0) {
> + printf("%s: [skip,no-ufpgaintr]\n", TEST_PREFIX);
> + exit(77);
> + }
> +
> + /*
> + * From fpga-dl.h :
> + * Currently hardware supports up to 1 irq.
> + * Return: 0 on success, -errno on failure.
> + */
> + irq_num = -1;
> + status = ioctl(devfd, DFL_FPGA_PORT_ERR_GET_IRQ_NUM, &irq_num);
> + if (status != 0 || irq_num > 255) {
> + printf("%s: [FAIL,err-get-irq-num]\n", TEST_PREFIX);
> + close(devfd);
> + exit(1);
> + }
> +
> + close(devfd);
> + return 0;
> +}
Why not use the ksft_* functions and frameworks to properly print out
the test status and results so that tools can correctly parse it?
It's generally bad-form to make up your own format.
thanks,
gre gk-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] selftests: fpga: dfl: A test for afu interrupt support
2020-06-09 14:20 ` Greg KH
@ 2020-06-09 14:45 ` Tom Rix
2020-06-09 15:01 ` Shuah Khan
0 siblings, 1 reply; 5+ messages in thread
From: Tom Rix @ 2020-06-09 14:45 UTC (permalink / raw)
To: Greg KH; +Cc: stable, linux-fpga, shuah, linux-kernel, linux-kselftest
> Why not use the ksft_* functions and frameworks to properly print out
> the test status and results so that tools can correctly parse it?
>
> It's generally bad-form to make up your own format.
I used the the drivers/dma-buf test a basis example. Can you point me at a better example ?
T
> thanks,
>
> gre gk-h
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] selftests: fpga: dfl: A test for afu interrupt support
2020-06-09 14:45 ` Tom Rix
@ 2020-06-09 15:01 ` Shuah Khan
0 siblings, 0 replies; 5+ messages in thread
From: Shuah Khan @ 2020-06-09 15:01 UTC (permalink / raw)
To: Tom Rix, Greg KH
Cc: stable, linux-fpga, shuah, linux-kernel, linux-kselftest, Shuah Khan
On 6/9/20 8:45 AM, Tom Rix wrote:
>
>> Why not use the ksft_* functions and frameworks to properly print out
>> the test status and results so that tools can correctly parse it?
>>
>> It's generally bad-form to make up your own format.
>
> I used the the drivers/dma-buf test a basis example. Can you point me at a better example ?
>
A few examples to choose from as a reference:
tools/testing/selftests/breakpoints
tools/testing/selftests/timens
Please reach out to me if you have any questions.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-09 15:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-09 13:02 [PATCH 0/1] selftests for drivers/fpga trix
2020-06-09 13:02 ` [PATCH 1/1] selftests: fpga: dfl: A test for afu interrupt support trix
2020-06-09 14:20 ` Greg KH
2020-06-09 14:45 ` Tom Rix
2020-06-09 15:01 ` Shuah Khan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.