All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/2] iommu: Move Intel and AMD drivers into their own subdirectory
@ 2020-06-09 13:03 ` Joerg Roedel
  0 siblings, 0 replies; 13+ messages in thread
From: Joerg Roedel @ 2020-06-09 13:03 UTC (permalink / raw)
  To: Joerg Roedel
  Cc: David Woodhouse, Lu Baolu, Suravee Suthikulpanit,
	Jerry Snitselaar, Qian Cai, iommu, linux-kernel

Hi,

here is the updated version of the changes to move the Intel and AMD
IOMMU drivers into their own subdirectories. This time with updated
MAINTAINERS file entries.

Regards,

	Joerg

Joerg Roedel (2):
  iommu/amd: Move AMD IOMMU driver into subdirectory
  iommu/vt-d: Move Intel IOMMU driver into subdirectory

 MAINTAINERS                                    |  5 ++---
 drivers/iommu/Makefile                         | 18 +++++++++---------
 drivers/iommu/{ => amd}/amd_iommu.h            |  0
 drivers/iommu/{ => amd}/amd_iommu_types.h      |  0
 .../{amd_iommu_debugfs.c => amd/debugfs.c}     |  0
 drivers/iommu/{amd_iommu_init.c => amd/init.c} |  2 +-
 drivers/iommu/{amd_iommu.c => amd/iommu.c}     |  2 +-
 .../iommu/{amd_iommu_v2.c => amd/iommu_v2.c}   |  0
 .../iommu/{amd_iommu_quirks.c => amd/quirks.c} |  0
 .../{intel-iommu-debugfs.c => intel/debugfs.c} |  0
 drivers/iommu/{ => intel}/dmar.c               |  2 +-
 drivers/iommu/{ => intel}/intel-pasid.h        |  0
 drivers/iommu/{intel-iommu.c => intel/iommu.c} |  2 +-
 .../irq_remapping.c}                           |  2 +-
 drivers/iommu/{intel-pasid.c => intel/pasid.c} |  0
 drivers/iommu/{intel-svm.c => intel/svm.c}     |  0
 drivers/iommu/{intel-trace.c => intel/trace.c} |  0
 17 files changed, 16 insertions(+), 17 deletions(-)
 rename drivers/iommu/{ => amd}/amd_iommu.h (100%)
 rename drivers/iommu/{ => amd}/amd_iommu_types.h (100%)
 rename drivers/iommu/{amd_iommu_debugfs.c => amd/debugfs.c} (100%)
 rename drivers/iommu/{amd_iommu_init.c => amd/init.c} (99%)
 rename drivers/iommu/{amd_iommu.c => amd/iommu.c} (99%)
 rename drivers/iommu/{amd_iommu_v2.c => amd/iommu_v2.c} (100%)
 rename drivers/iommu/{amd_iommu_quirks.c => amd/quirks.c} (100%)
 rename drivers/iommu/{intel-iommu-debugfs.c => intel/debugfs.c} (100%)
 rename drivers/iommu/{ => intel}/dmar.c (99%)
 rename drivers/iommu/{ => intel}/intel-pasid.h (100%)
 rename drivers/iommu/{intel-iommu.c => intel/iommu.c} (99%)
 rename drivers/iommu/{intel_irq_remapping.c => intel/irq_remapping.c} (99%)
 rename drivers/iommu/{intel-pasid.c => intel/pasid.c} (100%)
 rename drivers/iommu/{intel-svm.c => intel/svm.c} (100%)
 rename drivers/iommu/{intel-trace.c => intel/trace.c} (100%)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] iommu/vt-d: Move Intel IOMMU driver into subdirectory
@ 2020-06-09 19:47 kernel test robot
  0 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2020-06-09 19:47 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 5855 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20200609130303.26974-3-joro@8bytes.org>
References: <20200609130303.26974-3-joro@8bytes.org>
TO: Joerg Roedel <joro@8bytes.org>
TO: Joerg Roedel <joro@8bytes.org>
CC: David Woodhouse <dwmw2@infradead.org>
CC: Lu Baolu <baolu.lu@linux.intel.com>
CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
CC: Jerry Snitselaar <jsnitsel@redhat.com>
CC: Qian Cai <cai@lca.pw>
CC: iommu(a)lists.linux-foundation.org
CC: linux-kernel(a)vger.kernel.org

Hi Joerg,

I love your patch! Perhaps something to improve:

[auto build test WARNING on iommu/next]
[also build test WARNING on linus/master next-20200609]
[cannot apply to v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Joerg-Roedel/iommu-Move-Intel-and-AMD-drivers-into-their-own-subdirectory/20200609-210928
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
config: x86_64-randconfig-m001-20200607 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/iommu/intel/dmar.c:1506 dmar_disable_qi() warn: this loop depends on readl() succeeding
drivers/iommu/intel/dmar.c:1506 dmar_disable_qi() warn: this loop depends on readl() succeeding
drivers/iommu/intel/dmar.c:1872 dmar_fault() warn: this loop depends on readl() succeeding

# https://github.com/0day-ci/linux/commit/041c469cc1967ad678c6b5acfbf76f4238fa5796
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 041c469cc1967ad678c6b5acfbf76f4238fa5796
vim +1506 drivers/iommu/intel/dmar.c

61a06a16e36d83 drivers/iommu/dmar.c Jacob Pan       2020-05-16  1476  
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1477  /*
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1478   * Disable Queued Invalidation interface.
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1479   */
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1480  void dmar_disable_qi(struct intel_iommu *iommu)
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1481  {
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1482  	unsigned long flags;
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1483  	u32 sts;
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1484  	cycles_t start_time = get_cycles();
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1485  
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1486  	if (!ecap_qis(iommu->ecap))
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1487  		return;
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1488  
1f5b3c3fd2d73d drivers/iommu/dmar.c Thomas Gleixner 2011-07-19  1489  	raw_spin_lock_irqsave(&iommu->register_lock, flags);
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1490  
fda3bec12d0979 drivers/iommu/dmar.c CQ Tang         2016-01-13  1491  	sts =  readl(iommu->reg + DMAR_GSTS_REG);
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1492  	if (!(sts & DMA_GSTS_QIES))
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1493  		goto end;
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1494  
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1495  	/*
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1496  	 * Give a chance to HW to complete the pending invalidation requests.
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1497  	 */
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1498  	while ((readl(iommu->reg + DMAR_IQT_REG) !=
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1499  		readl(iommu->reg + DMAR_IQH_REG)) &&
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1500  		(DMAR_OPERATION_TIMEOUT > (get_cycles() - start_time)))
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1501  		cpu_relax();
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1502  
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1503  	iommu->gcmd &= ~DMA_GCMD_QIE;
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1504  	writel(iommu->gcmd, iommu->reg + DMAR_GCMD_REG);
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1505  
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16 @1506  	IOMMU_WAIT_OP(iommu, DMAR_GSTS_REG, readl,
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1507  		      !(sts & DMA_GSTS_QIES), sts);
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1508  end:
1f5b3c3fd2d73d drivers/iommu/dmar.c Thomas Gleixner 2011-07-19  1509  	raw_spin_unlock_irqrestore(&iommu->register_lock, flags);
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1510  }
eba67e5da6e971 drivers/pci/dmar.c   Suresh Siddha   2009-03-16  1511  

:::::: The code at line 1506 was first introduced by commit
:::::: eba67e5da6e971993b2899d2cdf459ce77d3dbc5 x86, dmar: routines for disabling queued invalidation and intr remapping

:::::: TO: Suresh Siddha <suresh.b.siddha@intel.com>
:::::: CC: H. Peter Anvin <hpa@linux.intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36700 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] iommu/vt-d: Move Intel IOMMU driver into subdirectory
@ 2020-06-10  3:38 kernel test robot
  0 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2020-06-10  3:38 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2070 bytes --]

In-Reply-To: <20200609130303.26974-3-joro@8bytes.org>
References: <20200609130303.26974-3-joro@8bytes.org>
TO: Joerg Roedel <joro@8bytes.org>
TO: Joerg Roedel <joro@8bytes.org>
CC: David Woodhouse <dwmw2@infradead.org>
CC: Lu Baolu <baolu.lu@linux.intel.com>
CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
CC: Jerry Snitselaar <jsnitsel@redhat.com>
CC: Qian Cai <cai@lca.pw>
CC: iommu(a)lists.linux-foundation.org
CC: linux-kernel(a)vger.kernel.org

Hi Joerg,

I love your patch! Perhaps something to improve:

[auto build test WARNING on iommu/next]
[cannot apply to v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Joerg-Roedel/iommu-Move-Intel-and-AMD-drivers-into-their-own-subdirectory/20200609-210928
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: x86_64-randconfig-a016-20200607 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project bc2b70982be8f5250cd0082a7190f8b417bd4dfe)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/iommu/intel/dmar.o: warning: objtool: dmar_disable_qi()+0x11a: unreachable instruction

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32751 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2020-06-10  3:38 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-09 13:03 [PATCH v2 0/2] iommu: Move Intel and AMD drivers into their own subdirectory Joerg Roedel
2020-06-09 13:03 ` Joerg Roedel
2020-06-09 13:03 ` [PATCH v2 1/2] iommu/amd: Move AMD IOMMU driver into subdirectory Joerg Roedel
2020-06-09 13:03   ` Joerg Roedel
2020-06-10  1:25   ` kernel test robot
2020-06-10  1:25     ` kernel test robot
2020-06-10  1:25     ` kernel test robot
2020-06-09 13:03 ` [PATCH v2 2/2] iommu/vt-d: Move Intel " Joerg Roedel
2020-06-09 13:03   ` Joerg Roedel
2020-06-10  2:09   ` Lu Baolu
2020-06-10  2:09     ` Lu Baolu
2020-06-09 19:47 kernel test robot
2020-06-10  3:38 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.