All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] env: Kconfig: cosmetics: update comment for SYS_RELOC_GD_ENV_ADDR
@ 2020-06-10 17:28 Patrick Delaunay
  2020-06-10 18:11 ` Tom Rini
  2020-06-15 19:56 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Patrick Delaunay @ 2020-06-10 17:28 UTC (permalink / raw)
  To: u-boot

Update the comment for SYS_RELOC_GD_ENV_ADDR as gd->env_addr is updated
in board_r.c::initr_reloc_global_data() under the compilation flags
CONFIG_SYS_RELOC_GD_ENV_ADDR

Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---

The current code in board_r.c is:

static int initr_reloc_global_data(void)
{
....
#ifdef CONFIG_SYS_RELOC_GD_ENV_ADDR
        /*
         * Relocate the early env_addr pointer unless we know it is not inside
         * the binary. Some systems need this and for the rest, it doesn't hurt.
         */
        gd->env_addr += gd->reloc_off;
#endif
...


 env/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/env/Kconfig b/env/Kconfig
index ca7fef682b..38e7fadbb9 100644
--- a/env/Kconfig
+++ b/env/Kconfig
@@ -562,7 +562,7 @@ config ENV_UBI_VID_OFFSET
 	  UBI VID offset for environment. If 0, no custom VID offset is used.
 
 config SYS_RELOC_GD_ENV_ADDR
-	bool "Relocate gd->en_addr"
+	bool "Relocate gd->env_addr"
 	help
 	  Relocate the early env_addr pointer so we know it is not inside
 	  the binary. Some systems need this and for the rest, it doesn't hurt.
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] env: Kconfig: cosmetics: update comment for SYS_RELOC_GD_ENV_ADDR
  2020-06-10 17:28 [PATCH] env: Kconfig: cosmetics: update comment for SYS_RELOC_GD_ENV_ADDR Patrick Delaunay
@ 2020-06-10 18:11 ` Tom Rini
  2020-06-15 19:56 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2020-06-10 18:11 UTC (permalink / raw)
  To: u-boot

On Wed, Jun 10, 2020 at 07:28:42PM +0200, Patrick Delaunay wrote:

> Update the comment for SYS_RELOC_GD_ENV_ADDR as gd->env_addr is updated
> in board_r.c::initr_reloc_global_data() under the compilation flags
> CONFIG_SYS_RELOC_GD_ENV_ADDR
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>

Pretty sure that's just a typo I introduced, thanks for digging at the
code to confirm.

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200610/f58f88a4/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] env: Kconfig: cosmetics: update comment for SYS_RELOC_GD_ENV_ADDR
  2020-06-10 17:28 [PATCH] env: Kconfig: cosmetics: update comment for SYS_RELOC_GD_ENV_ADDR Patrick Delaunay
  2020-06-10 18:11 ` Tom Rini
@ 2020-06-15 19:56 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2020-06-15 19:56 UTC (permalink / raw)
  To: u-boot

On Wed, Jun 10, 2020 at 07:28:42PM +0200, Patrick Delaunay wrote:

> Update the comment for SYS_RELOC_GD_ENV_ADDR as gd->env_addr is updated
> in board_r.c::initr_reloc_global_data() under the compilation flags
> CONFIG_SYS_RELOC_GD_ENV_ADDR
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200615/984296be/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-06-15 19:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-10 17:28 [PATCH] env: Kconfig: cosmetics: update comment for SYS_RELOC_GD_ENV_ADDR Patrick Delaunay
2020-06-10 18:11 ` Tom Rini
2020-06-15 19:56 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.