* [hch-block:blk_mq_complete 15/17] drivers/s390/block/dasd.c:2809:1: error: expected identifier or '(' before '}' token
@ 2020-06-10 16:36 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2020-06-10 16:36 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 5779 bytes --]
tree: git://git.infradead.org/users/hch/block.git blk_mq_complete
head: a0ad6ee43045c2abd0f6cc9a91be06e5ff551a8f
commit: c9b28e546368fc34fb641f41d7fcd18307b125b3 [15/17] blk-mq: move failure injection out of blk_mq_complete_request
config: s390-defconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout c9b28e546368fc34fb641f41d7fcd18307b125b3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/s390/block/dasd.c:2809:1: error: expected identifier or '(' before '}' token
2809 | }
| ^
vim +2809 drivers/s390/block/dasd.c
8e09f21574ea30 Stefan Weinhuber 2008-01-26 2754
8e09f21574ea30 Stefan Weinhuber 2008-01-26 2755 static void __dasd_cleanup_cqr(struct dasd_ccw_req *cqr)
8e09f21574ea30 Stefan Weinhuber 2008-01-26 2756 {
8e09f21574ea30 Stefan Weinhuber 2008-01-26 2757 struct request *req;
2a842acab109f4 Christoph Hellwig 2017-06-03 2758 blk_status_t error = BLK_STS_OK;
5e6bdd37c5526e Stefan Haberland 2020-03-12 2759 unsigned int proc_bytes;
e443343e509aac Stefan Haberland 2017-05-22 2760 int status;
8e09f21574ea30 Stefan Weinhuber 2008-01-26 2761
8e09f21574ea30 Stefan Weinhuber 2008-01-26 2762 req = (struct request *) cqr->callback_data;
8e09f21574ea30 Stefan Weinhuber 2008-01-26 2763 dasd_profile_end(cqr->block, cqr, req);
2a842acab109f4 Christoph Hellwig 2017-06-03 2764
5e6bdd37c5526e Stefan Haberland 2020-03-12 2765 proc_bytes = cqr->proc_bytes;
fe6b8e76d920b9 Stefan Weinhuber 2008-02-05 2766 status = cqr->block->base->discipline->free_cp(cqr, req);
d1ffc1f8660e74 Hannes Reinecke 2013-01-30 2767 if (status < 0)
2a842acab109f4 Christoph Hellwig 2017-06-03 2768 error = errno_to_blk_status(status);
d1ffc1f8660e74 Hannes Reinecke 2013-01-30 2769 else if (status == 0) {
2a842acab109f4 Christoph Hellwig 2017-06-03 2770 switch (cqr->intrc) {
2a842acab109f4 Christoph Hellwig 2017-06-03 2771 case -EPERM:
2a842acab109f4 Christoph Hellwig 2017-06-03 2772 error = BLK_STS_NEXUS;
2a842acab109f4 Christoph Hellwig 2017-06-03 2773 break;
2a842acab109f4 Christoph Hellwig 2017-06-03 2774 case -ENOLINK:
2a842acab109f4 Christoph Hellwig 2017-06-03 2775 error = BLK_STS_TRANSPORT;
2a842acab109f4 Christoph Hellwig 2017-06-03 2776 break;
2a842acab109f4 Christoph Hellwig 2017-06-03 2777 case -ETIMEDOUT:
2a842acab109f4 Christoph Hellwig 2017-06-03 2778 error = BLK_STS_TIMEOUT;
2a842acab109f4 Christoph Hellwig 2017-06-03 2779 break;
2a842acab109f4 Christoph Hellwig 2017-06-03 2780 default:
2a842acab109f4 Christoph Hellwig 2017-06-03 2781 error = BLK_STS_IOERR;
2a842acab109f4 Christoph Hellwig 2017-06-03 2782 break;
2a842acab109f4 Christoph Hellwig 2017-06-03 2783 }
d1ffc1f8660e74 Hannes Reinecke 2013-01-30 2784 }
e443343e509aac Stefan Haberland 2017-05-22 2785
e443343e509aac Stefan Haberland 2017-05-22 2786 /*
e443343e509aac Stefan Haberland 2017-05-22 2787 * We need to take care for ETIMEDOUT errors here since the
e443343e509aac Stefan Haberland 2017-05-22 2788 * complete callback does not get called in this case.
e443343e509aac Stefan Haberland 2017-05-22 2789 * Take care of all errors here and avoid additional code to
e443343e509aac Stefan Haberland 2017-05-22 2790 * transfer the error value to the complete callback.
e443343e509aac Stefan Haberland 2017-05-22 2791 */
e443343e509aac Stefan Haberland 2017-05-22 2792 if (error) {
e443343e509aac Stefan Haberland 2017-05-22 2793 blk_mq_end_request(req, error);
e443343e509aac Stefan Haberland 2017-05-22 2794 blk_mq_run_hw_queues(req->q, true);
5e6bdd37c5526e Stefan Haberland 2020-03-12 2795 } else {
5e6bdd37c5526e Stefan Haberland 2020-03-12 2796 /*
5e6bdd37c5526e Stefan Haberland 2020-03-12 2797 * Partial completed requests can happen with ESE devices.
5e6bdd37c5526e Stefan Haberland 2020-03-12 2798 * During read we might have gotten a NRF error and have to
5e6bdd37c5526e Stefan Haberland 2020-03-12 2799 * complete a request partially.
5e6bdd37c5526e Stefan Haberland 2020-03-12 2800 */
5e6bdd37c5526e Stefan Haberland 2020-03-12 2801 if (proc_bytes) {
5e6bdd37c5526e Stefan Haberland 2020-03-12 2802 blk_update_request(req, BLK_STS_OK,
5e6bdd37c5526e Stefan Haberland 2020-03-12 2803 blk_rq_bytes(req) - proc_bytes);
5e6bdd37c5526e Stefan Haberland 2020-03-12 2804 blk_mq_requeue_request(req, true);
c9b28e546368fc Christoph Hellwig 2020-06-10 2805 } else if (likely(!blk_should_fake_timeout(req->q)))
e443343e509aac Stefan Haberland 2017-05-22 2806 blk_mq_complete_request(req);
e443343e509aac Stefan Haberland 2017-05-22 2807 }
8e09f21574ea30 Stefan Weinhuber 2008-01-26 2808 }
5e6bdd37c5526e Stefan Haberland 2020-03-12 @2809 }
8e09f21574ea30 Stefan Weinhuber 2008-01-26 2810
:::::: The code at line 2809 was first introduced by commit
:::::: 5e6bdd37c5526ef01326df5dabb93011ee89237e s390/dasd: fix data corruption for thin provisioned devices
:::::: TO: Stefan Haberland <sth@linux.ibm.com>
:::::: CC: Jens Axboe <axboe@kernel.dk>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 19372 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-10 16:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-10 16:36 [hch-block:blk_mq_complete 15/17] drivers/s390/block/dasd.c:2809:1: error: expected identifier or '(' before '}' token kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.