All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Desaulniers <ndesaulniers@google.com>
To: patch-notifications@ellerman.id.au, christophe.leroy@c-s.fr,
	segher@kernel.crashing.org
Cc: benh@kernel.crashing.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com,
	paulus@samba.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH v4 1/2] powerpc/uaccess: Implement unsafe_put_user() using 'asm goto'
Date: Thu, 11 Jun 2020 15:43:55 -0700	[thread overview]
Message-ID: <20200611224355.71174-1-ndesaulniers@google.com> (raw)
In-Reply-To: <49YBKY13Szz9sT4@ozlabs.org>

Hello! It seems this patch broke our ppc32 builds, and we had to
disable them [0]. :(

From what I can tell, though Michael mentioned this was merged on May
29, but our CI of -next was green for ppc32 until June 4, then mainline
went red June 6. So this patch only got 2 days of soak time before the
merge window opened.

A general issue with the -next workflow seems to be that patches get
different amounts of soak time. For higher risk patches like this one,
can I please ask that they be help back a release if close to the merge
window?

Segher, Cristophe, I suspect Clang is missing support for the %L and %U
output templates [1]. I've implemented support for some of these before
in Clang via the documentation at [2], but these seem to be machine
specific? Can you please point me to documentation/unit tests/source for
these so that I can figure out what they should be doing, and look into
implementing them in Clang?

[0] https://github.com/ClangBuiltLinux/continuous-integration/pull/279
[1] https://bugs.llvm.org/show_bug.cgi?id=46186
[2]
https://gcc.gnu.org/onlinedocs/gccint/Output-Template.html#Output-Template

WARNING: multiple messages have this Message-ID (diff)
From: Nick Desaulniers <ndesaulniers@google.com>
To: patch-notifications@ellerman.id.au, christophe.leroy@c-s.fr,
	 segher@kernel.crashing.org
Cc: linux-kernel@vger.kernel.org, npiggin@gmail.com,
	clang-built-linux@googlegroups.com, paulus@samba.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 1/2] powerpc/uaccess: Implement unsafe_put_user() using 'asm goto'
Date: Thu, 11 Jun 2020 15:43:55 -0700	[thread overview]
Message-ID: <20200611224355.71174-1-ndesaulniers@google.com> (raw)
In-Reply-To: <49YBKY13Szz9sT4@ozlabs.org>

Hello! It seems this patch broke our ppc32 builds, and we had to
disable them [0]. :(

From what I can tell, though Michael mentioned this was merged on May
29, but our CI of -next was green for ppc32 until June 4, then mainline
went red June 6. So this patch only got 2 days of soak time before the
merge window opened.

A general issue with the -next workflow seems to be that patches get
different amounts of soak time. For higher risk patches like this one,
can I please ask that they be help back a release if close to the merge
window?

Segher, Cristophe, I suspect Clang is missing support for the %L and %U
output templates [1]. I've implemented support for some of these before
in Clang via the documentation at [2], but these seem to be machine
specific? Can you please point me to documentation/unit tests/source for
these so that I can figure out what they should be doing, and look into
implementing them in Clang?

[0] https://github.com/ClangBuiltLinux/continuous-integration/pull/279
[1] https://bugs.llvm.org/show_bug.cgi?id=46186
[2]
https://gcc.gnu.org/onlinedocs/gccint/Output-Template.html#Output-Template

  reply	other threads:[~2020-06-11 22:44 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17 17:08 [PATCH v4 1/2] powerpc/uaccess: Implement unsafe_put_user() using 'asm goto' Christophe Leroy
2020-04-17 17:08 ` Christophe Leroy
2020-04-17 17:08 ` [PATCH v4 2/2] powerpc/uaccess: Implement unsafe_copy_to_user() as a simple loop Christophe Leroy
2020-04-17 17:08   ` Christophe Leroy
2020-05-29  4:24   ` Michael Ellerman
2020-05-05 14:27 ` [PATCH v4 1/2] powerpc/uaccess: Implement unsafe_put_user() using 'asm goto' Michael Ellerman
2020-05-05 14:27   ` Michael Ellerman
2020-05-05 15:32   ` Segher Boessenkool
2020-05-05 15:32     ` Segher Boessenkool
2020-05-06  0:58     ` Michael Ellerman
2020-05-06  0:58       ` Michael Ellerman
2020-05-06 17:58       ` Segher Boessenkool
2020-05-06 17:58         ` Segher Boessenkool
2020-05-06 18:10         ` Christophe Leroy
2020-05-06 18:10           ` Christophe Leroy
2020-05-06 22:18           ` Segher Boessenkool
2020-05-06 22:18             ` Segher Boessenkool
2020-05-05 15:40   ` Christophe Leroy
2020-05-05 15:40     ` Christophe Leroy
2020-05-05 15:59     ` Segher Boessenkool
2020-05-05 15:59       ` Segher Boessenkool
2020-05-06  1:36       ` Michael Ellerman
2020-05-06  1:36         ` Michael Ellerman
2020-05-06 18:09         ` Segher Boessenkool
2020-05-06 18:09           ` Segher Boessenkool
2020-05-29  4:24 ` Michael Ellerman
2020-06-11 22:43   ` Nick Desaulniers [this message]
2020-06-11 22:43     ` Nick Desaulniers
2020-06-11 23:52     ` Segher Boessenkool
2020-06-11 23:52       ` Segher Boessenkool
2020-06-12 21:33       ` Nick Desaulniers
2020-06-12 21:33         ` Nick Desaulniers
2020-06-13  1:08         ` Segher Boessenkool
2020-06-13  1:08           ` Segher Boessenkool
2020-06-13  6:46         ` Christophe Leroy
2020-06-13  6:46           ` Christophe Leroy
2020-06-13 10:47         ` Michael Ellerman
2020-06-13 10:47           ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200611224355.71174-1-ndesaulniers@google.com \
    --to=ndesaulniers@google.com \
    --cc=benh@kernel.crashing.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=clang-built-linux@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=npiggin@gmail.com \
    --cc=patch-notifications@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.