[ti:ti-linux-5.4.y 2374/7050] drivers/char/hw_random/omap-rng.c:396:3-10: line 396 is redundant because platform_get_irq() already prints an error

[ti:ti-linux-5.4.y 2374/7050] drivers/char/hw_random/omap-rng.c:396:3-10: line 396 is redundant because platform_get_irq() already prints an error

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Keerthy <j-keerthy@ti.com>
CC: Tero Kristo <t-kristo@ti.com>

tree:   git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-5.4.y
head:   134a1b1f8814115e2dd115b67082321bf9e63cc1
commit: 2ebf5f1440b6cee9b00c6f30c710c8dff8c8591f [2374/7050] char: hw_random: Kconfig: For ARCH_K3 add a dependency on SA2UL
:::::: branch date: 6 hours ago
:::::: commit date: 5 months ago
config: arm64-randconfig-c004-20200612 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/char/hw_random/omap-rng.c:396:3-10: line 396 is redundant because platform_get_irq() already prints an error

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30718 bytes --]

[PATCH] char: hw_random: Kconfig: fix platform_get_irq.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1683 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Keerthy <j-keerthy@ti.com>
CC: Tero Kristo <t-kristo@ti.com>
CC: Deepak Saxena <dsaxena@plexity.net>
CC: Matt Mackall <mpm@selenic.com>
CC: Herbert Xu <herbert@gondor.apana.org.au>
CC: Arnd Bergmann <arnd@arndb.de>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: linux-crypto(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/char/hw_random/omap-rng.c:396:3-10: line 396 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: 2ebf5f1440b6 ("char: hw_random: Kconfig: For ARCH_K3 add a dependency on SA2UL")
CC: Keerthy <j-keerthy@ti.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-5.4.y
head:   134a1b1f8814115e2dd115b67082321bf9e63cc1
commit: 2ebf5f1440b6cee9b00c6f30c710c8dff8c8591f [2374/7050] char: hw_random: Kconfig: For ARCH_K3 add a dependency on SA2UL
:::::: branch date: 6 hours ago
:::::: commit date: 5 months ago

Please take the patch only if it's a positive warning. Thanks!

 omap-rng.c |    2 --
 1 file changed, 2 deletions(-)

--- a/drivers/char/hw_random/omap-rng.c
+++ b/drivers/char/hw_random/omap-rng.c
@@ -393,8 +393,6 @@ static int of_get_omap_rng_device_detail
 	    of_device_is_compatible(dev->of_node, "inside-secure,safexcel-eip76")) {
 		irq = platform_get_irq(pdev, 0);
 		if (irq < 0) {
-			dev_err(dev, "%s: error getting IRQ resource - %d\n",
-				__func__, irq);
 			return irq;
 		}