* [dpdk-dev] [PATCH] rte_sched: fix 64-bit support in rate functions
@ 2020-06-15 17:19 Hrvoje Habjanic
2020-06-16 11:52 ` Singh, Jasvinder
0 siblings, 1 reply; 2+ messages in thread
From: Hrvoje Habjanic @ 2020-06-15 17:19 UTC (permalink / raw)
To: Cristian Dumitrescu, Jasvinder Singh; +Cc: dev
Functions rte_sched_subport_config_pipe_profile_table and
pipe_profile_check should also have increased rate
arguments.
Fixes: 68c1f26d4236 (\"sched: support 64-bit values\")
Cc: jasvinder.singh@intel.com
Signed-off-by: Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr>
---
lib/librte_sched/rte_sched.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
index c0983ddda..be822057b 100644
--- a/lib/librte_sched/rte_sched.c
+++ b/lib/librte_sched/rte_sched.c
@@ -304,7 +304,7 @@ rte_sched_port_tc_queue(struct rte_sched_port *port, uint32_t qindex)
static int
pipe_profile_check(struct rte_sched_pipe_params *params,
- uint32_t rate, uint16_t *qsize)
+ uint64_t rate, uint16_t *qsize)
{
uint32_t i;
@@ -624,7 +624,7 @@ rte_sched_pipe_profile_convert(struct rte_sched_subport *subport,
static void
rte_sched_subport_config_pipe_profile_table(struct rte_sched_subport *subport,
- struct rte_sched_subport_params *params, uint32_t rate)
+ struct rte_sched_subport_params *params, uint64_t rate)
{
uint32_t i;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] rte_sched: fix 64-bit support in rate functions
2020-06-15 17:19 [dpdk-dev] [PATCH] rte_sched: fix 64-bit support in rate functions Hrvoje Habjanic
@ 2020-06-16 11:52 ` Singh, Jasvinder
0 siblings, 0 replies; 2+ messages in thread
From: Singh, Jasvinder @ 2020-06-16 11:52 UTC (permalink / raw)
To: Hrvoje Habjanic, Dumitrescu, Cristian; +Cc: dev
> -----Original Message-----
> From: Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr>
> Sent: Monday, June 15, 2020 6:19 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] rte_sched: fix 64-bit support in rate functions
>
> Functions rte_sched_subport_config_pipe_profile_table and
> pipe_profile_check should also have increased rate arguments.
>
> Fixes: 68c1f26d4236 (\"sched: support 64-bit values\")
> Cc: jasvinder.singh@intel.com
>
> Signed-off-by: Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr>
> ---
> lib/librte_sched/rte_sched.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index
> c0983ddda..be822057b 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -304,7 +304,7 @@ rte_sched_port_tc_queue(struct rte_sched_port
> *port, uint32_t qindex)
>
> static int
> pipe_profile_check(struct rte_sched_pipe_params *params,
> - uint32_t rate, uint16_t *qsize)
> + uint64_t rate, uint16_t *qsize)
> {
> uint32_t i;
>
> @@ -624,7 +624,7 @@ rte_sched_pipe_profile_convert(struct
> rte_sched_subport *subport,
>
> static void
> rte_sched_subport_config_pipe_profile_table(struct rte_sched_subport
> *subport,
> - struct rte_sched_subport_params *params, uint32_t rate)
> + struct rte_sched_subport_params *params, uint64_t rate)
> {
> uint32_t i;
>
Hi Hrvoje,
Thanks for sending the patch. Few days ago, similar fix was proposed https://www.mail-archive.com/dev@dpdk.org/msg168579.html
which I acked. I think that patch is not applied on DPDK yet but will happen soon.
Regards,
Jasvinder
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-16 11:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-15 17:19 [dpdk-dev] [PATCH] rte_sched: fix 64-bit support in rate functions Hrvoje Habjanic
2020-06-16 11:52 ` Singh, Jasvinder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.