From: Rob Herring <robh@kernel.org> To: Anson Huang <Anson.Huang@nxp.com> Cc: dmitry.torokhov@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, gnuiyl@gmail.com, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH] dt-bindings: input: Convert imx keypad to json-schema Date: Mon, 15 Jun 2020 11:31:56 -0600 [thread overview] Message-ID: <20200615173156.GA1996893@bogus> (raw) In-Reply-To: <1591253001-6497-1-git-send-email-Anson.Huang@nxp.com> On Thu, Jun 04, 2020 at 02:43:21PM +0800, Anson Huang wrote: > Convert the i.MX KEYPAD binding to DT schema format using json-schema > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > .../devicetree/bindings/input/imx-keypad.txt | 53 ------------- > .../devicetree/bindings/input/imx-keypad.yaml | 89 ++++++++++++++++++++++ > 2 files changed, 89 insertions(+), 53 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/input/imx-keypad.txt > create mode 100644 Documentation/devicetree/bindings/input/imx-keypad.yaml > > diff --git a/Documentation/devicetree/bindings/input/imx-keypad.txt b/Documentation/devicetree/bindings/input/imx-keypad.txt > deleted file mode 100644 > index 2ebaf7d..0000000 > --- a/Documentation/devicetree/bindings/input/imx-keypad.txt > +++ /dev/null > @@ -1,53 +0,0 @@ > -* Freescale i.MX Keypad Port(KPP) device tree bindings > - > -The KPP is designed to interface with a keypad matrix with 2-point contact > -or 3-point contact keys. The KPP is designed to simplify the software task > -of scanning a keypad matrix. The KPP is capable of detecting, debouncing, > -and decoding one or multiple keys pressed simultaneously on a keypad. > - > -Required SoC Specific Properties: > -- compatible: Should be "fsl,<soc>-kpp". > - > -- reg: Physical base address of the KPP and length of memory mapped > - region. > - > -- interrupts: The KPP interrupt number to the CPU(s). > - > -- clocks: The clock provided by the SoC to the KPP. Some SoCs use dummy > -clock(The clock for the KPP is provided by the SoCs automatically). > - > -Required Board Specific Properties: > -- pinctrl-names: The definition can be found at > -pinctrl/pinctrl-bindings.txt. > - > -- pinctrl-0: The definition can be found at > -pinctrl/pinctrl-bindings.txt. > - > -- linux,keymap: The definition can be found at > -bindings/input/matrix-keymap.txt. > - > -Example: > -kpp: kpp@73f94000 { > - compatible = "fsl,imx51-kpp", "fsl,imx21-kpp"; > - reg = <0x73f94000 0x4000>; > - interrupts = <60>; > - clocks = <&clks 0>; > - pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_kpp_1>; > - linux,keymap = <0x00000067 /* KEY_UP */ > - 0x0001006c /* KEY_DOWN */ > - 0x00020072 /* KEY_VOLUMEDOWN */ > - 0x00030066 /* KEY_HOME */ > - 0x0100006a /* KEY_RIGHT */ > - 0x01010069 /* KEY_LEFT */ > - 0x0102001c /* KEY_ENTER */ > - 0x01030073 /* KEY_VOLUMEUP */ > - 0x02000040 /* KEY_F6 */ > - 0x02010042 /* KEY_F8 */ > - 0x02020043 /* KEY_F9 */ > - 0x02030044 /* KEY_F10 */ > - 0x0300003b /* KEY_F1 */ > - 0x0301003c /* KEY_F2 */ > - 0x0302003d /* KEY_F3 */ > - 0x03030074>; /* KEY_POWER */ > -}; > diff --git a/Documentation/devicetree/bindings/input/imx-keypad.yaml b/Documentation/devicetree/bindings/input/imx-keypad.yaml > new file mode 100644 > index 0000000..a1350cd > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/imx-keypad.yaml > @@ -0,0 +1,89 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/imx-keypad.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX Keypad Port(KPP) device tree bindings > + > +maintainers: > + - Liu Ying <gnuiyl@gmail.com> > + > +description: | > + The KPP is designed to interface with a keypad matrix with 2-point contact > + or 3-point contact keys. The KPP is designed to simplify the software task > + of scanning a keypad matrix. The KPP is capable of detecting, debouncing, > + and decoding one or multiple keys pressed simultaneously on a keypad. > + > +properties: > + compatible: > + oneOf: > + - const: fsl,imx21-kpp > + - items: > + - enum: > + - fsl,imx25-kpp > + - fsl,imx27-kpp > + - fsl,imx31-kpp > + - fsl,imx35-kpp > + - fsl,imx51-kpp > + - fsl,imx53-kpp > + - fsl,imx50-kpp > + - fsl,imx6q-kpp > + - fsl,imx6sx-kpp > + - fsl,imx6sl-kpp > + - fsl,imx6sll-kpp > + - fsl,imx6ul-kpp > + - fsl,imx7d-kpp > + - const: fsl,imx21-kpp > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + linux,keymap: > + $ref: '/schemas/types.yaml#/definitions/uint32-array' > + description: | > + An array of packed 1-cell entries containing the equivalent of row, > + column and linux key-code. The 32-bit big endian cell is packed as: > + row << 24 | column << 16 | key-code Can you please convert matrix-keymap.txt to a schema first and then include in here. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - linux,keymap > + > +additionalProperties: false > + > +examples: > + - | > + keypad@73f94000 { > + compatible = "fsl,imx51-kpp", "fsl,imx21-kpp"; > + reg = <0x73f94000 0x4000>; > + interrupts = <60>; > + clocks = <&clks 0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_kpp_1>; > + linux,keymap = <0x00000067 /* KEY_UP */ > + 0x0001006c /* KEY_DOWN */ > + 0x00020072 /* KEY_VOLUMEDOWN */ > + 0x00030066 /* KEY_HOME */ > + 0x0100006a /* KEY_RIGHT */ > + 0x01010069 /* KEY_LEFT */ > + 0x0102001c /* KEY_ENTER */ > + 0x01030073 /* KEY_VOLUMEUP */ > + 0x02000040 /* KEY_F6 */ > + 0x02010042 /* KEY_F8 */ > + 0x02020043 /* KEY_F9 */ > + 0x02030044 /* KEY_F10 */ > + 0x0300003b /* KEY_F1 */ > + 0x0301003c /* KEY_F2 */ > + 0x0302003d /* KEY_F3 */ > + 0x03030074>; /* KEY_POWER */ > + }; > -- > 2.7.4 >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Anson Huang <Anson.Huang@nxp.com> Cc: devicetree@vger.kernel.org, gnuiyl@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, Linux-imx@nxp.com, kernel@pengutronix.de, linux-input@vger.kernel.org, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] dt-bindings: input: Convert imx keypad to json-schema Date: Mon, 15 Jun 2020 11:31:56 -0600 [thread overview] Message-ID: <20200615173156.GA1996893@bogus> (raw) In-Reply-To: <1591253001-6497-1-git-send-email-Anson.Huang@nxp.com> On Thu, Jun 04, 2020 at 02:43:21PM +0800, Anson Huang wrote: > Convert the i.MX KEYPAD binding to DT schema format using json-schema > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > .../devicetree/bindings/input/imx-keypad.txt | 53 ------------- > .../devicetree/bindings/input/imx-keypad.yaml | 89 ++++++++++++++++++++++ > 2 files changed, 89 insertions(+), 53 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/input/imx-keypad.txt > create mode 100644 Documentation/devicetree/bindings/input/imx-keypad.yaml > > diff --git a/Documentation/devicetree/bindings/input/imx-keypad.txt b/Documentation/devicetree/bindings/input/imx-keypad.txt > deleted file mode 100644 > index 2ebaf7d..0000000 > --- a/Documentation/devicetree/bindings/input/imx-keypad.txt > +++ /dev/null > @@ -1,53 +0,0 @@ > -* Freescale i.MX Keypad Port(KPP) device tree bindings > - > -The KPP is designed to interface with a keypad matrix with 2-point contact > -or 3-point contact keys. The KPP is designed to simplify the software task > -of scanning a keypad matrix. The KPP is capable of detecting, debouncing, > -and decoding one or multiple keys pressed simultaneously on a keypad. > - > -Required SoC Specific Properties: > -- compatible: Should be "fsl,<soc>-kpp". > - > -- reg: Physical base address of the KPP and length of memory mapped > - region. > - > -- interrupts: The KPP interrupt number to the CPU(s). > - > -- clocks: The clock provided by the SoC to the KPP. Some SoCs use dummy > -clock(The clock for the KPP is provided by the SoCs automatically). > - > -Required Board Specific Properties: > -- pinctrl-names: The definition can be found at > -pinctrl/pinctrl-bindings.txt. > - > -- pinctrl-0: The definition can be found at > -pinctrl/pinctrl-bindings.txt. > - > -- linux,keymap: The definition can be found at > -bindings/input/matrix-keymap.txt. > - > -Example: > -kpp: kpp@73f94000 { > - compatible = "fsl,imx51-kpp", "fsl,imx21-kpp"; > - reg = <0x73f94000 0x4000>; > - interrupts = <60>; > - clocks = <&clks 0>; > - pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_kpp_1>; > - linux,keymap = <0x00000067 /* KEY_UP */ > - 0x0001006c /* KEY_DOWN */ > - 0x00020072 /* KEY_VOLUMEDOWN */ > - 0x00030066 /* KEY_HOME */ > - 0x0100006a /* KEY_RIGHT */ > - 0x01010069 /* KEY_LEFT */ > - 0x0102001c /* KEY_ENTER */ > - 0x01030073 /* KEY_VOLUMEUP */ > - 0x02000040 /* KEY_F6 */ > - 0x02010042 /* KEY_F8 */ > - 0x02020043 /* KEY_F9 */ > - 0x02030044 /* KEY_F10 */ > - 0x0300003b /* KEY_F1 */ > - 0x0301003c /* KEY_F2 */ > - 0x0302003d /* KEY_F3 */ > - 0x03030074>; /* KEY_POWER */ > -}; > diff --git a/Documentation/devicetree/bindings/input/imx-keypad.yaml b/Documentation/devicetree/bindings/input/imx-keypad.yaml > new file mode 100644 > index 0000000..a1350cd > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/imx-keypad.yaml > @@ -0,0 +1,89 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/imx-keypad.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX Keypad Port(KPP) device tree bindings > + > +maintainers: > + - Liu Ying <gnuiyl@gmail.com> > + > +description: | > + The KPP is designed to interface with a keypad matrix with 2-point contact > + or 3-point contact keys. The KPP is designed to simplify the software task > + of scanning a keypad matrix. The KPP is capable of detecting, debouncing, > + and decoding one or multiple keys pressed simultaneously on a keypad. > + > +properties: > + compatible: > + oneOf: > + - const: fsl,imx21-kpp > + - items: > + - enum: > + - fsl,imx25-kpp > + - fsl,imx27-kpp > + - fsl,imx31-kpp > + - fsl,imx35-kpp > + - fsl,imx51-kpp > + - fsl,imx53-kpp > + - fsl,imx50-kpp > + - fsl,imx6q-kpp > + - fsl,imx6sx-kpp > + - fsl,imx6sl-kpp > + - fsl,imx6sll-kpp > + - fsl,imx6ul-kpp > + - fsl,imx7d-kpp > + - const: fsl,imx21-kpp > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + linux,keymap: > + $ref: '/schemas/types.yaml#/definitions/uint32-array' > + description: | > + An array of packed 1-cell entries containing the equivalent of row, > + column and linux key-code. The 32-bit big endian cell is packed as: > + row << 24 | column << 16 | key-code Can you please convert matrix-keymap.txt to a schema first and then include in here. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - linux,keymap > + > +additionalProperties: false > + > +examples: > + - | > + keypad@73f94000 { > + compatible = "fsl,imx51-kpp", "fsl,imx21-kpp"; > + reg = <0x73f94000 0x4000>; > + interrupts = <60>; > + clocks = <&clks 0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_kpp_1>; > + linux,keymap = <0x00000067 /* KEY_UP */ > + 0x0001006c /* KEY_DOWN */ > + 0x00020072 /* KEY_VOLUMEDOWN */ > + 0x00030066 /* KEY_HOME */ > + 0x0100006a /* KEY_RIGHT */ > + 0x01010069 /* KEY_LEFT */ > + 0x0102001c /* KEY_ENTER */ > + 0x01030073 /* KEY_VOLUMEUP */ > + 0x02000040 /* KEY_F6 */ > + 0x02010042 /* KEY_F8 */ > + 0x02020043 /* KEY_F9 */ > + 0x02030044 /* KEY_F10 */ > + 0x0300003b /* KEY_F1 */ > + 0x0301003c /* KEY_F2 */ > + 0x0302003d /* KEY_F3 */ > + 0x03030074>; /* KEY_POWER */ > + }; > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-15 17:32 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-04 6:43 [PATCH] dt-bindings: input: Convert imx keypad to json-schema Anson Huang 2020-06-04 6:43 ` Anson Huang 2020-06-15 17:31 ` Rob Herring [this message] 2020-06-15 17:31 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200615173156.GA1996893@bogus \ --to=robh@kernel.org \ --cc=Anson.Huang@nxp.com \ --cc=Linux-imx@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.torokhov@gmail.com \ --cc=festevam@gmail.com \ --cc=gnuiyl@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.