* [PATCH] x86/hvm: check against VIOAPIC_LEVEL_TRIG in hvm_gsi_deassert
@ 2020-06-16 10:20 Roger Pau Monne
2020-06-16 10:41 ` Roger Pau Monné
2020-06-16 11:21 ` Jan Beulich
0 siblings, 2 replies; 4+ messages in thread
From: Roger Pau Monne @ 2020-06-16 10:20 UTC (permalink / raw)
To: xen-devel; +Cc: Jan Beulich, Roger Pau Monne
In order to avoid relying on the specific values of
VIOAPIC_{LEVEL/EDGE}_TRIG.
No functional change.
Requested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
xen/arch/x86/hvm/irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c
index 6cbea63f4c..6772aec721 100644
--- a/xen/arch/x86/hvm/irq.c
+++ b/xen/arch/x86/hvm/irq.c
@@ -202,7 +202,7 @@ void hvm_gsi_deassert(struct domain *d, unsigned int gsi)
int trig = vioapic_get_trigger_mode(d, gsi);
struct hvm_irq *hvm_irq = hvm_domain_irq(d);
- if ( trig <= VIOAPIC_EDGE_TRIG || gsi >= hvm_irq->nr_gsis )
+ if ( trig != VIOAPIC_LEVEL_TRIG || gsi >= hvm_irq->nr_gsis )
{
ASSERT(trig == VIOAPIC_EDGE_TRIG && gsi < hvm_irq->nr_gsis);
return;
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/hvm: check against VIOAPIC_LEVEL_TRIG in hvm_gsi_deassert
2020-06-16 10:20 [PATCH] x86/hvm: check against VIOAPIC_LEVEL_TRIG in hvm_gsi_deassert Roger Pau Monne
@ 2020-06-16 10:41 ` Roger Pau Monné
2020-06-16 11:21 ` Jan Beulich
1 sibling, 0 replies; 4+ messages in thread
From: Roger Pau Monné @ 2020-06-16 10:41 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Wei Liu, Jan Beulich
Forgot to add maintainers.
On Tue, Jun 16, 2020 at 12:20:56PM +0200, Roger Pau Monne wrote:
> In order to avoid relying on the specific values of
> VIOAPIC_{LEVEL/EDGE}_TRIG.
>
> No functional change.
>
> Requested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> xen/arch/x86/hvm/irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c
> index 6cbea63f4c..6772aec721 100644
> --- a/xen/arch/x86/hvm/irq.c
> +++ b/xen/arch/x86/hvm/irq.c
> @@ -202,7 +202,7 @@ void hvm_gsi_deassert(struct domain *d, unsigned int gsi)
> int trig = vioapic_get_trigger_mode(d, gsi);
> struct hvm_irq *hvm_irq = hvm_domain_irq(d);
>
> - if ( trig <= VIOAPIC_EDGE_TRIG || gsi >= hvm_irq->nr_gsis )
> + if ( trig != VIOAPIC_LEVEL_TRIG || gsi >= hvm_irq->nr_gsis )
> {
> ASSERT(trig == VIOAPIC_EDGE_TRIG && gsi < hvm_irq->nr_gsis);
> return;
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/hvm: check against VIOAPIC_LEVEL_TRIG in hvm_gsi_deassert
2020-06-16 10:20 [PATCH] x86/hvm: check against VIOAPIC_LEVEL_TRIG in hvm_gsi_deassert Roger Pau Monne
2020-06-16 10:41 ` Roger Pau Monné
@ 2020-06-16 11:21 ` Jan Beulich
2020-06-16 11:50 ` Paul Durrant
1 sibling, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2020-06-16 11:21 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: xen-devel, Paul Durrant, Wei Liu, Andrew Cooper
On 16.06.2020 12:20, Roger Pau Monne wrote:
> In order to avoid relying on the specific values of
> VIOAPIC_{LEVEL/EDGE}_TRIG.
>
> No functional change.
>
> Requested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Since the other patch went in, also Cc-ing Paul for a possible
release ack.
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] x86/hvm: check against VIOAPIC_LEVEL_TRIG in hvm_gsi_deassert
2020-06-16 11:21 ` Jan Beulich
@ 2020-06-16 11:50 ` Paul Durrant
0 siblings, 0 replies; 4+ messages in thread
From: Paul Durrant @ 2020-06-16 11:50 UTC (permalink / raw)
To: 'Jan Beulich', 'Roger Pau Monne'
Cc: xen-devel, 'Wei Liu', 'Andrew Cooper'
> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Sent: 16 June 2020 12:22
> To: Roger Pau Monne <roger.pau@citrix.com>
> Cc: xen-devel@lists.xenproject.org; Wei Liu <wl@xen.org>; Andrew Cooper <andrew.cooper3@citrix.com>;
> Paul Durrant <paul@xen.org>
> Subject: Re: [PATCH] x86/hvm: check against VIOAPIC_LEVEL_TRIG in hvm_gsi_deassert
>
> On 16.06.2020 12:20, Roger Pau Monne wrote:
> > In order to avoid relying on the specific values of
> > VIOAPIC_{LEVEL/EDGE}_TRIG.
> >
> > No functional change.
> >
> > Requested-by: Jan Beulich <jbeulich@suse.com>
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
> Since the other patch went in, also Cc-ing Paul for a possible
> release ack.
>
Sure, it's trivial so...
Release-acked-by: Paul Durrant <paul@xen.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-16 11:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-16 10:20 [PATCH] x86/hvm: check against VIOAPIC_LEVEL_TRIG in hvm_gsi_deassert Roger Pau Monne
2020-06-16 10:41 ` Roger Pau Monné
2020-06-16 11:21 ` Jan Beulich
2020-06-16 11:50 ` Paul Durrant
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.