* [PATCH bpf] tools, bpftool: Add ringbuf map type to map command docs
@ 2020-06-16 11:33 Tobias Klauser
2020-06-16 17:06 ` Andrii Nakryiko
2020-06-17 16:09 ` Daniel Borkmann
0 siblings, 2 replies; 4+ messages in thread
From: Tobias Klauser @ 2020-06-16 11:33 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann; +Cc: Andrii Nakryiko, bpf
Commit c34a06c56df7 ("tools/bpftool: Add ringbuf map to a list of known
map types") added the symbolic "ringbuf" name. Document it in the bpftool
map command docs and usage as well.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
tools/bpf/bpftool/Documentation/bpftool-map.rst | 2 +-
tools/bpf/bpftool/map.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/bpf/bpftool/Documentation/bpftool-map.rst b/tools/bpf/bpftool/Documentation/bpftool-map.rst
index 31101643e57c..70c78faa47ab 100644
--- a/tools/bpf/bpftool/Documentation/bpftool-map.rst
+++ b/tools/bpf/bpftool/Documentation/bpftool-map.rst
@@ -49,7 +49,7 @@ MAP COMMANDS
| | **lru_percpu_hash** | **lpm_trie** | **array_of_maps** | **hash_of_maps**
| | **devmap** | **devmap_hash** | **sockmap** | **cpumap** | **xskmap** | **sockhash**
| | **cgroup_storage** | **reuseport_sockarray** | **percpu_cgroup_storage**
-| | **queue** | **stack** | **sk_storage** | **struct_ops** }
+| | **queue** | **stack** | **sk_storage** | **struct_ops** | **ringbuf** }
DESCRIPTION
===========
diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
index 99109a6afe17..1d3b60651078 100644
--- a/tools/bpf/bpftool/map.c
+++ b/tools/bpf/bpftool/map.c
@@ -1591,7 +1591,7 @@ static int do_help(int argc, char **argv)
" lru_percpu_hash | lpm_trie | array_of_maps | hash_of_maps |\n"
" devmap | devmap_hash | sockmap | cpumap | xskmap | sockhash |\n"
" cgroup_storage | reuseport_sockarray | percpu_cgroup_storage |\n"
- " queue | stack | sk_storage | struct_ops }\n"
+ " queue | stack | sk_storage | struct_ops | ringbuf }\n"
" " HELP_SPEC_OPTIONS "\n"
"",
bin_name, argv[-2]);
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH bpf] tools, bpftool: Add ringbuf map type to map command docs
2020-06-16 11:33 [PATCH bpf] tools, bpftool: Add ringbuf map type to map command docs Tobias Klauser
@ 2020-06-16 17:06 ` Andrii Nakryiko
2020-06-17 5:56 ` John Fastabend
2020-06-17 16:09 ` Daniel Borkmann
1 sibling, 1 reply; 4+ messages in thread
From: Andrii Nakryiko @ 2020-06-16 17:06 UTC (permalink / raw)
To: Tobias Klauser; +Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, bpf
On Tue, Jun 16, 2020 at 4:34 AM Tobias Klauser <tklauser@distanz.ch> wrote:
>
> Commit c34a06c56df7 ("tools/bpftool: Add ringbuf map to a list of known
> map types") added the symbolic "ringbuf" name. Document it in the bpftool
> map command docs and usage as well.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
Thanks!
Acked-by: Andrii Nakryiko <andriin@fb.com>
> tools/bpf/bpftool/Documentation/bpftool-map.rst | 2 +-
> tools/bpf/bpftool/map.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
[...]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf] tools, bpftool: Add ringbuf map type to map command docs
2020-06-16 17:06 ` Andrii Nakryiko
@ 2020-06-17 5:56 ` John Fastabend
0 siblings, 0 replies; 4+ messages in thread
From: John Fastabend @ 2020-06-17 5:56 UTC (permalink / raw)
To: Andrii Nakryiko, Tobias Klauser
Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, bpf
Andrii Nakryiko wrote:
> On Tue, Jun 16, 2020 at 4:34 AM Tobias Klauser <tklauser@distanz.ch> wrote:
> >
> > Commit c34a06c56df7 ("tools/bpftool: Add ringbuf map to a list of known
> > map types") added the symbolic "ringbuf" name. Document it in the bpftool
> > map command docs and usage as well.
> >
> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> > ---
>
> Thanks!
>
> Acked-by: Andrii Nakryiko <andriin@fb.com>
Acked-by: John Fastabend <john.fastabend@gmail.com>
>
> > tools/bpf/bpftool/Documentation/bpftool-map.rst | 2 +-
> > tools/bpf/bpftool/map.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
>
> [...]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf] tools, bpftool: Add ringbuf map type to map command docs
2020-06-16 11:33 [PATCH bpf] tools, bpftool: Add ringbuf map type to map command docs Tobias Klauser
2020-06-16 17:06 ` Andrii Nakryiko
@ 2020-06-17 16:09 ` Daniel Borkmann
1 sibling, 0 replies; 4+ messages in thread
From: Daniel Borkmann @ 2020-06-17 16:09 UTC (permalink / raw)
To: Tobias Klauser, Alexei Starovoitov; +Cc: Andrii Nakryiko, bpf
On 6/16/20 1:33 PM, Tobias Klauser wrote:
> Commit c34a06c56df7 ("tools/bpftool: Add ringbuf map to a list of known
> map types") added the symbolic "ringbuf" name. Document it in the bpftool
> map command docs and usage as well.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-17 16:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-16 11:33 [PATCH bpf] tools, bpftool: Add ringbuf map type to map command docs Tobias Klauser
2020-06-16 17:06 ` Andrii Nakryiko
2020-06-17 5:56 ` John Fastabend
2020-06-17 16:09 ` Daniel Borkmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.