All of lore.kernel.org
 help / color / mirror / Atom feed
* sony-laptop fix for 5.6 and 5.7
@ 2020-06-07  3:50 Mattia Dongili
  2020-06-16 12:16 ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Mattia Dongili @ 2020-06-07  3:50 UTC (permalink / raw)
  To: stable

commit 95e2c5b0fd6d7a022f37e7c762ea093aba7b8e34 upstream

platform/x86: sony-laptop: SNC calls should handle BUFFER types

After commit 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer
objects for ASL create_field() operator") ACPICA creates buffers even
when new fields are small enough to fit into an integer.
Many SNC calls counted on the old behaviour.
Since sony-laptop already handles the INTEGER/BUFFER case in
sony_nc_buffer_call, switch sony_nc_int_call to use its more generic
function instead.

Fixes: 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer objects for ASL create_field() operator")
Reported-by: Dominik Mierzejewski <dominik@greysector.net>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=207491
Reported-by: William Bader <williambader@hotmail.com>
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1830150
Signed-off-by: Mattia Dongili <malattia@linux.it>

---

ACPICA broke resume from s2ram for some Vaio laptops in 5.6. The
platform drivers maintainers didn't send the fix for 5.7, so the commit
is needed both on 5.6 and on 5.7.

Thanks
-- 
mattia
:wq!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: sony-laptop fix for 5.6 and 5.7
  2020-06-07  3:50 sony-laptop fix for 5.6 and 5.7 Mattia Dongili
@ 2020-06-16 12:16 ` Greg KH
  2020-06-16 12:30   ` Mattia Dongili
  0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2020-06-16 12:16 UTC (permalink / raw)
  To: Mattia Dongili; +Cc: stable

On Sun, Jun 07, 2020 at 12:50:55PM +0900, Mattia Dongili wrote:
> commit 95e2c5b0fd6d7a022f37e7c762ea093aba7b8e34 upstream

I do not see that commit id in Linus's tree.  Are you sure it is
correct?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: sony-laptop fix for 5.6 and 5.7
  2020-06-16 12:16 ` Greg KH
@ 2020-06-16 12:30   ` Mattia Dongili
  2020-06-16 12:45     ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Mattia Dongili @ 2020-06-16 12:30 UTC (permalink / raw)
  To: Greg KH; +Cc: stable

On Tue, Jun 16, 2020 at 02:16:01PM +0200, Greg KH wrote:
> On Sun, Jun 07, 2020 at 12:50:55PM +0900, Mattia Dongili wrote:
> > commit 95e2c5b0fd6d7a022f37e7c762ea093aba7b8e34 upstream
> 
> I do not see that commit id in Linus's tree.  Are you sure it is
> correct?

Heh, no. I didn't rebase my local tree... rookie mistake.
It should be 47828d22539f76c8c9dcf2a55f18ea3a8039d8ef.

I noticed that Sasha Levin autoselected for 5.7 both the patches for
sony-laptop related to the ACPI breakage.
So they are only missing in 5.6 at this point and it's worth getting
both even though only 47828d22539f should be sufficient.

The two commit ids that were picked up for 5.7 are:

[ Upstream commit 47828d22539f76c8c9dcf2a55f18ea3a8039d8ef ]
[ Upstream commit 476d60b1b4c8a2b14a53ef9b772058f35e604661 ]

Thanks
-- 
mattia
:wq!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: sony-laptop fix for 5.6 and 5.7
  2020-06-16 12:30   ` Mattia Dongili
@ 2020-06-16 12:45     ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2020-06-16 12:45 UTC (permalink / raw)
  To: Mattia Dongili; +Cc: stable

On Tue, Jun 16, 2020 at 09:30:31PM +0900, Mattia Dongili wrote:
> On Tue, Jun 16, 2020 at 02:16:01PM +0200, Greg KH wrote:
> > On Sun, Jun 07, 2020 at 12:50:55PM +0900, Mattia Dongili wrote:
> > > commit 95e2c5b0fd6d7a022f37e7c762ea093aba7b8e34 upstream
> > 
> > I do not see that commit id in Linus's tree.  Are you sure it is
> > correct?
> 
> Heh, no. I didn't rebase my local tree... rookie mistake.
> It should be 47828d22539f76c8c9dcf2a55f18ea3a8039d8ef.
> 
> I noticed that Sasha Levin autoselected for 5.7 both the patches for
> sony-laptop related to the ACPI breakage.
> So they are only missing in 5.6 at this point and it's worth getting
> both even though only 47828d22539f should be sufficient.
> 
> The two commit ids that were picked up for 5.7 are:
> 
> [ Upstream commit 47828d22539f76c8c9dcf2a55f18ea3a8039d8ef ]
> [ Upstream commit 476d60b1b4c8a2b14a53ef9b772058f35e604661 ]

Thanks, I'll go queue those up now.

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-06-16 12:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-07  3:50 sony-laptop fix for 5.6 and 5.7 Mattia Dongili
2020-06-16 12:16 ` Greg KH
2020-06-16 12:30   ` Mattia Dongili
2020-06-16 12:45     ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.