* [ath6kl:ath11k-qca6390-bringup 67/67] drivers/net/wireless/ath/ath11k/pci.c:362:6: warning: no previous prototype for 'ath11k_pci_soc_global_reset'
@ 2020-06-16 19:18 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-06-16 19:18 UTC (permalink / raw)
To: Carl Huang; +Cc: kbuild-all, ath10k, Kalle Valo
[-- Attachment #1: Type: text/plain, Size: 4818 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-qca6390-bringup
head: 682bd79bb8fe637b426947462daa7bdf155b198a
commit: 682bd79bb8fe637b426947462daa7bdf155b198a [67/67] ath11k: reset MHI during power down and power up
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
git checkout 682bd79bb8fe637b426947462daa7bdf155b198a
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/net/wireless/ath/ath11k/pci.c:362:6: warning: no previous prototype for 'ath11k_pci_soc_global_reset' [-Wmissing-prototypes]
362 | void ath11k_pci_soc_global_reset(struct ath11k_base *ab)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/ath11k/pci.c:389:6: warning: no previous prototype for 'ath11k_pci_clear_dbg_registers' [-Wmissing-prototypes]
389 | void ath11k_pci_clear_dbg_registers(struct ath11k_base *ab)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/ath11k/pci.c:419:6: warning: no previous prototype for 'ath11k_pci_force_wake' [-Wmissing-prototypes]
419 | void ath11k_pci_force_wake(struct ath11k_base *ab)
| ^~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/ath11k/pci.c:425:6: warning: no previous prototype for 'ath11k_pci_force_wake_release' [-Wmissing-prototypes]
425 | void ath11k_pci_force_wake_release(struct ath11k_base *ab)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/ath11k/pci.c:431:6: warning: no previous prototype for 'ath11k_pci_sw_reset' [-Wmissing-prototypes]
431 | void ath11k_pci_sw_reset(struct ath11k_base *ab)
| ^~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath11k/pci.c: In function 'ath11k_pci_start':
>> drivers/net/wireless/ath/ath11k/pci.c:1078:21: warning: variable 'ar_pci' set but not used [-Wunused-but-set-variable]
1078 | struct ath11k_pci *ar_pci;
| ^~~~~~
vim +/ath11k_pci_soc_global_reset +362 drivers/net/wireless/ath/ath11k/pci.c
361
> 362 void ath11k_pci_soc_global_reset(struct ath11k_base *ab)
363 {
364 u32 val;
365 u32 delay;
366
367 val = ath11k_pci_read32(ab, PCIE_SOC_GLOBAL_RESET);
368
369 val |= PCIE_SOC_GLOBAL_RESET_V;
370
371 ath11k_pci_write32(ab, PCIE_SOC_GLOBAL_RESET, val);
372
373 /* TODO: exact time to sleep is uncertain */
374 delay = 10;
375 mdelay(delay);
376
377 /* Need to toggle V bit back otherwise stuck in reset status */
378 val &= ~PCIE_SOC_GLOBAL_RESET_V;
379
380 ath11k_pci_write32(ab, PCIE_SOC_GLOBAL_RESET, val);
381
382 mdelay(delay);
383
384 val = ath11k_pci_read32(ab, PCIE_SOC_GLOBAL_RESET);
385 if (val == 0xffffffff)
386 ath11k_err(ab, "%s link down error\n", __func__);
387 }
388
> 389 void ath11k_pci_clear_dbg_registers(struct ath11k_base *ab)
390 {
391 u32 val;
392
393 /* read cookie */
394 val = ath11k_pci_read32(ab, PCIE_Q6_COOKIE_ADDR);
395 ath11k_dbg(ab, ATH11K_DBG_PCI, "cookie:0x%x\n", val);
396
397 val = ath11k_pci_read32(ab, WLAON_WARM_SW_ENTRY);
398 ath11k_dbg(ab, ATH11K_DBG_PCI, "WLAON_WARM_SW_ENTRY 0x%x\n", val);
399
400 /* TODO: exact time to sleep is uncertain */
401 mdelay(10);
402
403 /* write 0 to WLAON_WARM_SW_ENTRY to prevent Q6 from
404 * continuing warm path and entering dead loop.
405 */
406 ath11k_pci_write32(ab, WLAON_WARM_SW_ENTRY, 0);
407 mdelay(10);
408
409 val = ath11k_pci_read32(ab, WLAON_WARM_SW_ENTRY);
410 ath11k_dbg(ab, ATH11K_DBG_PCI, "WLAON_WARM_SW_ENTRY 0x%x\n", val);
411
412 /* A read clear register. clear the register to prevent
413 * Q6 from entering wrong code path.
414 */
415 val = ath11k_pci_read32(ab, WLAON_SOC_RESET_CAUSE_REG);
416 ath11k_dbg(ab, ATH11K_DBG_PCI, "soc reset cause:%d\n", val);
417 }
418
> 419 void ath11k_pci_force_wake(struct ath11k_base *ab)
420 {
421 ath11k_pci_write32(ab, PCIE_SOC_WAKE_PCIE_LOCAL_REG, 1);
422 mdelay(5);
423 }
424
> 425 void ath11k_pci_force_wake_release(struct ath11k_base *ab)
426 {
427 ath11k_pci_write32(ab, PCIE_SOC_WAKE_PCIE_LOCAL_REG, 0);
428 mdelay(5);
429 }
430
> 431 void ath11k_pci_sw_reset(struct ath11k_base *ab)
432 {
433 ath11k_pci_soc_global_reset(ab);
434 ath11k_mhi_clear_vector(ab);
435 ath11k_pci_soc_global_reset(ab);
436 ath11k_mhi_set_mhictrl_reset(ab);
437 ath11k_pci_clear_dbg_registers(ab);
438 }
439
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 73470 bytes --]
[-- Attachment #3: Type: text/plain, Size: 146 bytes --]
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 2+ messages in thread
* [ath6kl:ath11k-qca6390-bringup 67/67] drivers/net/wireless/ath/ath11k/pci.c:362:6: warning: no previous prototype for 'ath11k_pci_soc_global_reset'
@ 2020-06-16 19:18 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-06-16 19:18 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4940 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-qca6390-bringup
head: 682bd79bb8fe637b426947462daa7bdf155b198a
commit: 682bd79bb8fe637b426947462daa7bdf155b198a [67/67] ath11k: reset MHI during power down and power up
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
git checkout 682bd79bb8fe637b426947462daa7bdf155b198a
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/net/wireless/ath/ath11k/pci.c:362:6: warning: no previous prototype for 'ath11k_pci_soc_global_reset' [-Wmissing-prototypes]
362 | void ath11k_pci_soc_global_reset(struct ath11k_base *ab)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/ath11k/pci.c:389:6: warning: no previous prototype for 'ath11k_pci_clear_dbg_registers' [-Wmissing-prototypes]
389 | void ath11k_pci_clear_dbg_registers(struct ath11k_base *ab)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/ath11k/pci.c:419:6: warning: no previous prototype for 'ath11k_pci_force_wake' [-Wmissing-prototypes]
419 | void ath11k_pci_force_wake(struct ath11k_base *ab)
| ^~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/ath11k/pci.c:425:6: warning: no previous prototype for 'ath11k_pci_force_wake_release' [-Wmissing-prototypes]
425 | void ath11k_pci_force_wake_release(struct ath11k_base *ab)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/ath11k/pci.c:431:6: warning: no previous prototype for 'ath11k_pci_sw_reset' [-Wmissing-prototypes]
431 | void ath11k_pci_sw_reset(struct ath11k_base *ab)
| ^~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath11k/pci.c: In function 'ath11k_pci_start':
>> drivers/net/wireless/ath/ath11k/pci.c:1078:21: warning: variable 'ar_pci' set but not used [-Wunused-but-set-variable]
1078 | struct ath11k_pci *ar_pci;
| ^~~~~~
vim +/ath11k_pci_soc_global_reset +362 drivers/net/wireless/ath/ath11k/pci.c
361
> 362 void ath11k_pci_soc_global_reset(struct ath11k_base *ab)
363 {
364 u32 val;
365 u32 delay;
366
367 val = ath11k_pci_read32(ab, PCIE_SOC_GLOBAL_RESET);
368
369 val |= PCIE_SOC_GLOBAL_RESET_V;
370
371 ath11k_pci_write32(ab, PCIE_SOC_GLOBAL_RESET, val);
372
373 /* TODO: exact time to sleep is uncertain */
374 delay = 10;
375 mdelay(delay);
376
377 /* Need to toggle V bit back otherwise stuck in reset status */
378 val &= ~PCIE_SOC_GLOBAL_RESET_V;
379
380 ath11k_pci_write32(ab, PCIE_SOC_GLOBAL_RESET, val);
381
382 mdelay(delay);
383
384 val = ath11k_pci_read32(ab, PCIE_SOC_GLOBAL_RESET);
385 if (val == 0xffffffff)
386 ath11k_err(ab, "%s link down error\n", __func__);
387 }
388
> 389 void ath11k_pci_clear_dbg_registers(struct ath11k_base *ab)
390 {
391 u32 val;
392
393 /* read cookie */
394 val = ath11k_pci_read32(ab, PCIE_Q6_COOKIE_ADDR);
395 ath11k_dbg(ab, ATH11K_DBG_PCI, "cookie:0x%x\n", val);
396
397 val = ath11k_pci_read32(ab, WLAON_WARM_SW_ENTRY);
398 ath11k_dbg(ab, ATH11K_DBG_PCI, "WLAON_WARM_SW_ENTRY 0x%x\n", val);
399
400 /* TODO: exact time to sleep is uncertain */
401 mdelay(10);
402
403 /* write 0 to WLAON_WARM_SW_ENTRY to prevent Q6 from
404 * continuing warm path and entering dead loop.
405 */
406 ath11k_pci_write32(ab, WLAON_WARM_SW_ENTRY, 0);
407 mdelay(10);
408
409 val = ath11k_pci_read32(ab, WLAON_WARM_SW_ENTRY);
410 ath11k_dbg(ab, ATH11K_DBG_PCI, "WLAON_WARM_SW_ENTRY 0x%x\n", val);
411
412 /* A read clear register. clear the register to prevent
413 * Q6 from entering wrong code path.
414 */
415 val = ath11k_pci_read32(ab, WLAON_SOC_RESET_CAUSE_REG);
416 ath11k_dbg(ab, ATH11K_DBG_PCI, "soc reset cause:%d\n", val);
417 }
418
> 419 void ath11k_pci_force_wake(struct ath11k_base *ab)
420 {
421 ath11k_pci_write32(ab, PCIE_SOC_WAKE_PCIE_LOCAL_REG, 1);
422 mdelay(5);
423 }
424
> 425 void ath11k_pci_force_wake_release(struct ath11k_base *ab)
426 {
427 ath11k_pci_write32(ab, PCIE_SOC_WAKE_PCIE_LOCAL_REG, 0);
428 mdelay(5);
429 }
430
> 431 void ath11k_pci_sw_reset(struct ath11k_base *ab)
432 {
433 ath11k_pci_soc_global_reset(ab);
434 ath11k_mhi_clear_vector(ab);
435 ath11k_pci_soc_global_reset(ab);
436 ath11k_mhi_set_mhictrl_reset(ab);
437 ath11k_pci_clear_dbg_registers(ab);
438 }
439
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 73470 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-16 19:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-16 19:18 [ath6kl:ath11k-qca6390-bringup 67/67] drivers/net/wireless/ath/ath11k/pci.c:362:6: warning: no previous prototype for 'ath11k_pci_soc_global_reset' kernel test robot
2020-06-16 19:18 ` kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.