From: Eric Biggers <ebiggers@kernel.org> To: Satya Tangirala <satyat@google.com> Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org Subject: Re: [PATCH 0/4] Inline Encryption Support for fscrypt Date: Thu, 18 Jun 2020 10:27:09 -0700 [thread overview] Message-ID: <20200618172709.GA2957@sol.localdomain> (raw) In-Reply-To: <20200617075732.213198-1-satyat@google.com> On Wed, Jun 17, 2020 at 07:57:28AM +0000, Satya Tangirala wrote: > This patch series adds support for Inline Encryption to fscrypt, f2fs > and ext4. It builds on the inline encryption support now present in > the block layer, and has been rebased on v5.8-rc1. > > Patch 1 introduces the SB_INLINECRYPT sb options, which filesystems > should set if they want to use blk-crypto for file content en/decryption. > > Patch 2 adds inline encryption support to fscrypt. To use inline > encryption with fscrypt, the filesystem must set the above mentioned > SB_INLINECRYPT sb option. When this option is set, the contents of > encrypted files will be en/decrypted using blk-crypto. > > Patches 3 and 4 wire up f2fs and ext4 respectively to fscrypt support for > inline encryption, and e.g ensure that bios are submitted with blocks > that not only are contiguous, but also have contiguous DUNs. > > Eric Biggers (1): > ext4: add inline encryption support > > Satya Tangirala (3): > fs: introduce SB_INLINECRYPT > fscrypt: add inline encryption support > f2fs: add inline encryption support > Like I said on the UFS patchset: as this previously went through a number of iterations as part of the "Inline Encryption Support" patchset (latest v13: https://lkml.kernel.org/r/20200514003727.69001-1-satyat@google.com), it would be helpful to list the changelog from v13 (though I can see that not too much changed). And I probably would have called it v14, but it doesn't matter much. Explicit mentioning how this was tested would also be helpful. And for that matter, we should update the "Tests" section of the fscrypt documentation file to mention also using the inlinecrypt mount option, e.g.: diff --git a/Documentation/filesystems/fscrypt.rst b/Documentation/filesystems/fscrypt.rst index f517af8ec11c..f5d8b0303ddf 100644 --- a/Documentation/filesystems/fscrypt.rst +++ b/Documentation/filesystems/fscrypt.rst @@ -1255,6 +1255,7 @@ f2fs encryption using `kvm-xfstests <https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md>`_:: kvm-xfstests -c ext4,f2fs -g encrypt + kvm-xfstests -c ext4,f2fs -g encrypt -m inlinecrypt UBIFS encryption can also be tested this way, but it should be done in a separate command, and it takes some time for kvm-xfstests to set up @@ -1276,6 +1277,7 @@ This tests the encrypted I/O paths more thoroughly. To do this with kvm-xfstests, use the "encrypt" filesystem configuration:: kvm-xfstests -c ext4/encrypt,f2fs/encrypt -g auto + kvm-xfstests -c ext4/encrypt,f2fs/encrypt -g auto -m inlinecrypt Because this runs many more tests than "-g encrypt" does, it takes much longer to run; so also consider using `gce-xfstests @@ -1283,3 +1285,4 @@ much longer to run; so also consider using `gce-xfstests instead of kvm-xfstests:: gce-xfstests -c ext4/encrypt,f2fs/encrypt -g auto + gce-xfstests -c ext4/encrypt,f2fs/encrypt -g auto -m inlinecrypt
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org> To: Satya Tangirala <satyat@google.com> Cc: linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 0/4] Inline Encryption Support for fscrypt Date: Thu, 18 Jun 2020 10:27:09 -0700 [thread overview] Message-ID: <20200618172709.GA2957@sol.localdomain> (raw) In-Reply-To: <20200617075732.213198-1-satyat@google.com> On Wed, Jun 17, 2020 at 07:57:28AM +0000, Satya Tangirala wrote: > This patch series adds support for Inline Encryption to fscrypt, f2fs > and ext4. It builds on the inline encryption support now present in > the block layer, and has been rebased on v5.8-rc1. > > Patch 1 introduces the SB_INLINECRYPT sb options, which filesystems > should set if they want to use blk-crypto for file content en/decryption. > > Patch 2 adds inline encryption support to fscrypt. To use inline > encryption with fscrypt, the filesystem must set the above mentioned > SB_INLINECRYPT sb option. When this option is set, the contents of > encrypted files will be en/decrypted using blk-crypto. > > Patches 3 and 4 wire up f2fs and ext4 respectively to fscrypt support for > inline encryption, and e.g ensure that bios are submitted with blocks > that not only are contiguous, but also have contiguous DUNs. > > Eric Biggers (1): > ext4: add inline encryption support > > Satya Tangirala (3): > fs: introduce SB_INLINECRYPT > fscrypt: add inline encryption support > f2fs: add inline encryption support > Like I said on the UFS patchset: as this previously went through a number of iterations as part of the "Inline Encryption Support" patchset (latest v13: https://lkml.kernel.org/r/20200514003727.69001-1-satyat@google.com), it would be helpful to list the changelog from v13 (though I can see that not too much changed). And I probably would have called it v14, but it doesn't matter much. Explicit mentioning how this was tested would also be helpful. And for that matter, we should update the "Tests" section of the fscrypt documentation file to mention also using the inlinecrypt mount option, e.g.: diff --git a/Documentation/filesystems/fscrypt.rst b/Documentation/filesystems/fscrypt.rst index f517af8ec11c..f5d8b0303ddf 100644 --- a/Documentation/filesystems/fscrypt.rst +++ b/Documentation/filesystems/fscrypt.rst @@ -1255,6 +1255,7 @@ f2fs encryption using `kvm-xfstests <https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md>`_:: kvm-xfstests -c ext4,f2fs -g encrypt + kvm-xfstests -c ext4,f2fs -g encrypt -m inlinecrypt UBIFS encryption can also be tested this way, but it should be done in a separate command, and it takes some time for kvm-xfstests to set up @@ -1276,6 +1277,7 @@ This tests the encrypted I/O paths more thoroughly. To do this with kvm-xfstests, use the "encrypt" filesystem configuration:: kvm-xfstests -c ext4/encrypt,f2fs/encrypt -g auto + kvm-xfstests -c ext4/encrypt,f2fs/encrypt -g auto -m inlinecrypt Because this runs many more tests than "-g encrypt" does, it takes much longer to run; so also consider using `gce-xfstests @@ -1283,3 +1285,4 @@ much longer to run; so also consider using `gce-xfstests instead of kvm-xfstests:: gce-xfstests -c ext4/encrypt,f2fs/encrypt -g auto + gce-xfstests -c ext4/encrypt,f2fs/encrypt -g auto -m inlinecrypt _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-06-18 17:27 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-17 7:57 [PATCH 0/4] Inline Encryption Support for fscrypt Satya Tangirala 2020-06-17 7:57 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-06-17 7:57 ` [PATCH 1/4] fs: introduce SB_INLINECRYPT Satya Tangirala 2020-06-17 7:57 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-06-17 17:46 ` Jaegeuk Kim 2020-06-17 17:46 ` [f2fs-dev] " Jaegeuk Kim 2020-06-18 1:19 ` Dave Chinner 2020-06-18 1:19 ` [f2fs-dev] " Dave Chinner 2020-06-18 3:19 ` Eric Biggers 2020-06-18 3:19 ` [f2fs-dev] " Eric Biggers 2020-06-23 0:46 ` Dave Chinner 2020-06-23 0:46 ` [f2fs-dev] " Dave Chinner 2020-06-23 1:50 ` Eric Biggers 2020-06-23 1:50 ` Eric Biggers 2020-06-24 0:55 ` Dave Chinner 2020-06-24 0:55 ` Dave Chinner 2020-06-17 7:57 ` [PATCH 2/4] fscrypt: add inline encryption support Satya Tangirala 2020-06-17 7:57 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-06-17 17:59 ` Jaegeuk Kim 2020-06-17 17:59 ` [f2fs-dev] " Jaegeuk Kim 2020-06-18 17:48 ` Eric Biggers 2020-06-18 17:48 ` [f2fs-dev] " Eric Biggers 2020-06-17 7:57 ` [PATCH 3/4] f2fs: " Satya Tangirala 2020-06-17 7:57 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-06-17 17:56 ` Jaegeuk Kim 2020-06-17 17:56 ` [f2fs-dev] " Jaegeuk Kim 2020-06-18 10:06 ` Chao Yu 2020-06-18 10:06 ` [f2fs-dev] " Chao Yu 2020-06-18 18:13 ` Eric Biggers 2020-06-18 18:13 ` [f2fs-dev] " Eric Biggers 2020-06-18 19:28 ` Jaegeuk Kim 2020-06-18 19:28 ` [f2fs-dev] " Jaegeuk Kim 2020-06-18 19:35 ` Eric Biggers 2020-06-18 19:35 ` [f2fs-dev] " Eric Biggers 2020-06-19 2:43 ` Chao Yu 2020-06-19 2:43 ` [f2fs-dev] " Chao Yu 2020-06-19 2:39 ` Chao Yu 2020-06-19 2:39 ` [f2fs-dev] " Chao Yu 2020-06-19 4:20 ` Eric Biggers 2020-06-19 4:20 ` [f2fs-dev] " Eric Biggers 2020-06-19 6:37 ` Chao Yu 2020-06-19 6:37 ` [f2fs-dev] " Chao Yu 2020-06-18 22:50 ` Eric Biggers 2020-06-18 22:50 ` [f2fs-dev] " Eric Biggers 2020-06-17 7:57 ` [PATCH 4/4] ext4: " Satya Tangirala 2020-06-17 7:57 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-06-18 17:27 ` Eric Biggers [this message] 2020-06-18 17:27 ` [f2fs-dev] [PATCH 0/4] Inline Encryption Support for fscrypt Eric Biggers
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200618172709.GA2957@sol.localdomain \ --to=ebiggers@kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fscrypt@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=satyat@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.