* [PATCH net] ibmvnic: continue to init in CRQ reset returns H_CLOSED
@ 2020-06-18 19:24 ` Dany Madden
0 siblings, 0 replies; 4+ messages in thread
From: Dany Madden @ 2020-06-18 19:24 UTC (permalink / raw)
To: davem; +Cc: netdev, linuxppc-dev, tlfalcon, Dany Madden
Continue the reset path when partner adapter is not ready or H_CLOSED is
returned from reset crq. This patch allows the CRQ init to proceed to
establish a valid CRQ for traffic to flow after reset.
Signed-off-by: Dany Madden <drt@linux.ibm.com>
---
drivers/net/ethernet/ibm/ibmvnic.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 2baf7b3ff4cb..4b7cb483c47f 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -1971,13 +1971,18 @@ static int do_reset(struct ibmvnic_adapter *adapter,
release_sub_crqs(adapter, 1);
} else {
rc = ibmvnic_reset_crq(adapter);
- if (!rc)
+ if (rc == H_CLOSED || rc == H_SUCCESS) {
rc = vio_enable_interrupts(adapter->vdev);
+ if (rc)
+ netdev_err(adapter->netdev,
+ "Reset failed to enable interrupts. rc=%d\n",
+ rc);
+ }
}
if (rc) {
netdev_err(adapter->netdev,
- "Couldn't initialize crq. rc=%d\n", rc);
+ "Reset couldn't initialize crq. rc=%d\n", rc);
goto out;
}
--
2.18.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net] ibmvnic: continue to init in CRQ reset returns H_CLOSED
@ 2020-06-18 19:24 ` Dany Madden
0 siblings, 0 replies; 4+ messages in thread
From: Dany Madden @ 2020-06-18 19:24 UTC (permalink / raw)
To: davem; +Cc: Dany Madden, netdev, tlfalcon, linuxppc-dev
Continue the reset path when partner adapter is not ready or H_CLOSED is
returned from reset crq. This patch allows the CRQ init to proceed to
establish a valid CRQ for traffic to flow after reset.
Signed-off-by: Dany Madden <drt@linux.ibm.com>
---
drivers/net/ethernet/ibm/ibmvnic.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 2baf7b3ff4cb..4b7cb483c47f 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -1971,13 +1971,18 @@ static int do_reset(struct ibmvnic_adapter *adapter,
release_sub_crqs(adapter, 1);
} else {
rc = ibmvnic_reset_crq(adapter);
- if (!rc)
+ if (rc == H_CLOSED || rc == H_SUCCESS) {
rc = vio_enable_interrupts(adapter->vdev);
+ if (rc)
+ netdev_err(adapter->netdev,
+ "Reset failed to enable interrupts. rc=%d\n",
+ rc);
+ }
}
if (rc) {
netdev_err(adapter->netdev,
- "Couldn't initialize crq. rc=%d\n", rc);
+ "Reset couldn't initialize crq. rc=%d\n", rc);
goto out;
}
--
2.18.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] ibmvnic: continue to init in CRQ reset returns H_CLOSED
2020-06-18 19:24 ` Dany Madden
@ 2020-06-21 0:28 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-06-21 0:28 UTC (permalink / raw)
To: drt; +Cc: netdev, linuxppc-dev, tlfalcon
From: Dany Madden <drt@linux.ibm.com>
Date: Thu, 18 Jun 2020 15:24:13 -0400
> Continue the reset path when partner adapter is not ready or H_CLOSED is
> returned from reset crq. This patch allows the CRQ init to proceed to
> establish a valid CRQ for traffic to flow after reset.
>
> Signed-off-by: Dany Madden <drt@linux.ibm.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] ibmvnic: continue to init in CRQ reset returns H_CLOSED
@ 2020-06-21 0:28 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-06-21 0:28 UTC (permalink / raw)
To: drt; +Cc: netdev, tlfalcon, linuxppc-dev
From: Dany Madden <drt@linux.ibm.com>
Date: Thu, 18 Jun 2020 15:24:13 -0400
> Continue the reset path when partner adapter is not ready or H_CLOSED is
> returned from reset crq. This patch allows the CRQ init to proceed to
> establish a valid CRQ for traffic to flow after reset.
>
> Signed-off-by: Dany Madden <drt@linux.ibm.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-21 0:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-18 19:24 [PATCH net] ibmvnic: continue to init in CRQ reset returns H_CLOSED Dany Madden
2020-06-18 19:24 ` Dany Madden
2020-06-21 0:28 ` David Miller
2020-06-21 0:28 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.