* [PATCH 1/2 v4] exfat: write multiple sectors at once @ 2020-06-19 8:38 Tetsuhiro Kohada 2020-06-19 8:38 ` [PATCH 2/2 v4] exfat: add error check when updating dir-entries Tetsuhiro Kohada 2020-06-21 3:09 ` [PATCH 1/2 v4] exfat: write multiple sectors at once Namjae Jeon 0 siblings, 2 replies; 4+ messages in thread From: Tetsuhiro Kohada @ 2020-06-19 8:38 UTC (permalink / raw) To: kohada.t2 Cc: kohada.tetsuhiro, mori.takahiro, motai.hirotaka, Christoph Hellwig, Namjae Jeon, Sungjong Seo, linux-fsdevel, linux-kernel Write multiple sectors at once when updating dir-entries. Add exfat_update_bhs() for that. It wait for write completion once instead of sector by sector. It's only effective if sync enabled. Reviewed-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Tetsuhiro Kohada <kohada.t2@gmail.com> --- Changes in v2: - Split into 'write multiple sectors at once' and 'add error check when updating dir-entries' Changes in v3 - Rebase to latest exfat-dev Changes in v4 - Use if/else instead of conditional operator fs/exfat/dir.c | 15 +++++++++------ fs/exfat/exfat_fs.h | 1 + fs/exfat/misc.c | 19 +++++++++++++++++++ 3 files changed, 29 insertions(+), 6 deletions(-) diff --git a/fs/exfat/dir.c b/fs/exfat/dir.c index 02acbb6ddf02..7c2e29632634 100644 --- a/fs/exfat/dir.c +++ b/fs/exfat/dir.c @@ -606,13 +606,16 @@ void exfat_update_dir_chksum_with_entry_set(struct exfat_entry_set_cache *es) void exfat_free_dentry_set(struct exfat_entry_set_cache *es, int sync) { - int i; + int i, err = 0; - for (i = 0; i < es->num_bh; i++) { - if (es->modified) - exfat_update_bh(es->bh[i], sync); - brelse(es->bh[i]); - } + if (es->modified) + err = exfat_update_bhs(es->bh, es->num_bh, sync); + + for (i = 0; i < es->num_bh; i++) + if (err) + bforget(es->bh[i]); + else + brelse(es->bh[i]); kfree(es); } diff --git a/fs/exfat/exfat_fs.h b/fs/exfat/exfat_fs.h index 84664024e51e..cbb00ee97183 100644 --- a/fs/exfat/exfat_fs.h +++ b/fs/exfat/exfat_fs.h @@ -512,6 +512,7 @@ void exfat_set_entry_time(struct exfat_sb_info *sbi, struct timespec64 *ts, u16 exfat_calc_chksum16(void *data, int len, u16 chksum, int type); u32 exfat_calc_chksum32(void *data, int len, u32 chksum, int type); void exfat_update_bh(struct buffer_head *bh, int sync); +int exfat_update_bhs(struct buffer_head **bhs, int nr_bhs, int sync); void exfat_chain_set(struct exfat_chain *ec, unsigned int dir, unsigned int size, unsigned char flags); void exfat_chain_dup(struct exfat_chain *dup, struct exfat_chain *ec); diff --git a/fs/exfat/misc.c b/fs/exfat/misc.c index 8a3dde59052b..564718747fb2 100644 --- a/fs/exfat/misc.c +++ b/fs/exfat/misc.c @@ -172,6 +172,25 @@ void exfat_update_bh(struct buffer_head *bh, int sync) sync_dirty_buffer(bh); } +int exfat_update_bhs(struct buffer_head **bhs, int nr_bhs, int sync) +{ + int i, err = 0; + + for (i = 0; i < nr_bhs; i++) { + set_buffer_uptodate(bhs[i]); + mark_buffer_dirty(bhs[i]); + if (sync) + write_dirty_buffer(bhs[i], 0); + } + + for (i = 0; i < nr_bhs && sync; i++) { + wait_on_buffer(bhs[i]); + if (!buffer_uptodate(bhs[i])) + err = -EIO; + } + return err; +} + void exfat_chain_set(struct exfat_chain *ec, unsigned int dir, unsigned int size, unsigned char flags) { -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2 v4] exfat: add error check when updating dir-entries 2020-06-19 8:38 [PATCH 1/2 v4] exfat: write multiple sectors at once Tetsuhiro Kohada @ 2020-06-19 8:38 ` Tetsuhiro Kohada 2020-06-21 3:09 ` [PATCH 1/2 v4] exfat: write multiple sectors at once Namjae Jeon 1 sibling, 0 replies; 4+ messages in thread From: Tetsuhiro Kohada @ 2020-06-19 8:38 UTC (permalink / raw) To: kohada.t2 Cc: kohada.tetsuhiro, mori.takahiro, motai.hirotaka, Sungjong Seo, Namjae Jeon, linux-fsdevel, linux-kernel Add error check when synchronously updating dir-entries. Suggested-by: Sungjong Seo <sj1557.seo@samsung.com> Signed-off-by: Tetsuhiro Kohada <kohada.t2@gmail.com> --- Changes in v2: - Split into 'write multiple sectors at once' and 'add error check when updating dir-entries' Changes in v3 - Rebase to latest exfat-dev Changes in v4 - Based on 'exfat: write multiple sectors at once' v4 fs/exfat/dir.c | 3 ++- fs/exfat/exfat_fs.h | 2 +- fs/exfat/file.c | 5 ++++- fs/exfat/inode.c | 8 +++++--- 4 files changed, 12 insertions(+), 6 deletions(-) diff --git a/fs/exfat/dir.c b/fs/exfat/dir.c index 7c2e29632634..2dc6fe695cb6 100644 --- a/fs/exfat/dir.c +++ b/fs/exfat/dir.c @@ -604,7 +604,7 @@ void exfat_update_dir_chksum_with_entry_set(struct exfat_entry_set_cache *es) es->modified = true; } -void exfat_free_dentry_set(struct exfat_entry_set_cache *es, int sync) +int exfat_free_dentry_set(struct exfat_entry_set_cache *es, int sync) { int i, err = 0; @@ -617,6 +617,7 @@ void exfat_free_dentry_set(struct exfat_entry_set_cache *es, int sync) else brelse(es->bh[i]); kfree(es); + return err; } static int exfat_walk_fat_chain(struct super_block *sb, diff --git a/fs/exfat/exfat_fs.h b/fs/exfat/exfat_fs.h index cbb00ee97183..da677c85314f 100644 --- a/fs/exfat/exfat_fs.h +++ b/fs/exfat/exfat_fs.h @@ -459,7 +459,7 @@ struct exfat_dentry *exfat_get_dentry_cached(struct exfat_entry_set_cache *es, int num); struct exfat_entry_set_cache *exfat_get_dentry_set(struct super_block *sb, struct exfat_chain *p_dir, int entry, unsigned int type); -void exfat_free_dentry_set(struct exfat_entry_set_cache *es, int sync); +int exfat_free_dentry_set(struct exfat_entry_set_cache *es, int sync); int exfat_count_dir_entries(struct super_block *sb, struct exfat_chain *p_dir); /* inode.c */ diff --git a/fs/exfat/file.c b/fs/exfat/file.c index fce03f318787..37c8f04c1f8a 100644 --- a/fs/exfat/file.c +++ b/fs/exfat/file.c @@ -153,6 +153,7 @@ int __exfat_truncate(struct inode *inode, loff_t new_size) struct timespec64 ts; struct exfat_dentry *ep, *ep2; struct exfat_entry_set_cache *es; + int err; es = exfat_get_dentry_set(sb, &(ei->dir), ei->entry, ES_ALL_ENTRIES); @@ -187,7 +188,9 @@ int __exfat_truncate(struct inode *inode, loff_t new_size) } exfat_update_dir_chksum_with_entry_set(es); - exfat_free_dentry_set(es, inode_needs_sync(inode)); + err = exfat_free_dentry_set(es, inode_needs_sync(inode)); + if (err) + return err; } /* cut off from the FAT chain */ diff --git a/fs/exfat/inode.c b/fs/exfat/inode.c index cf9ca6c4d046..1e851f172e0c 100644 --- a/fs/exfat/inode.c +++ b/fs/exfat/inode.c @@ -77,8 +77,7 @@ static int __exfat_write_inode(struct inode *inode, int sync) ep2->dentry.stream.size = ep2->dentry.stream.valid_size; exfat_update_dir_chksum_with_entry_set(es); - exfat_free_dentry_set(es, sync); - return 0; + return exfat_free_dentry_set(es, sync); } int exfat_write_inode(struct inode *inode, struct writeback_control *wbc) @@ -222,6 +221,7 @@ static int exfat_map_cluster(struct inode *inode, unsigned int clu_offset, if (ei->dir.dir != DIR_DELETED && modified) { struct exfat_dentry *ep; struct exfat_entry_set_cache *es; + int err; es = exfat_get_dentry_set(sb, &(ei->dir), ei->entry, ES_ALL_ENTRIES); @@ -240,7 +240,9 @@ static int exfat_map_cluster(struct inode *inode, unsigned int clu_offset, ep->dentry.stream.valid_size; exfat_update_dir_chksum_with_entry_set(es); - exfat_free_dentry_set(es, inode_needs_sync(inode)); + err = exfat_free_dentry_set(es, inode_needs_sync(inode)); + if (err) + return err; } /* end of if != DIR_DELETED */ -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2 v4] exfat: write multiple sectors at once 2020-06-19 8:38 [PATCH 1/2 v4] exfat: write multiple sectors at once Tetsuhiro Kohada 2020-06-19 8:38 ` [PATCH 2/2 v4] exfat: add error check when updating dir-entries Tetsuhiro Kohada @ 2020-06-21 3:09 ` Namjae Jeon 2020-06-22 2:44 ` Kohada.Tetsuhiro 1 sibling, 1 reply; 4+ messages in thread From: Namjae Jeon @ 2020-06-21 3:09 UTC (permalink / raw) To: Tetsuhiro Kohada Cc: kohada.tetsuhiro, mori.takahiro, motai.hirotaka, Christoph Hellwig, Namjae Jeon, Sungjong Seo, linux-fsdevel, linux-kernel 2020-06-19 17:38 GMT+09:00, Tetsuhiro Kohada <kohada.t2@gmail.com>: > Write multiple sectors at once when updating dir-entries. > Add exfat_update_bhs() for that. It wait for write completion once > instead of sector by sector. > It's only effective if sync enabled. > > Reviewed-by: Christoph Hellwig <hch@infradead.org> He didn't give reviewed-by tag for this patch. You shouldn't add it at will. > Signed-off-by: Tetsuhiro Kohada <kohada.t2@gmail.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 1/2 v4] exfat: write multiple sectors at once 2020-06-21 3:09 ` [PATCH 1/2 v4] exfat: write multiple sectors at once Namjae Jeon @ 2020-06-22 2:44 ` Kohada.Tetsuhiro 0 siblings, 0 replies; 4+ messages in thread From: Kohada.Tetsuhiro @ 2020-06-22 2:44 UTC (permalink / raw) To: 'Namjae Jeon' Cc: Mori.Takahiro, Motai.Hirotaka, Namjae Jeon, Sungjong Seo, linux-fsdevel, linux-kernel, 'Tetsuhiro Kohada', 'Christoph Hellwig' > 2020-06-19 17:38 GMT+09:00, Tetsuhiro Kohada <kohada.t2@gmail.com>: > > Write multiple sectors at once when updating dir-entries. > > Add exfat_update_bhs() for that. It wait for write completion once > > instead of sector by sector. > > It's only effective if sync enabled. > > > > Reviewed-by: Christoph Hellwig <hch@infradead.org> > He didn't give reviewed-by tag for this patch. > You shouldn't add it at will. I understand. Should I remove reviewed-by tag and repost the patch? BR --- Kohada Tetsuhiro <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-22 2:47 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-06-19 8:38 [PATCH 1/2 v4] exfat: write multiple sectors at once Tetsuhiro Kohada 2020-06-19 8:38 ` [PATCH 2/2 v4] exfat: add error check when updating dir-entries Tetsuhiro Kohada 2020-06-21 3:09 ` [PATCH 1/2 v4] exfat: write multiple sectors at once Namjae Jeon 2020-06-22 2:44 ` Kohada.Tetsuhiro
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.