* + lib-fix-test_hmmc-reference-after-free.patch added to -mm tree
@ 2020-06-21 2:21 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2020-06-21 2:21 UTC (permalink / raw)
To: mm-commits, rcampbell, jglisse, rdunlap
The patch titled
Subject: lib: fix test_hmm.c reference after free
has been added to the -mm tree. Its filename is
lib-fix-test_hmmc-reference-after-free.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/lib-fix-test_hmmc-reference-after-free.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/lib-fix-test_hmmc-reference-after-free.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Randy Dunlap <rdunlap@infradead.org>
Subject: lib: fix test_hmm.c reference after free
Coccinelle scripts report the following errors:
lib/test_hmm.c:523:20-26: ERROR: reference preceded by free on line 521
lib/test_hmm.c:524:21-27: ERROR: reference preceded by free on line 521
lib/test_hmm.c:523:28-35: ERROR: devmem is NULL but dereferenced.
lib/test_hmm.c:524:29-36: ERROR: devmem is NULL but dereferenced.
Fix these by using the local variable 'res' instead of devmem.
Link: http://lkml.kernel.org/r/c845c158-9c65-9665-0d0b-00342846dd07@infradead.org
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
Cc: Jérôme Glisse <jglisse@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/test_hmm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/lib/test_hmm.c~lib-fix-test_hmmc-reference-after-free
+++ a/lib/test_hmm.c
@@ -520,8 +520,7 @@ static bool dmirror_allocate_chunk(struc
err_free:
kfree(devmem);
err_release:
- release_mem_region(devmem->pagemap.res.start,
- resource_size(&devmem->pagemap.res));
+ release_mem_region(res->start, resource_size(res));
err:
mutex_unlock(&mdevice->devmem_lock);
return false;
_
Patches currently in -mm which might be from rdunlap@infradead.org are
lib-fix-test_hmmc-reference-after-free.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-21 2:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-21 2:21 + lib-fix-test_hmmc-reference-after-free.patch added to -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.