All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Frieder Schrempf <frieder.schrempf@kontron.de>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Vinod Koul <vkoul@kernel.org>, Fabio Estevam <festevam@gmail.com>
Subject: drivers/dma/imx-sdma.c:1334:23: warning: comparison of unsigned expression >= 0 is always true
Date: Sun, 21 Jun 2020 11:06:27 +0800	[thread overview]
Message-ID: <202006211123.QijIEuKZ%lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2259 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8b6ddd10d678bebec32381f71b6b420bafc43ad0
commit: 25962e1a7f1d522f1b57ead2f266fab570042a70 dmaengine: imx-sdma: Fix the event id check to include RX event for UART6
date:   4 months ago
config: arm-randconfig-r006-20200621 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 25962e1a7f1d522f1b57ead2f266fab570042a70
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/dma/imx-sdma.c: In function 'sdma_free_chan_resources':
>> drivers/dma/imx-sdma.c:1334:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
1334 |  if (sdmac->event_id0 >= 0)
|                       ^~
drivers/dma/imx-sdma.c: In function 'sdma_config':
drivers/dma/imx-sdma.c:1635:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
1635 |  if (sdmac->event_id0 >= 0) {
|                       ^~

vim +1334 drivers/dma/imx-sdma.c

  1324	
  1325	static void sdma_free_chan_resources(struct dma_chan *chan)
  1326	{
  1327		struct sdma_channel *sdmac = to_sdma_chan(chan);
  1328		struct sdma_engine *sdma = sdmac->sdma;
  1329	
  1330		sdma_terminate_all(chan);
  1331	
  1332		sdma_channel_synchronize(chan);
  1333	
> 1334		if (sdmac->event_id0 >= 0)
  1335			sdma_event_disable(sdmac, sdmac->event_id0);
  1336		if (sdmac->event_id1)
  1337			sdma_event_disable(sdmac, sdmac->event_id1);
  1338	
  1339		sdmac->event_id0 = 0;
  1340		sdmac->event_id1 = 0;
  1341		sdmac->context_loaded = false;
  1342	
  1343		sdma_set_channel_priority(sdmac, 0);
  1344	
  1345		clk_disable(sdma->clk_ipg);
  1346		clk_disable(sdma->clk_ahb);
  1347	}
  1348	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28238 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: drivers/dma/imx-sdma.c:1334:23: warning: comparison of unsigned expression >= 0 is always true
Date: Sun, 21 Jun 2020 11:06:27 +0800	[thread overview]
Message-ID: <202006211123.QijIEuKZ%lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2319 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8b6ddd10d678bebec32381f71b6b420bafc43ad0
commit: 25962e1a7f1d522f1b57ead2f266fab570042a70 dmaengine: imx-sdma: Fix the event id check to include RX event for UART6
date:   4 months ago
config: arm-randconfig-r006-20200621 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 25962e1a7f1d522f1b57ead2f266fab570042a70
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/dma/imx-sdma.c: In function 'sdma_free_chan_resources':
>> drivers/dma/imx-sdma.c:1334:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
1334 |  if (sdmac->event_id0 >= 0)
|                       ^~
drivers/dma/imx-sdma.c: In function 'sdma_config':
drivers/dma/imx-sdma.c:1635:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
1635 |  if (sdmac->event_id0 >= 0) {
|                       ^~

vim +1334 drivers/dma/imx-sdma.c

  1324	
  1325	static void sdma_free_chan_resources(struct dma_chan *chan)
  1326	{
  1327		struct sdma_channel *sdmac = to_sdma_chan(chan);
  1328		struct sdma_engine *sdma = sdmac->sdma;
  1329	
  1330		sdma_terminate_all(chan);
  1331	
  1332		sdma_channel_synchronize(chan);
  1333	
> 1334		if (sdmac->event_id0 >= 0)
  1335			sdma_event_disable(sdmac, sdmac->event_id0);
  1336		if (sdmac->event_id1)
  1337			sdma_event_disable(sdmac, sdmac->event_id1);
  1338	
  1339		sdmac->event_id0 = 0;
  1340		sdmac->event_id1 = 0;
  1341		sdmac->context_loaded = false;
  1342	
  1343		sdma_set_channel_priority(sdmac, 0);
  1344	
  1345		clk_disable(sdma->clk_ipg);
  1346		clk_disable(sdma->clk_ahb);
  1347	}
  1348	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28238 bytes --]

             reply	other threads:[~2020-06-21  3:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-21  3:06 kernel test robot [this message]
2020-06-21  3:06 ` drivers/dma/imx-sdma.c:1334:23: warning: comparison of unsigned expression >= 0 is always true kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202006211123.QijIEuKZ%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.