* [PATCH 0/2] prepare dwmac-meson8b for G12A specific initialization
@ 2020-06-20 19:26 ` Martin Blumenstingl
0 siblings, 0 replies; 11+ messages in thread
From: Martin Blumenstingl @ 2020-06-20 19:26 UTC (permalink / raw)
To: davem, netdev, linux-amlogic, robh+dt
Cc: Martin Blumenstingl, devicetree, linux-kernel, linux-arm-kernel
Some users are reporting that RGMII (and sometimes also RMII) Ethernet
is not working for them on G12A/G12B/SM1 boards. Upon closer inspection
of the vendor code for these SoCs new register bits are found.
It's not clear yet how these registers work. Add a new compatible string
as the first preparation step to improve Ethernet support on these SoCs.
Martin Blumenstingl (2):
dt-bindings: net: dwmac-meson: Add a compatible string for G12A
onwards
net: stmmac: dwmac-meson8b: add a compatible string for G12A SoCs
.../devicetree/bindings/net/amlogic,meson-dwmac.yaml | 3 +++
drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 4 ++++
2 files changed, 7 insertions(+)
--
2.27.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 0/2] prepare dwmac-meson8b for G12A specific initialization
@ 2020-06-20 19:26 ` Martin Blumenstingl
0 siblings, 0 replies; 11+ messages in thread
From: Martin Blumenstingl @ 2020-06-20 19:26 UTC (permalink / raw)
To: davem, netdev, linux-amlogic, robh+dt
Cc: Martin Blumenstingl, devicetree, linux-kernel, linux-arm-kernel
Some users are reporting that RGMII (and sometimes also RMII) Ethernet
is not working for them on G12A/G12B/SM1 boards. Upon closer inspection
of the vendor code for these SoCs new register bits are found.
It's not clear yet how these registers work. Add a new compatible string
as the first preparation step to improve Ethernet support on these SoCs.
Martin Blumenstingl (2):
dt-bindings: net: dwmac-meson: Add a compatible string for G12A
onwards
net: stmmac: dwmac-meson8b: add a compatible string for G12A SoCs
.../devicetree/bindings/net/amlogic,meson-dwmac.yaml | 3 +++
drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 4 ++++
2 files changed, 7 insertions(+)
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 1/2] dt-bindings: net: dwmac-meson: Add a compatible string for G12A onwards
2020-06-20 19:26 ` Martin Blumenstingl
(?)
@ 2020-06-20 19:26 ` Martin Blumenstingl
-1 siblings, 0 replies; 11+ messages in thread
From: Martin Blumenstingl @ 2020-06-20 19:26 UTC (permalink / raw)
To: davem, netdev, linux-amlogic, robh+dt
Cc: devicetree, linux-kernel, linux-arm-kernel, Martin Blumenstingl
Amlogic Meson G12A, G12B and SM1 have the same (at least as far as we
know at the time of writing) PRG_ETHERNET glue register implementation.
This implementation however is slightly different from AXG as it now has
an undocument "auto cali idx val" register in PRG_ETH1[17:16] which
seems to be related to RGMII Ethernet.
Add a compatible string for G12A and newer so the new registers can be
used.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
index 64c20c92c07d..85fefe3a0444 100644
--- a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
@@ -22,6 +22,7 @@ select:
- amlogic,meson8m2-dwmac
- amlogic,meson-gxbb-dwmac
- amlogic,meson-axg-dwmac
+ - amlogic,meson-g12a-dwmac
required:
- compatible
@@ -36,6 +37,7 @@ allOf:
- amlogic,meson8m2-dwmac
- amlogic,meson-gxbb-dwmac
- amlogic,meson-axg-dwmac
+ - amlogic,meson-g12a-dwmac
then:
properties:
@@ -95,6 +97,7 @@ properties:
- amlogic,meson8m2-dwmac
- amlogic,meson-gxbb-dwmac
- amlogic,meson-axg-dwmac
+ - amlogic,meson-g12a-dwmac
contains:
enum:
- snps,dwmac-3.70a
--
2.27.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 1/2] dt-bindings: net: dwmac-meson: Add a compatible string for G12A onwards
@ 2020-06-20 19:26 ` Martin Blumenstingl
0 siblings, 0 replies; 11+ messages in thread
From: Martin Blumenstingl @ 2020-06-20 19:26 UTC (permalink / raw)
To: davem, netdev, linux-amlogic, robh+dt
Cc: Martin Blumenstingl, devicetree, linux-kernel, linux-arm-kernel
Amlogic Meson G12A, G12B and SM1 have the same (at least as far as we
know at the time of writing) PRG_ETHERNET glue register implementation.
This implementation however is slightly different from AXG as it now has
an undocument "auto cali idx val" register in PRG_ETH1[17:16] which
seems to be related to RGMII Ethernet.
Add a compatible string for G12A and newer so the new registers can be
used.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
index 64c20c92c07d..85fefe3a0444 100644
--- a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
@@ -22,6 +22,7 @@ select:
- amlogic,meson8m2-dwmac
- amlogic,meson-gxbb-dwmac
- amlogic,meson-axg-dwmac
+ - amlogic,meson-g12a-dwmac
required:
- compatible
@@ -36,6 +37,7 @@ allOf:
- amlogic,meson8m2-dwmac
- amlogic,meson-gxbb-dwmac
- amlogic,meson-axg-dwmac
+ - amlogic,meson-g12a-dwmac
then:
properties:
@@ -95,6 +97,7 @@ properties:
- amlogic,meson8m2-dwmac
- amlogic,meson-gxbb-dwmac
- amlogic,meson-axg-dwmac
+ - amlogic,meson-g12a-dwmac
contains:
enum:
- snps,dwmac-3.70a
--
2.27.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 1/2] dt-bindings: net: dwmac-meson: Add a compatible string for G12A onwards
@ 2020-06-20 19:26 ` Martin Blumenstingl
0 siblings, 0 replies; 11+ messages in thread
From: Martin Blumenstingl @ 2020-06-20 19:26 UTC (permalink / raw)
To: davem, netdev, linux-amlogic, robh+dt
Cc: Martin Blumenstingl, devicetree, linux-kernel, linux-arm-kernel
Amlogic Meson G12A, G12B and SM1 have the same (at least as far as we
know at the time of writing) PRG_ETHERNET glue register implementation.
This implementation however is slightly different from AXG as it now has
an undocument "auto cali idx val" register in PRG_ETH1[17:16] which
seems to be related to RGMII Ethernet.
Add a compatible string for G12A and newer so the new registers can be
used.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
index 64c20c92c07d..85fefe3a0444 100644
--- a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
@@ -22,6 +22,7 @@ select:
- amlogic,meson8m2-dwmac
- amlogic,meson-gxbb-dwmac
- amlogic,meson-axg-dwmac
+ - amlogic,meson-g12a-dwmac
required:
- compatible
@@ -36,6 +37,7 @@ allOf:
- amlogic,meson8m2-dwmac
- amlogic,meson-gxbb-dwmac
- amlogic,meson-axg-dwmac
+ - amlogic,meson-g12a-dwmac
then:
properties:
@@ -95,6 +97,7 @@ properties:
- amlogic,meson8m2-dwmac
- amlogic,meson-gxbb-dwmac
- amlogic,meson-axg-dwmac
+ - amlogic,meson-g12a-dwmac
contains:
enum:
- snps,dwmac-3.70a
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/2] net: stmmac: dwmac-meson8b: add a compatible string for G12A SoCs
2020-06-20 19:26 ` Martin Blumenstingl
(?)
@ 2020-06-20 19:26 ` Martin Blumenstingl
-1 siblings, 0 replies; 11+ messages in thread
From: Martin Blumenstingl @ 2020-06-20 19:26 UTC (permalink / raw)
To: davem, netdev, linux-amlogic, robh+dt
Cc: devicetree, linux-kernel, linux-arm-kernel, Martin Blumenstingl
Amlogic Meson G12A, G12B and SM1 have the same (at least as far as we
know at the time of writing) PRG_ETHERNET glue register implementation.
This implementation however is slightly different from AXG as it now has
an undocument "auto cali idx val" register in PRG_ETH1[17:16] which
seems to be related to RGMII Ethernet.
Add a new compatible string for G12A SoCs so the logic for this new
register can be implemented in the future.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
index 234e8b6816ce..544bc621146c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
@@ -491,6 +491,10 @@ static const struct of_device_id meson8b_dwmac_match[] = {
.compatible = "amlogic,meson-axg-dwmac",
.data = &meson_axg_dwmac_data,
},
+ {
+ .compatible = "amlogic,meson-g12a-dwmac",
+ .data = &meson_axg_dwmac_data,
+ },
{ }
};
MODULE_DEVICE_TABLE(of, meson8b_dwmac_match);
--
2.27.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 2/2] net: stmmac: dwmac-meson8b: add a compatible string for G12A SoCs
@ 2020-06-20 19:26 ` Martin Blumenstingl
0 siblings, 0 replies; 11+ messages in thread
From: Martin Blumenstingl @ 2020-06-20 19:26 UTC (permalink / raw)
To: davem, netdev, linux-amlogic, robh+dt
Cc: Martin Blumenstingl, devicetree, linux-kernel, linux-arm-kernel
Amlogic Meson G12A, G12B and SM1 have the same (at least as far as we
know at the time of writing) PRG_ETHERNET glue register implementation.
This implementation however is slightly different from AXG as it now has
an undocument "auto cali idx val" register in PRG_ETH1[17:16] which
seems to be related to RGMII Ethernet.
Add a new compatible string for G12A SoCs so the logic for this new
register can be implemented in the future.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
index 234e8b6816ce..544bc621146c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
@@ -491,6 +491,10 @@ static const struct of_device_id meson8b_dwmac_match[] = {
.compatible = "amlogic,meson-axg-dwmac",
.data = &meson_axg_dwmac_data,
},
+ {
+ .compatible = "amlogic,meson-g12a-dwmac",
+ .data = &meson_axg_dwmac_data,
+ },
{ }
};
MODULE_DEVICE_TABLE(of, meson8b_dwmac_match);
--
2.27.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 2/2] net: stmmac: dwmac-meson8b: add a compatible string for G12A SoCs
@ 2020-06-20 19:26 ` Martin Blumenstingl
0 siblings, 0 replies; 11+ messages in thread
From: Martin Blumenstingl @ 2020-06-20 19:26 UTC (permalink / raw)
To: davem, netdev, linux-amlogic, robh+dt
Cc: Martin Blumenstingl, devicetree, linux-kernel, linux-arm-kernel
Amlogic Meson G12A, G12B and SM1 have the same (at least as far as we
know at the time of writing) PRG_ETHERNET glue register implementation.
This implementation however is slightly different from AXG as it now has
an undocument "auto cali idx val" register in PRG_ETH1[17:16] which
seems to be related to RGMII Ethernet.
Add a new compatible string for G12A SoCs so the logic for this new
register can be implemented in the future.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
index 234e8b6816ce..544bc621146c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
@@ -491,6 +491,10 @@ static const struct of_device_id meson8b_dwmac_match[] = {
.compatible = "amlogic,meson-axg-dwmac",
.data = &meson_axg_dwmac_data,
},
+ {
+ .compatible = "amlogic,meson-g12a-dwmac",
+ .data = &meson_axg_dwmac_data,
+ },
{ }
};
MODULE_DEVICE_TABLE(of, meson8b_dwmac_match);
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] prepare dwmac-meson8b for G12A specific initialization
2020-06-20 19:26 ` Martin Blumenstingl
` (3 preceding siblings ...)
(?)
@ 2020-06-22 23:24 ` David Miller
-1 siblings, 0 replies; 11+ messages in thread
From: David Miller @ 2020-06-22 23:24 UTC (permalink / raw)
To: martin.blumenstingl
Cc: netdev, linux-amlogic, robh+dt, devicetree, linux-kernel,
linux-arm-kernel
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date: Sat, 20 Jun 2020 21:26:39 +0200
> Some users are reporting that RGMII (and sometimes also RMII) Ethernet
> is not working for them on G12A/G12B/SM1 boards. Upon closer inspection
> of the vendor code for these SoCs new register bits are found.
>
> It's not clear yet how these registers work. Add a new compatible string
> as the first preparation step to improve Ethernet support on these SoCs.
Series applied to net-next, thanks Martin.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 0/2] prepare dwmac-meson8b for G12A specific initialization
2020-06-20 19:26 ` Martin Blumenstingl
` (4 preceding siblings ...)
(?)
@ 2020-08-17 17:48 ` patchwork-bot+linux-amlogic
-1 siblings, 0 replies; 11+ messages in thread
From: patchwork-bot+linux-amlogic @ 2020-08-17 17:48 UTC (permalink / raw)
To: Martin Blumenstingl; +Cc: linux-amlogic, khilman
Hello:
This series was applied to khilman/linux-amlogic.git (refs/heads/for-next).
On Sat, 20 Jun 2020 21:26:39 +0200 you wrote:
> Some users are reporting that RGMII (and sometimes also RMII) Ethernet
> is not working for them on G12A/G12B/SM1 boards. Upon closer inspection
> of the vendor code for these SoCs new register bits are found.
>
> It's not clear yet how these registers work. Add a new compatible string
> as the first preparation step to improve Ethernet support on these SoCs.
>
> [...]
Here is a summary with links:
- [1/2] dt-bindings: net: dwmac-meson: Add a compatible string for G12A onwards
https://git.kernel.org/khilman/linux-amlogic/c/3efdb92426bf479aa87d38a55b66c81d2a60f41b
- [2/2] net: stmmac: dwmac-meson8b: add a compatible string for G12A SoCs
https://git.kernel.org/khilman/linux-amlogic/c/a4f63342d03d2dfb61d9e52f30d084d0780aaddd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/pwbot
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 11+ messages in thread