* [PATCH] [net/sched] tcindex_change: Remove redundant null check
@ 2020-06-22 2:24 Gaurav Singh
2020-06-23 3:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Gaurav Singh @ 2020-06-22 2:24 UTC (permalink / raw)
To: gaurav1086, Jamal Hadi Salim, Cong Wang, Jiri Pirko,
David S. Miller, Jakub Kicinski, open list:TC subsystem,
open list
arg cannot be NULL since its already being dereferenced
before. Remove the redundant NULL check.
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
---
net/sched/cls_tcindex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c
index 61e95029c18f..78bec347b8b6 100644
--- a/net/sched/cls_tcindex.c
+++ b/net/sched/cls_tcindex.c
@@ -533,7 +533,7 @@ tcindex_change(struct net *net, struct sk_buff *in_skb,
pr_debug("tcindex_change(tp %p,handle 0x%08x,tca %p,arg %p),opt %p,"
"p %p,r %p,*arg %p\n",
- tp, handle, tca, arg, opt, p, r, arg ? *arg : NULL);
+ tp, handle, tca, arg, opt, p, r, *arg);
if (!opt)
return 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [net/sched] tcindex_change: Remove redundant null check
2020-06-22 2:24 [PATCH] [net/sched] tcindex_change: Remove redundant null check Gaurav Singh
@ 2020-06-23 3:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-06-23 3:57 UTC (permalink / raw)
To: gaurav1086; +Cc: jhs, xiyou.wangcong, jiri, kuba, netdev, linux-kernel
From: Gaurav Singh <gaurav1086@gmail.com>
Date: Sun, 21 Jun 2020 22:24:30 -0400
> arg cannot be NULL since its already being dereferenced
> before. Remove the redundant NULL check.
>
> Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-23 3:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-22 2:24 [PATCH] [net/sched] tcindex_change: Remove redundant null check Gaurav Singh
2020-06-23 3:57 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.