* [Buildroot] [PATCH] toolchain/wrapper: extend the list of unsafe paths
@ 2020-06-21 20:31 Yann E. MORIN
2020-06-22 20:40 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2020-06-21 20:31 UTC (permalink / raw)
To: buildroot
On some legacy systems, the X11 headers and libs are in /usr/X11R66/include
and /usr/X11R66/lib, and of course, some packages are trying to be smart
and use those paths (even when they do not exist).
Add those to the list of unsafe paths to check in the toolchain wrapper.
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
toolchain/toolchain-wrapper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/toolchain/toolchain-wrapper.c b/toolchain/toolchain-wrapper.c
index 8cfc963ccd..39e9f0850f 100644
--- a/toolchain/toolchain-wrapper.c
+++ b/toolchain/toolchain-wrapper.c
@@ -129,6 +129,8 @@ static const struct str_len_s unsafe_paths[] = {
STR_LEN(/usr/lib),
STR_LEN(/usr/local/include),
STR_LEN(/usr/local/lib),
+ STR_LEN(/usr/X11R6/include),
+ STR_LEN(/usr/X11R6/lib),
{ NULL, 0 },
};
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] toolchain/wrapper: extend the list of unsafe paths
2020-06-21 20:31 [Buildroot] [PATCH] toolchain/wrapper: extend the list of unsafe paths Yann E. MORIN
@ 2020-06-22 20:40 ` Thomas Petazzoni
2020-06-22 20:49 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2020-06-22 20:40 UTC (permalink / raw)
To: buildroot
On Sun, 21 Jun 2020 22:31:58 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> On some legacy systems, the X11 headers and libs are in /usr/X11R66/include
> and /usr/X11R66/lib, and of course, some packages are trying to be smart
> and use those paths (even when they do not exist).
>
> Add those to the list of unsafe paths to check in the toolchain wrapper.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> toolchain/toolchain-wrapper.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied to master, thanks. Do you remember why we don't simply
blacklist /usr entirely ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] toolchain/wrapper: extend the list of unsafe paths
2020-06-22 20:40 ` Thomas Petazzoni
@ 2020-06-22 20:49 ` Yann E. MORIN
0 siblings, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2020-06-22 20:49 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2020-06-22 22:40 +0200, Thomas Petazzoni spake thusly:
> On Sun, 21 Jun 2020 22:31:58 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > On some legacy systems, the X11 headers and libs are in /usr/X11R66/include
> > and /usr/X11R66/lib, and of course, some packages are trying to be smart
> > and use those paths (even when they do not exist).
> >
> > Add those to the list of unsafe paths to check in the toolchain wrapper.
> >
> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> > ---
> > toolchain/toolchain-wrapper.c | 2 ++
> > 1 file changed, 2 insertions(+)
> Applied to master, thanks. Do you remember why we don't simply
> blacklist /usr entirely ?
Becuase that would be too easy? ;-)
No, but same reason we are (trying to be smart when fixing the .la
files, see 7701fc53d1 (infra: support buildroot being located in /usr).
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-22 20:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-21 20:31 [Buildroot] [PATCH] toolchain/wrapper: extend the list of unsafe paths Yann E. MORIN
2020-06-22 20:40 ` Thomas Petazzoni
2020-06-22 20:49 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.