* [PATCH] drm/amdgpu: make sure to reserve tmr region on all asics which support it
@ 2020-06-22 21:41 Alex Deucher
2020-06-24 14:19 ` Alex Deucher
2020-06-24 14:23 ` Nirmoy
0 siblings, 2 replies; 4+ messages in thread
From: Alex Deucher @ 2020-06-22 21:41 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher
This includes older APUs like renoir.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index f1855a8323b2..7d51768684dd 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -1974,7 +1974,7 @@ int amdgpu_ttm_init(struct amdgpu_device *adev)
* If IP discovery enabled, a block of memory should be
* reserved for IP discovey.
*/
- if (adev->asic_type >= CHIP_NAVI10 && amdgpu_discovery) {
+ if (adev->discovery_bin) {
r = amdgpu_ttm_reserve_tmr(adev);
if (r)
return r;
--
2.25.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: make sure to reserve tmr region on all asics which support it
2020-06-22 21:41 [PATCH] drm/amdgpu: make sure to reserve tmr region on all asics which support it Alex Deucher
@ 2020-06-24 14:19 ` Alex Deucher
2020-06-24 14:23 ` Zhang, Hawking
2020-06-24 14:23 ` Nirmoy
1 sibling, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2020-06-24 14:19 UTC (permalink / raw)
To: amd-gfx list; +Cc: Alex Deucher
Ping?
Alex
On Mon, Jun 22, 2020 at 5:41 PM Alex Deucher <alexdeucher@gmail.com> wrote:
>
> This includes older APUs like renoir.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index f1855a8323b2..7d51768684dd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -1974,7 +1974,7 @@ int amdgpu_ttm_init(struct amdgpu_device *adev)
> * If IP discovery enabled, a block of memory should be
> * reserved for IP discovey.
> */
> - if (adev->asic_type >= CHIP_NAVI10 && amdgpu_discovery) {
> + if (adev->discovery_bin) {
> r = amdgpu_ttm_reserve_tmr(adev);
> if (r)
> return r;
> --
> 2.25.4
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: make sure to reserve tmr region on all asics which support it
2020-06-22 21:41 [PATCH] drm/amdgpu: make sure to reserve tmr region on all asics which support it Alex Deucher
2020-06-24 14:19 ` Alex Deucher
@ 2020-06-24 14:23 ` Nirmoy
1 sibling, 0 replies; 4+ messages in thread
From: Nirmoy @ 2020-06-24 14:23 UTC (permalink / raw)
To: amd-gfx
Acked-by: Nirmoy Das <nirmoy.das@amd.com>
On 6/22/20 11:41 PM, Alex Deucher wrote:
> This includes older APUs like renoir.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index f1855a8323b2..7d51768684dd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -1974,7 +1974,7 @@ int amdgpu_ttm_init(struct amdgpu_device *adev)
> * If IP discovery enabled, a block of memory should be
> * reserved for IP discovey.
> */
> - if (adev->asic_type >= CHIP_NAVI10 && amdgpu_discovery) {
> + if (adev->discovery_bin) {
> r = amdgpu_ttm_reserve_tmr(adev);
> if (r)
> return r;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amdgpu: make sure to reserve tmr region on all asics which support it
2020-06-24 14:19 ` Alex Deucher
@ 2020-06-24 14:23 ` Zhang, Hawking
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Hawking @ 2020-06-24 14:23 UTC (permalink / raw)
To: Alex Deucher, amd-gfx list; +Cc: Deucher, Alexander
[AMD Public Use]
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Regards,
Hawking
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex Deucher
Sent: Wednesday, June 24, 2020 22:20
To: amd-gfx list <amd-gfx@lists.freedesktop.org>
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>
Subject: Re: [PATCH] drm/amdgpu: make sure to reserve tmr region on all asics which support it
Ping?
Alex
On Mon, Jun 22, 2020 at 5:41 PM Alex Deucher <alexdeucher@gmail.com> wrote:
>
> This includes older APUs like renoir.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index f1855a8323b2..7d51768684dd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -1974,7 +1974,7 @@ int amdgpu_ttm_init(struct amdgpu_device *adev)
> * If IP discovery enabled, a block of memory should be
> * reserved for IP discovey.
> */
> - if (adev->asic_type >= CHIP_NAVI10 && amdgpu_discovery) {
> + if (adev->discovery_bin) {
> r = amdgpu_ttm_reserve_tmr(adev);
> if (r)
> return r;
> --
> 2.25.4
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Chawking.zhang%40amd.com%7C58a9357a7ff248f908ba08d81849b141%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637286052091665855&sdata=7qVY5igW%2FWn0jt8NUpS1ZfbbP3%2B%2FgYPazigVBIzQqnk%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-24 14:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-22 21:41 [PATCH] drm/amdgpu: make sure to reserve tmr region on all asics which support it Alex Deucher
2020-06-24 14:19 ` Alex Deucher
2020-06-24 14:23 ` Zhang, Hawking
2020-06-24 14:23 ` Nirmoy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.