[dgc-xfs:xfs-async-inode-reclaim-4 30/31] fs/xfs/xfs_inode_item.c:649:1: warning: no previous prototype for function 'xfs_iflush_ail_updates'

[dgc-xfs:xfs-async-inode-reclaim-4 30/31] fs/xfs/xfs_inode_item.c:649:1: warning: no previous prototype for function 'xfs_iflush_ail_updates'

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 4229 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dgc/linux-xfs.git xfs-async-inode-reclaim-4
head:   832cf7c3f1a42e662caff9da758f13c868422b81
commit: 19aba281d8dc0e0bfe900bb2f6848690257679ce [30/31] xfs: factor xfs_iflush_done
config: x86_64-randconfig-r026-20200622 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 1d4c87335d5236ea1f35937e1014980ba961ae34)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        git checkout 19aba281d8dc0e0bfe900bb2f6848690257679ce
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> fs/xfs/xfs_inode_item.c:649:1: warning: no previous prototype for function 'xfs_iflush_ail_updates' [-Wmissing-prototypes]
xfs_iflush_ail_updates(
^
fs/xfs/xfs_inode_item.c:648:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void
^
static
>> fs/xfs/xfs_inode_item.c:679:1: warning: no previous prototype for function 'xfs_iflush_finish' [-Wmissing-prototypes]
xfs_iflush_finish(
^
fs/xfs/xfs_inode_item.c:678:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void
^
static
2 warnings generated.

vim +/xfs_iflush_ail_updates +649 fs/xfs/xfs_inode_item.c

   641	
   642	
   643	/*
   644	 * We only want to pull the item from the AIL if it is actually there
   645	 * and its location in the log has not changed since we started the
   646	 * flush.  Thus, we only bother if the inode's lsn has not changed.
   647	 */
   648	void
 > 649	xfs_iflush_ail_updates(
   650		struct xfs_ail		*ailp,
   651		struct list_head	*list)
   652	{
   653		struct xfs_log_item	*lip;
   654		xfs_lsn_t		tail_lsn = 0;
   655	
   656		/* this is an opencoded batch version of xfs_trans_ail_delete */
   657		spin_lock(&ailp->ail_lock);
   658		list_for_each_entry(lip, list, li_bio_list) {
   659			xfs_lsn_t	lsn;
   660	
   661			clear_bit(XFS_LI_FAILED, &lip->li_flags);
   662			if (INODE_ITEM(lip)->ili_flush_lsn != lip->li_lsn)
   663				continue;
   664	
   665			lsn = xfs_ail_delete_one(ailp, lip);
   666			if (!tail_lsn && lsn)
   667				tail_lsn = lsn;
   668		}
   669		xfs_ail_update_finish(ailp, tail_lsn);
   670	}
   671	
   672	/*
   673	 * Walk the list of inodes that have completed their IOs. If they are clean
   674	 * remove them from the list and dissociate them from the buffer. Buffers that
   675	 * are still dirty remain linked to the buffer and on the list. Caller must
   676	 * handle them appropriately.
   677	 */
   678	void
 > 679	xfs_iflush_finish(
   680		struct xfs_buf		*bp,
   681		struct list_head	*list)
   682	{
   683		struct xfs_log_item	*lip, *n;
   684	
   685		list_for_each_entry_safe(lip, n, list, li_bio_list) {
   686			struct xfs_inode_log_item *iip = INODE_ITEM(lip);
   687			bool	drop_buffer = false;
   688	
   689			spin_lock(&iip->ili_lock);
   690	
   691			/*
   692			 * Remove the reference to the cluster buffer if the inode is
   693			 * clean in memory and drop the buffer reference once we've
   694			 * dropped the locks we hold.
   695			 */
   696			ASSERT(iip->ili_item.li_buf == bp);
   697			if (!iip->ili_fields) {
   698				iip->ili_item.li_buf = NULL;
   699				list_del_init(&lip->li_bio_list);
   700				drop_buffer = true;
   701			}
   702			iip->ili_last_fields = 0;
   703			iip->ili_flush_lsn = 0;
   704			spin_unlock(&iip->ili_lock);
   705			xfs_ifunlock(iip->ili_inode);
   706			if (drop_buffer)
   707				xfs_buf_rele(bp);
   708		}
   709	}
   710	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30837 bytes --]