All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Sumit Gupta <sumitg@nvidia.com>
Cc: rjw@rjwysocki.net, catalin.marinas@arm.com, will@kernel.org,
	thierry.reding@gmail.com, robh+dt@kernel.org,
	devicetree@vger.kernel.org, jonathanh@nvidia.com,
	talho@nvidia.com, linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, bbasu@nvidia.com,
	mperttunen@nvidia.com
Subject: Re: [TEGRA194_CPUFREQ Patch v3 3/4] cpufreq: Add Tegra194 cpufreq driver
Date: Tue, 23 Jun 2020 11:50:20 +0530	[thread overview]
Message-ID: <20200623062020.weg6h4uygelkih7d@vireshk-i7> (raw)
In-Reply-To: <ed6956a3-3f77-2943-6387-5affc25b59d2@nvidia.com>

On 23-06-20, 10:49, Sumit Gupta wrote:
> Hi Viresh,
> 
> Thank you for the review. please find my reply inline.
> 
> 
> > > +++ b/drivers/cpufreq/tegra194-cpufreq.c
> > > @@ -0,0 +1,403 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved
> > 
> >                      2020

You missed this ?

> T194 supports four CPU clusters, each with two cores. Each CPU cluster is
> capable of running at a specific frequency sourced by respective NAFLL to
> provide cluster specific clocks. Individual cores within a cluster write
> freq in per core register. Cluster h/w forwards the max(core0, core1)
> request to per cluster NAFLL.

Okay, this is clear now. Add a comment about this max thing in the
target routine to show why you need to do this on all CPUs.

-- 
viresh

  reply	other threads:[~2020-06-23  6:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-21 21:34 [TEGRA194_CPUFREQ Patch v3 0/4] Add cpufreq driver for Tegra194 Sumit Gupta
2020-06-21 21:34 ` Sumit Gupta
     [not found] ` <1592775274-27513-1-git-send-email-sumitg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-06-21 21:34   ` [TEGRA194_CPUFREQ Patch v3 1/4] dt-bindings: arm: Add t194 ccplex compatible and bpmp property Sumit Gupta
2020-06-21 21:34     ` Sumit Gupta
     [not found]     ` <1592775274-27513-2-git-send-email-sumitg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-06-22  7:22       ` Viresh Kumar
2020-06-22  7:22         ` Viresh Kumar
2020-06-23  6:05         ` Sumit Gupta
2020-06-23  6:05           ` Sumit Gupta
2020-06-21 21:34   ` [TEGRA194_CPUFREQ Patch v3 2/4] arm64: tegra: " Sumit Gupta
2020-06-21 21:34     ` Sumit Gupta
2020-06-21 21:34   ` [TEGRA194_CPUFREQ Patch v3 3/4] cpufreq: Add Tegra194 cpufreq driver Sumit Gupta
2020-06-21 21:34     ` Sumit Gupta
2020-06-22  3:38     ` kernel test robot
2020-06-22  3:38       ` kernel test robot
2020-06-22  5:24       ` Sumit Gupta
2020-06-22  5:24         ` Sumit Gupta
     [not found]     ` <1592775274-27513-4-git-send-email-sumitg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-06-22  7:20       ` Viresh Kumar
2020-06-22  7:20         ` Viresh Kumar
2020-06-23  5:19         ` Sumit Gupta
2020-06-23  5:19           ` Sumit Gupta
2020-06-23  6:20           ` Viresh Kumar [this message]
2020-06-21 21:34   ` [TEGRA194_CPUFREQ Patch v3 4/4] arm64: defconfig: Enable CONFIG_ARM_TEGRA194_CPUFREQ Sumit Gupta
2020-06-21 21:34     ` Sumit Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200623062020.weg6h4uygelkih7d@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=bbasu@nvidia.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mperttunen@nvidia.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=sumitg@nvidia.com \
    --cc=talho@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.