Re: [TEGRA194_CPUFREQ Patch v3 3/4] cpufreq: Add Tegra194 cpufreq driver

From: kernel test robot <lkp@intel.com>
To: Sumit Gupta <sumitg@nvidia.com>,
	rjw@rjwysocki.net, viresh.kumar@linaro.org,
	catalin.marinas@arm.com, will@kernel.org,
	thierry.reding@gmail.com, robh+dt@kernel.org,
	devicetree@vger.kernel.org, jonathanh@nvidia.com,
	talho@nvidia.com, linux-pm@vger.kernel.org
Cc: kbuild-all@lists.01.org
Subject: Re: [TEGRA194_CPUFREQ Patch v3 3/4] cpufreq: Add Tegra194 cpufreq driver
Date: Mon, 22 Jun 2020 11:38:06 +0800	[thread overview]
Message-ID: <202006221149.73bmuu35%lkp@intel.com> (raw)
In-Reply-To: <1592775274-27513-4-git-send-email-sumitg@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1769 bytes --]

Hi Sumit,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on pm/linux-next]
[also build test WARNING on robh/for-next arm64/for-next/core v5.8-rc2 next-20200621]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sumit-Gupta/Add-cpufreq-driver-for-Tegra194/20200622-053622
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/cpufreq/tegra194-cpufreq.c:86:5: warning: no previous prototype for 'map_freq_to_ndiv' [-Wmissing-prototypes]
86 | u16 map_freq_to_ndiv(struct mrq_cpu_ndiv_limits_response *nltbl, u32 freq)
|     ^~~~~~~~~~~~~~~~

vim +/map_freq_to_ndiv +86 drivers/cpufreq/tegra194-cpufreq.c

    85	
  > 86	u16 map_freq_to_ndiv(struct mrq_cpu_ndiv_limits_response *nltbl, u32 freq)
    87	{
    88		return DIV_ROUND_UP(freq * nltbl->pdiv * nltbl->mdiv,
    89				    nltbl->ref_clk_hz / KHZ);
    90	}
    91	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 72568 bytes --]